* [PATCH] padata: add missing __percpu markup in include/linux/padata.h
@ 2010-08-07 16:47 Namhyung Kim
2010-08-07 19:36 ` Tejun Heo
2010-08-11 18:29 ` Steffen Klassert
0 siblings, 2 replies; 6+ messages in thread
From: Namhyung Kim @ 2010-08-07 16:47 UTC (permalink / raw)
To: Herbert Xu, Steffen Klassert; +Cc: Tejun Heo, linux-kernel
parallel_data->queue is a percpu pointer but was missing __percpu markup.
Add it.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
include/linux/padata.h | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/include/linux/padata.h b/include/linux/padata.h
index 8d84062..67df560 100644
--- a/include/linux/padata.h
+++ b/include/linux/padata.h
@@ -96,15 +96,15 @@ struct padata_queue {
* @timer: Reorder timer.
*/
struct parallel_data {
- struct padata_instance *pinst;
- struct padata_queue *queue;
- atomic_t seq_nr;
- atomic_t reorder_objects;
- atomic_t refcnt;
- unsigned int max_seq_nr;
- cpumask_var_t cpumask;
- spinlock_t lock;
- struct timer_list timer;
+ struct padata_instance *pinst;
+ struct padata_queue __percpu *queue;
+ atomic_t seq_nr;
+ atomic_t reorder_objects;
+ atomic_t refcnt;
+ unsigned int max_seq_nr;
+ cpumask_var_t cpumask;
+ spinlock_t lock;
+ struct timer_list timer;
};
/**
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] padata: add missing __percpu markup in include/linux/padata.h
2010-08-07 16:47 [PATCH] padata: add missing __percpu markup in include/linux/padata.h Namhyung Kim
@ 2010-08-07 19:36 ` Tejun Heo
2010-08-11 18:29 ` Steffen Klassert
1 sibling, 0 replies; 6+ messages in thread
From: Tejun Heo @ 2010-08-07 19:36 UTC (permalink / raw)
To: Namhyung Kim; +Cc: Herbert Xu, Steffen Klassert, linux-kernel
On 08/07/2010 06:47 PM, Namhyung Kim wrote:
> parallel_data->queue is a percpu pointer but was missing __percpu markup.
> Add it.
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] padata: add missing __percpu markup in include/linux/padata.h
2010-08-07 16:47 [PATCH] padata: add missing __percpu markup in include/linux/padata.h Namhyung Kim
2010-08-07 19:36 ` Tejun Heo
@ 2010-08-11 18:29 ` Steffen Klassert
2010-08-12 10:54 ` [PATCH resend] " Namhyung Kim
1 sibling, 1 reply; 6+ messages in thread
From: Steffen Klassert @ 2010-08-11 18:29 UTC (permalink / raw)
To: Namhyung Kim; +Cc: Herbert Xu, Tejun Heo, linux-kernel
On Sun, Aug 08, 2010 at 01:47:25AM +0900, Namhyung Kim wrote:
> parallel_data->queue is a percpu pointer but was missing __percpu markup.
> Add it.
>
The patch does not apply, please respin against linux-2.6 git current.
Thanks,
Steffen
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH resend] padata: add missing __percpu markup in include/linux/padata.h
2010-08-11 18:29 ` Steffen Klassert
@ 2010-08-12 10:54 ` Namhyung Kim
2010-08-16 7:13 ` Steffen Klassert
0 siblings, 1 reply; 6+ messages in thread
From: Namhyung Kim @ 2010-08-12 10:54 UTC (permalink / raw)
To: Steffen Klassert; +Cc: Herbert Xu, Tejun Heo, linux-kernel
parallel_data->queue is a percpu pointer but was missing __percpu markup.
Add it.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
include/linux/padata.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/padata.h b/include/linux/padata.h
index bdcd1e9..4633b2f 100644
--- a/include/linux/padata.h
+++ b/include/linux/padata.h
@@ -127,8 +127,8 @@ struct padata_cpumask {
*/
struct parallel_data {
struct padata_instance *pinst;
- struct padata_parallel_queue *pqueue;
- struct padata_serial_queue *squeue;
+ struct padata_parallel_queue __percpu *pqueue;
+ struct padata_serial_queue __percpu *squeue;
atomic_t seq_nr;
atomic_t reorder_objects;
atomic_t refcnt;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH resend] padata: add missing __percpu markup in include/linux/padata.h
2010-08-12 10:54 ` [PATCH resend] " Namhyung Kim
@ 2010-08-16 7:13 ` Steffen Klassert
2010-09-03 11:10 ` Herbert Xu
0 siblings, 1 reply; 6+ messages in thread
From: Steffen Klassert @ 2010-08-16 7:13 UTC (permalink / raw)
To: Namhyung Kim; +Cc: Herbert Xu, Tejun Heo, linux-kernel
On Thu, Aug 12, 2010 at 07:54:27PM +0900, Namhyung Kim wrote:
> parallel_data->queue is a percpu pointer but was missing __percpu markup.
> Add it.
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Thanks,
Steffen
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH resend] padata: add missing __percpu markup in include/linux/padata.h
2010-08-16 7:13 ` Steffen Klassert
@ 2010-09-03 11:10 ` Herbert Xu
0 siblings, 0 replies; 6+ messages in thread
From: Herbert Xu @ 2010-09-03 11:10 UTC (permalink / raw)
To: Steffen Klassert; +Cc: Namhyung Kim, Tejun Heo, linux-kernel
On Mon, Aug 16, 2010 at 09:13:09AM +0200, Steffen Klassert wrote:
> On Thu, Aug 12, 2010 at 07:54:27PM +0900, Namhyung Kim wrote:
> > parallel_data->queue is a percpu pointer but was missing __percpu markup.
> > Add it.
> >
> > Signed-off-by: Namhyung Kim <namhyung@gmail.com>
>
> Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Patch applied. Thanks!
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-03 11:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-07 16:47 [PATCH] padata: add missing __percpu markup in include/linux/padata.h Namhyung Kim
2010-08-07 19:36 ` Tejun Heo
2010-08-11 18:29 ` Steffen Klassert
2010-08-12 10:54 ` [PATCH resend] " Namhyung Kim
2010-08-16 7:13 ` Steffen Klassert
2010-09-03 11:10 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).