* RE: undefined reference to `mmc_pm_notify' when selected MMC without PM.
@ 2010-08-13 11:33 Kukjin Kim
2010-08-16 5:17 ` Uwe Kleine-König
0 siblings, 1 reply; 8+ messages in thread
From: Kukjin Kim @ 2010-08-13 11:33 UTC (permalink / raw)
To: 'Kukjin Kim', linux-arm-kernel, linux-mmc, linux-kernel
Cc: ben-linux, 'Andrew Morton', 'Maxim Levitsky'
Kukjin Kim wrote:
>
> Hi,
>
> Following is build error when selected MMC without PM.
>
> drivers/built-in.o: In function `mmc_alloc_host':
> drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
>
> That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card
> insert/removal during suspend/resume '
> (commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e)
>
> Below is temporary patch for avoiding build error.
> But I'm not sure about this... :-(
>
> ---
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 0efe631..d80cfdc 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device
> *dev)
> init_waitqueue_head(&host->wq);
> INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
> mmc_host_deeper_disable);
> +#ifdef CONFIG_PM
> host->pm_notify.notifier_call = mmc_pm_notify;
> +#endif
>
> /*
> * By default, hosts do not support SGIO or large requests.
>
> ---
Kindly ignore this stuff because I found Uwe's same patch just now ;-)
Sorry for bothering.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: undefined reference to `mmc_pm_notify' when selected MMC without PM.
2010-08-13 11:33 undefined reference to `mmc_pm_notify' when selected MMC without PM Kukjin Kim
@ 2010-08-16 5:17 ` Uwe Kleine-König
2010-08-16 5:29 ` Kukjin Kim
2010-08-16 15:12 ` Randy Dunlap
0 siblings, 2 replies; 8+ messages in thread
From: Uwe Kleine-König @ 2010-08-16 5:17 UTC (permalink / raw)
To: Kukjin Kim
Cc: linux-arm-kernel, linux-mmc, linux-kernel,
'Andrew Morton', 'Maxim Levitsky',
ben-linux
Hello,
On Fri, Aug 13, 2010 at 08:33:40PM +0900, Kukjin Kim wrote:
> Kukjin Kim wrote:
> >
> > Hi,
> >
> > Following is build error when selected MMC without PM.
> >
> > drivers/built-in.o: In function `mmc_alloc_host':
> > drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > make: *** [sub-make] Error 2
> >
> > That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card
> > insert/removal during suspend/resume '
> > (commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e)
> >
> > Below is temporary patch for avoiding build error.
> > But I'm not sure about this... :-(
> >
> > ---
> >
> > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> > index 0efe631..d80cfdc 100644
> > --- a/drivers/mmc/core/host.c
> > +++ b/drivers/mmc/core/host.c
> > @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device
> > *dev)
> > init_waitqueue_head(&host->wq);
> > INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> > INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
> > mmc_host_deeper_disable);
> > +#ifdef CONFIG_PM
> > host->pm_notify.notifier_call = mmc_pm_notify;
> > +#endif
> >
> > /*
> > * By default, hosts do not support SGIO or large requests.
> >
> > ---
>
> Kindly ignore this stuff because I found Uwe's same patch just now ;-)
> Sorry for bothering.
For those who care:
http://mid.gmane.org/1281691473-15481-1-git-send-email-u.kleine-koenig@pengutronix.de
Kgene, do you care to ack this change as it may prod akpm in taking the
fix a bit earlier?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 8+ messages in thread
* RE: undefined reference to `mmc_pm_notify' when selected MMC without PM.
2010-08-16 5:17 ` Uwe Kleine-König
@ 2010-08-16 5:29 ` Kukjin Kim
2010-08-16 15:12 ` Randy Dunlap
1 sibling, 0 replies; 8+ messages in thread
From: Kukjin Kim @ 2010-08-16 5:29 UTC (permalink / raw)
To: 'Uwe Kleine-König'
Cc: linux-arm-kernel, linux-mmc, linux-kernel,
'Andrew Morton', 'Maxim Levitsky',
ben-linux
Uwe Kleine-Konig wrote:
>
> Hello,
>
Hi :-)
> On Fri, Aug 13, 2010 at 08:33:40PM +0900, Kukjin Kim wrote:
> > Kukjin Kim wrote:
> > >
> > > Hi,
> > >
> > > Following is build error when selected MMC without PM.
> > >
> > > drivers/built-in.o: In function `mmc_alloc_host':
> > > drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify'
> > > make[1]: *** [.tmp_vmlinux1] Error 1
> > > make: *** [sub-make] Error 2
> > >
> > > That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card
> > > insert/removal during suspend/resume '
> > > (commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e)
> > >
> > > Below is temporary patch for avoiding build error.
> > > But I'm not sure about this... :-(
> > >
> > > ---
> > >
> > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> > > index 0efe631..d80cfdc 100644
> > > --- a/drivers/mmc/core/host.c
> > > +++ b/drivers/mmc/core/host.c
> > > @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct
> device
> > > *dev)
> > > init_waitqueue_head(&host->wq);
> > > INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> > > INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
> > > mmc_host_deeper_disable);
> > > +#ifdef CONFIG_PM
> > > host->pm_notify.notifier_call = mmc_pm_notify;
> > > +#endif
> > >
> > > /*
> > > * By default, hosts do not support SGIO or large requests.
> > >
> > > ---
> >
> > Kindly ignore this stuff because I found Uwe's same patch just now ;-)
> > Sorry for bothering.
> For those who care:
>
> http://mid.gmane.org/1281691473-15481-1-git-send-email-u.kleine-
> koenig@pengutronix.de
>
> Kgene, do you care to ack this change as it may prod akpm in taking the
> fix a bit earlier?
>
Sure, I did it.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: undefined reference to `mmc_pm_notify' when selected MMC without PM.
2010-08-16 5:17 ` Uwe Kleine-König
2010-08-16 5:29 ` Kukjin Kim
@ 2010-08-16 15:12 ` Randy Dunlap
2010-08-18 6:38 ` Uwe Kleine-König
1 sibling, 1 reply; 8+ messages in thread
From: Randy Dunlap @ 2010-08-16 15:12 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Kukjin Kim, linux-arm-kernel, linux-mmc, linux-kernel,
'Andrew Morton', 'Maxim Levitsky',
ben-linux
On Mon, 16 Aug 2010 07:17:21 +0200 Uwe Kleine-König wrote:
> Hello,
>
> On Fri, Aug 13, 2010 at 08:33:40PM +0900, Kukjin Kim wrote:
> > Kukjin Kim wrote:
> > >
> > > Hi,
> > >
> > > Following is build error when selected MMC without PM.
> > >
> > > drivers/built-in.o: In function `mmc_alloc_host':
> > > drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify'
> > > make[1]: *** [.tmp_vmlinux1] Error 1
> > > make: *** [sub-make] Error 2
> > >
> > > That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card
> > > insert/removal during suspend/resume '
> > > (commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e)
> > >
> > > Below is temporary patch for avoiding build error.
> > > But I'm not sure about this... :-(
> > >
> > > ---
> > >
> > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> > > index 0efe631..d80cfdc 100644
> > > --- a/drivers/mmc/core/host.c
> > > +++ b/drivers/mmc/core/host.c
> > > @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device
> > > *dev)
> > > init_waitqueue_head(&host->wq);
> > > INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> > > INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
> > > mmc_host_deeper_disable);
> > > +#ifdef CONFIG_PM
> > > host->pm_notify.notifier_call = mmc_pm_notify;
> > > +#endif
> > >
> > > /*
> > > * By default, hosts do not support SGIO or large requests.
> > >
> > > ---
> >
> > Kindly ignore this stuff because I found Uwe's same patch just now ;-)
> > Sorry for bothering.
> For those who care:
>
> http://mid.gmane.org/1281691473-15481-1-git-send-email-u.kleine-koenig@pengutronix.de
>
> Kgene, do you care to ack this change as it may prod akpm in taking the
> fix a bit earlier?
or this one from earlier:
http://lkml.org/lkml/2010/8/12/207
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: undefined reference to `mmc_pm_notify' when selected MMC without PM.
2010-08-16 15:12 ` Randy Dunlap
@ 2010-08-18 6:38 ` Uwe Kleine-König
2010-08-18 6:48 ` Sam Ravnborg
0 siblings, 1 reply; 8+ messages in thread
From: Uwe Kleine-König @ 2010-08-18 6:38 UTC (permalink / raw)
To: Randy Dunlap
Cc: Kukjin Kim, 'Maxim Levitsky',
linux-mmc, linux-kernel, ben-linux, 'Andrew Morton',
linux-arm-kernel
Hello Randy,
On Mon, Aug 16, 2010 at 08:12:39AM -0700, Randy Dunlap wrote:
> On Mon, 16 Aug 2010 07:17:21 +0200 Uwe Kleine-König wrote:
>
> > Hello,
> >
> > On Fri, Aug 13, 2010 at 08:33:40PM +0900, Kukjin Kim wrote:
> > > Kukjin Kim wrote:
> > > >
> > > > Hi,
> > > >
> > > > Following is build error when selected MMC without PM.
> > > >
> > > > drivers/built-in.o: In function `mmc_alloc_host':
> > > > drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify'
> > > > make[1]: *** [.tmp_vmlinux1] Error 1
> > > > make: *** [sub-make] Error 2
> > > >
> > > > That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card
> > > > insert/removal during suspend/resume '
> > > > (commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e)
> > > >
> > > > Below is temporary patch for avoiding build error.
> > > > But I'm not sure about this... :-(
> > > >
> > > > ---
> > > >
> > > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> > > > index 0efe631..d80cfdc 100644
> > > > --- a/drivers/mmc/core/host.c
> > > > +++ b/drivers/mmc/core/host.c
> > > > @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device
> > > > *dev)
> > > > init_waitqueue_head(&host->wq);
> > > > INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> > > > INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
> > > > mmc_host_deeper_disable);
> > > > +#ifdef CONFIG_PM
> > > > host->pm_notify.notifier_call = mmc_pm_notify;
> > > > +#endif
> > > >
> > > > /*
> > > > * By default, hosts do not support SGIO or large requests.
> > > >
> > > > ---
> > >
> > > Kindly ignore this stuff because I found Uwe's same patch just now ;-)
> > > Sorry for bothering.
> > For those who care:
> >
> > http://mid.gmane.org/1281691473-15481-1-git-send-email-u.kleine-koenig@pengutronix.de
> >
> > Kgene, do you care to ack this change as it may prod akpm in taking the
> > fix a bit earlier?
>
> or this one from earlier:
> http://lkml.org/lkml/2010/8/12/207
If I found your patch on gmane I could answer it with an Ack, on lkml
and kerneltrap (where I found it) I don't get the Message-Id header.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: undefined reference to `mmc_pm_notify' when selected MMC without PM.
2010-08-18 6:38 ` Uwe Kleine-König
@ 2010-08-18 6:48 ` Sam Ravnborg
0 siblings, 0 replies; 8+ messages in thread
From: Sam Ravnborg @ 2010-08-18 6:48 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Randy Dunlap, Kukjin Kim, 'Maxim Levitsky',
linux-mmc, linux-kernel, ben-linux, 'Andrew Morton',
linux-arm-kernel
> >
> > or this one from earlier:
> > http://lkml.org/lkml/2010/8/12/207
>
> If I found your patch on gmane I could answer it with an Ack, on lkml
> and kerneltrap (where I found it) I don't get the Message-Id header.
Hi Uwe.
lkml.org has a nice "forward" feature. Look for [forward]
on the second line just below the RSS image.
The mail I reply to is forwarded from lkml.org in this way.
this has been my way to answer lkml mails in periods where
I have not been subscribed and works well.
Sam
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: undefined reference to `mmc_pm_notify' when selected MMC without PM.
2010-08-13 10:36 Kukjin Kim
@ 2010-08-13 13:14 ` Sergei Shtylyov
0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2010-08-13 13:14 UTC (permalink / raw)
To: Kukjin Kim
Cc: linux-arm-kernel, linux-mmc, linux-kernel,
'Andrew Morton', 'Maxim Levitsky',
ben-linux
Hello.
Kukjin Kim wrote:
> Following is build error when selected MMC without PM.
> drivers/built-in.o: In function `mmc_alloc_host':
> drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
> That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card
> insert/removal during suspend/resume '
> (commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e)
> Below is temporary patch for avoiding build error.
> But I'm not sure about this... :-(
> ---
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> index 0efe631..d80cfdc 100644
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device
> *dev)
> init_waitqueue_head(&host->wq);
> INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
> mmc_host_deeper_disable);
Looks like your patch is line-wrapped...
> +#ifdef CONFIG_PM
> host->pm_notify.notifier_call = mmc_pm_notify;
> +#endif
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread
* undefined reference to `mmc_pm_notify' when selected MMC without PM.
@ 2010-08-13 10:36 Kukjin Kim
2010-08-13 13:14 ` Sergei Shtylyov
0 siblings, 1 reply; 8+ messages in thread
From: Kukjin Kim @ 2010-08-13 10:36 UTC (permalink / raw)
To: linux-arm-kernel, linux-mmc, linux-kernel
Cc: ben-linux, 'Andrew Morton', 'Maxim Levitsky'
Hi,
Following is build error when selected MMC without PM.
drivers/built-in.o: In function `mmc_alloc_host':
drivers/mmc/core/host.c:108: undefined reference to `mmc_pm_notify'
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [sub-make] Error 2
That is added from Maxim's ' mmc: fix all hangs related to mmc/sd card
insert/removal during suspend/resume '
(commit ID: 4c2ef25fe0b847d2ae818f74758ddb0be1c27d8e)
Below is temporary patch for avoiding build error.
But I'm not sure about this... :-(
---
diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
index 0efe631..d80cfdc 100644
--- a/drivers/mmc/core/host.c
+++ b/drivers/mmc/core/host.c
@@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device
*dev)
init_waitqueue_head(&host->wq);
INIT_DELAYED_WORK(&host->detect, mmc_rescan);
INIT_DELAYED_WORK_DEFERRABLE(&host->disable,
mmc_host_deeper_disable);
+#ifdef CONFIG_PM
host->pm_notify.notifier_call = mmc_pm_notify;
+#endif
/*
* By default, hosts do not support SGIO or large requests.
---
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-08-18 6:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-13 11:33 undefined reference to `mmc_pm_notify' when selected MMC without PM Kukjin Kim
2010-08-16 5:17 ` Uwe Kleine-König
2010-08-16 5:29 ` Kukjin Kim
2010-08-16 15:12 ` Randy Dunlap
2010-08-18 6:38 ` Uwe Kleine-König
2010-08-18 6:48 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2010-08-13 10:36 Kukjin Kim
2010-08-13 13:14 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).