* [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.
@ 2010-08-30 7:52 Jin Dongming
2010-08-30 7:57 ` [lm-sensors] " Jean Delvare
0 siblings, 1 reply; 8+ messages in thread
From: Jin Dongming @ 2010-08-30 7:52 UTC (permalink / raw)
To: Fenghua Yu
Cc: Brown, Len, lm-sensors, H. Peter Anvin, mingo Redhat,
Thomas Gleixner, Hidetoshi Seto, LKLM
In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.
I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.
I think this patch will fix it.
Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
---
arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index d9368ee..2f9f468 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
static void unexpected_thermal_interrupt(void)
{
- printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+ printk(KERN_ERR "CPU%d: Unexpected LVT Thermal Interrupt!\n",
smp_processor_id());
add_taint(TAINT_MACHINE_CHECK);
}
--
1.7.1.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [lm-sensors] [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.
2010-08-30 7:52 [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal Jin Dongming
@ 2010-08-30 7:57 ` Jean Delvare
2010-08-31 0:13 ` [Patch-next -v2]therm_throt.c: " Jin Dongming
0 siblings, 1 reply; 8+ messages in thread
From: Jean Delvare @ 2010-08-30 7:57 UTC (permalink / raw)
To: Jin Dongming
Cc: Fenghua Yu, Brown, Len, Hidetoshi Seto, LKLM, lm-sensors,
mingo Redhat, Thomas Gleixner, H. Peter Anvin
On Mon, 30 Aug 2010 16:52:56 +0900, Jin Dongming wrote:
> In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
> in error message.
>
> I don't think TMR is a suitable abbreviation for thermal.
> 1.TMR has been used in IA32 Architectures Software Developer's
> Manual, and is the abbreviation for Trigger Mode Register.
> 2.There is not an standard abbreviation "TMR" defined for thermal
> in IA32 Architectures Software Developer's Manual.
> 3.Though we could understand it as Thermal Monitor Register, it is
> easy to be misunderstood as a *TIMER* interrupt also.
>
> I think this patch will fix it.
>
> Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
> ---
> arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> index d9368ee..2f9f468 100644
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
>
> static void unexpected_thermal_interrupt(void)
> {
> - printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
> + printk(KERN_ERR "CPU%d: Unexpected LVT Thermal Interrupt!\n",
> smp_processor_id());
> add_taint(TAINT_MACHINE_CHECK);
> }
I see no good reason to upper-case the first letter of each word. This
is a kernel log message, not a movie title.
Other than that, I agree with your proposal.
--
Jean Delvare
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.
2010-08-30 7:57 ` [lm-sensors] " Jean Delvare
@ 2010-08-31 0:13 ` Jin Dongming
2010-08-31 6:56 ` Jean Delvare
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Jin Dongming @ 2010-08-31 0:13 UTC (permalink / raw)
To: Jean Delvare, Fenghua Yu
Cc: Brown, Len, Hidetoshi Seto, LKLM, lm-sensors, mingo Redhat,
Thomas Gleixner, H. Peter Anvin
In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.
I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.
I think this patch will fix it.
Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
---
arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index d9368ee..ba52598 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
static void unexpected_thermal_interrupt(void)
{
- printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+ printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
smp_processor_id());
add_taint(TAINT_MACHINE_CHECK);
}
--
1.7.1.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.
2010-08-31 0:13 ` [Patch-next -v2]therm_throt.c: " Jin Dongming
@ 2010-08-31 6:56 ` Jean Delvare
2010-08-31 17:30 ` Fenghua Yu
2010-09-05 13:06 ` [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal' tip-bot for Jin Dongming
2010-09-05 18:30 ` [tip:x86/debug] therm_throt.c: Trivial " tip-bot for Jin Dongming
2 siblings, 1 reply; 8+ messages in thread
From: Jean Delvare @ 2010-08-31 6:56 UTC (permalink / raw)
To: Jin Dongming
Cc: Fenghua Yu, Brown, Len, Hidetoshi Seto, LKLM, lm-sensors,
mingo Redhat, Thomas Gleixner, H. Peter Anvin
On Tue, 31 Aug 2010 09:13:33 +0900, Jin Dongming wrote:
> In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
> in error message.
>
> I don't think TMR is a suitable abbreviation for thermal.
> 1.TMR has been used in IA32 Architectures Software Developer's
> Manual, and is the abbreviation for Trigger Mode Register.
> 2.There is not an standard abbreviation "TMR" defined for thermal
> in IA32 Architectures Software Developer's Manual.
> 3.Though we could understand it as Thermal Monitor Register, it is
> easy to be misunderstood as a *TIMER* interrupt also.
>
> I think this patch will fix it.
>
> Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Reviewed-by: Jean Delvare <khali@linux-fr.org>
> ---
> arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> index d9368ee..ba52598 100644
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
>
> static void unexpected_thermal_interrupt(void)
> {
> - printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
> + printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
> smp_processor_id());
> add_taint(TAINT_MACHINE_CHECK);
> }
--
Jean Delvare
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Patch-next -v2]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal.
2010-08-31 6:56 ` Jean Delvare
@ 2010-08-31 17:30 ` Fenghua Yu
0 siblings, 0 replies; 8+ messages in thread
From: Fenghua Yu @ 2010-08-31 17:30 UTC (permalink / raw)
To: Jean Delvare
Cc: Jin Dongming, Yu, Fenghua, Brown, Len, Hidetoshi Seto, LKLM,
lm-sensors, mingo Redhat, Thomas Gleixner, H. Peter Anvin
On Mon, Aug 30, 2010 at 11:56:53PM -0700, Jean Delvare wrote:
> On Tue, 31 Aug 2010 09:13:33 +0900, Jin Dongming wrote:
> > In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
> > in error message.
> >
> > I don't think TMR is a suitable abbreviation for thermal.
> > 1.TMR has been used in IA32 Architectures Software Developer's
> > Manual, and is the abbreviation for Trigger Mode Register.
> > 2.There is not an standard abbreviation "TMR" defined for thermal
> > in IA32 Architectures Software Developer's Manual.
> > 3.Though we could understand it as Thermal Monitor Register, it is
> > easy to be misunderstood as a *TIMER* interrupt also.
> >
> > I think this patch will fix it.
> >
> > Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
>
> Reviewed-by: Jean Delvare <khali@linux-fr.org>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
>
> > ---
> > arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > index d9368ee..ba52598 100644
> > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > @@ -349,7 +349,7 @@ static void intel_thermal_interrupt(void)
> >
> > static void unexpected_thermal_interrupt(void)
> > {
> > - printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
> > + printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
> > smp_processor_id());
> > add_taint(TAINT_MACHINE_CHECK);
> > }
>
>
> --
> Jean Delvare
^ permalink raw reply [flat|nested] 8+ messages in thread
* [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'
2010-08-31 0:13 ` [Patch-next -v2]therm_throt.c: " Jin Dongming
2010-08-31 6:56 ` Jean Delvare
@ 2010-09-05 13:06 ` tip-bot for Jin Dongming
2010-09-05 16:59 ` Jean Delvare
2010-09-05 18:30 ` [tip:x86/debug] therm_throt.c: Trivial " tip-bot for Jin Dongming
2 siblings, 1 reply; 8+ messages in thread
From: tip-bot for Jin Dongming @ 2010-09-05 13:06 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, lm-sensors, jin.dongming,
seto.hidetoshi, fenghua.yu, khali, tglx, hpa, mingo, len.brown
Commit-ID: 6981fe03b2055685fb6da40f54518bc6baf2b751
Gitweb: http://git.kernel.org/tip/6981fe03b2055685fb6da40f54518bc6baf2b751
Author: Jin Dongming <jin.dongming@np.css.fujitsu.com>
AuthorDate: Tue, 31 Aug 2010 09:13:33 +0900
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 5 Sep 2010 14:39:15 +0200
therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'
In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.
I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.
I think this patch will fix it.
Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Cc: Brown
Cc: Len <len.brown@intel.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org>
Cc: H. Peter Anvin <hpa@linux.intel.com>
Cc: Jean Delvare <khali@linux-fr.org>
Cc: Fenghua Yu <fenghua.yu@intel.com>
LKML-Reference: <4C7C492D.5020704@np.css.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index c2a8b26..1d0f743 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -348,7 +348,7 @@ static void intel_thermal_interrupt(void)
static void unexpected_thermal_interrupt(void)
{
- printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+ printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
smp_processor_id());
add_taint(TAINT_MACHINE_CHECK);
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'
2010-09-05 13:06 ` [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal' tip-bot for Jin Dongming
@ 2010-09-05 16:59 ` Jean Delvare
0 siblings, 0 replies; 8+ messages in thread
From: Jean Delvare @ 2010-09-05 16:59 UTC (permalink / raw)
To: mingo, hpa, linux-kernel, jin.dongming, lm-sensors,
seto.hidetoshi, fenghua.yu, khali, tglx, hpa, mingo, len.brown
Cc: jin.dongming, linux-tip-commits, linux-kernel, hpa, lm-sensors,
seto.hidetoshi, fenghua.yu, tglx, hpa, mingo, len.brown
6 people and 2 mailing lists Cc'd for a one-line trivial patch??
On Sun, 5 Sep 2010 13:06:45 GMT, tip-bot for Jin Dongming wrote:
> Commit-ID: 6981fe03b2055685fb6da40f54518bc6baf2b751
> Gitweb: http://git.kernel.org/tip/6981fe03b2055685fb6da40f54518bc6baf2b751
> Author: Jin Dongming <jin.dongming@np.css.fujitsu.com>
> AuthorDate: Tue, 31 Aug 2010 09:13:33 +0900
> Committer: Ingo Molnar <mingo@elte.hu>
> CommitDate: Sun, 5 Sep 2010 14:39:15 +0200
>
> therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal'
Typo: trivial.
>
> In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
> in error message.
>
> I don't think TMR is a suitable abbreviation for thermal.
> 1.TMR has been used in IA32 Architectures Software Developer's
> Manual, and is the abbreviation for Trigger Mode Register.
> 2.There is not an standard abbreviation "TMR" defined for thermal
> in IA32 Architectures Software Developer's Manual.
> 3.Though we could understand it as Thermal Monitor Register, it is
> easy to be misunderstood as a *TIMER* interrupt also.
>
> I think this patch will fix it.
>
> Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
> Cc: Brown
> Cc: Len <len.brown@intel.com>
Something's fishy here.
> Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> Cc: lm-sensors@lm-sensors.org <lm-sensors@lm-sensors.org>
Mailing lists shouldn't be included in Cc headers.
> Cc: H. Peter Anvin <hpa@linux.intel.com>
> Cc: Jean Delvare <khali@linux-fr.org>
This should read:
Reviewed-by: Jean Delvare <khali@linux-fr.org>
> Cc: Fenghua Yu <fenghua.yu@intel.com>
> LKML-Reference: <4C7C492D.5020704@np.css.fujitsu.com>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
> arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> index c2a8b26..1d0f743 100644
> --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> @@ -348,7 +348,7 @@ static void intel_thermal_interrupt(void)
>
> static void unexpected_thermal_interrupt(void)
> {
> - printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
> + printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
> smp_processor_id());
> add_taint(TAINT_MACHINE_CHECK);
> }
--
Jean Delvare
^ permalink raw reply [flat|nested] 8+ messages in thread
* [tip:x86/debug] therm_throt.c: Trivial printk message fix for a unsuitable abbreviation of 'thermal'
2010-08-31 0:13 ` [Patch-next -v2]therm_throt.c: " Jin Dongming
2010-08-31 6:56 ` Jean Delvare
2010-09-05 13:06 ` [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal' tip-bot for Jin Dongming
@ 2010-09-05 18:30 ` tip-bot for Jin Dongming
2 siblings, 0 replies; 8+ messages in thread
From: tip-bot for Jin Dongming @ 2010-09-05 18:30 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, hpa, mingo, jin.dongming, seto.hidetoshi,
fenghua.yu, khali, tglx, mingo, len.brown
Commit-ID: 592091c0e21655bfbdf68741dd5a920c2ac2bbe6
Gitweb: http://git.kernel.org/tip/592091c0e21655bfbdf68741dd5a920c2ac2bbe6
Author: Jin Dongming <jin.dongming@np.css.fujitsu.com>
AuthorDate: Tue, 31 Aug 2010 09:13:33 +0900
Committer: Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 5 Sep 2010 20:26:50 +0200
therm_throt.c: Trivial printk message fix for a unsuitable abbreviation of 'thermal'
In unexpected_thermal_interrupt(), "LVT TMR interrupt" is used
in error message.
I don't think TMR is a suitable abbreviation for thermal.
1.TMR has been used in IA32 Architectures Software Developer's
Manual, and is the abbreviation for Trigger Mode Register.
2.There is not an standard abbreviation "TMR" defined for thermal
in IA32 Architectures Software Developer's Manual.
3.Though we could understand it as Thermal Monitor Register, it is
easy to be misunderstood as a *TIMER* interrupt also.
I think this patch will fix it.
Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Reviewed-by: Jean Delvare <khali@linux-fr.org>
Cc: Brown Len <len.brown@intel.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
LKML-Reference: <4C7C492D.5020704@np.css.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/kernel/cpu/mcheck/therm_throt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index c2a8b26..1d0f743 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -348,7 +348,7 @@ static void intel_thermal_interrupt(void)
static void unexpected_thermal_interrupt(void)
{
- printk(KERN_ERR "CPU%d: Unexpected LVT TMR interrupt!\n",
+ printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
smp_processor_id());
add_taint(TAINT_MACHINE_CHECK);
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2010-09-05 18:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-30 7:52 [Patch-next]therm_throt.c: Trival fix for a unsuitable abbreviation of thermal Jin Dongming
2010-08-30 7:57 ` [lm-sensors] " Jean Delvare
2010-08-31 0:13 ` [Patch-next -v2]therm_throt.c: " Jin Dongming
2010-08-31 6:56 ` Jean Delvare
2010-08-31 17:30 ` Fenghua Yu
2010-09-05 13:06 ` [tip:x86/debug] therm_throt.c: Trival printk message fix for a unsuitable abbreviation of 'thermal' tip-bot for Jin Dongming
2010-09-05 16:59 ` Jean Delvare
2010-09-05 18:30 ` [tip:x86/debug] therm_throt.c: Trivial " tip-bot for Jin Dongming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).