From: Florian Mickler <florian@mickler.org>
To: Joe Perches <joe@perches.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Hemminger <shemminger@vyatta.com>,
Wolfram Sang <w.sang@pengutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scripts/get_maintainer.pl: Add --git-blame --rolestats "Authored lines" information
Date: Sat, 11 Sep 2010 12:02:43 +0200 [thread overview]
Message-ID: <20100911120243.7cce451e@schatten.dmk.lab> (raw)
In-Reply-To: <1284198750.12180.18.camel@Joe-Laptop>
On Sat, 11 Sep 2010 02:52:30 -0700
Joe Perches <joe@perches.com> wrote:
> On Sat, 2010-09-11 at 11:38 +0200, Florian Mickler wrote:
> > On Fri, 10 Sep 2010 17:22:21 -0700
> > Joe Perches <joe@perches.com> wrote:
> > > > > Something based on percentage of the driver written rather than log
> > > > > entry counts might also be interesting.
> > > > There is a --git-blame option, but it uses a count of file commits
> > > > active in the file rather than % of lines authored.
> > > When options --git-blame and --rolestats are specified, add
> > > the maintainers with the qualifying --git-min-percent amount
> > > of lines authored of the complete file. Does not add more
> > > authors than specified by --git-max-maintainers.
> > > For anyone using hg, this option works but is _very_ slow.
> > > It's orders of magnitude slower than git slow.
> > > The get_maintainer.pl version was incremented to 0.25.
> > > This can be used with or without --git.
> > I think this is a good change. I also think this should be made
> > default. (linestat is probably more of a hint then nr of commits.
>
> It's OK but make it default? No.
>
> It's slower. A lot slower.
> git blame takes a very long time. It can take minutes.
> If you're using hg, it can take a lot more than that.
>
> Run it on something like MAINTAINERS or a largish
> active driver and see.
Point taken.
> It also doesn't favor recent changes and newer, active
> authors. It also can overemphasis submitters that are
> no longer active.
>
>
But at least there is a reason to cc the guy. He wrote it after all.
Cheers,
Flo
next prev parent reply other threads:[~2010-09-11 10:02 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 9:33 [PATCH] get_maintainer.pl: append reason for cc to the name by default florian
2010-09-10 9:42 ` Joe Perches
2010-09-10 9:46 ` Wolfram Sang
2010-09-10 9:53 ` Mark Brown
2010-09-10 10:04 ` Joe Perches
2010-09-10 10:18 ` Mark Brown
2010-09-10 10:47 ` Joe Perches
2010-09-10 11:07 ` Mark Brown
2010-09-11 0:22 ` [PATCH] scripts/get_maintainer.pl: Add --git-blame --rolestats "Authored lines" information Joe Perches
2010-09-11 9:38 ` Florian Mickler
2010-09-11 9:52 ` Joe Perches
2010-09-11 10:02 ` Florian Mickler [this message]
2010-09-11 10:22 ` Joe Perches
2010-09-11 19:22 ` [PATCH] Documentation/SubmittingPatches: Add and describe scripts/get_maintainer.pl Joe Perches
2010-09-11 19:34 ` Florian Mickler
2010-09-11 19:43 ` [PATCH V2] " Joe Perches
2010-09-12 16:18 ` Florian Mickler
2010-09-10 11:44 ` [PATCH] get_maintainer.pl: append reason for cc to the name by default Alan Cox
2010-09-10 10:22 ` Florian Mickler
2010-09-10 10:47 ` Joe Perches
2010-09-11 21:22 ` Joe Perches
2010-09-10 10:30 ` Florian Mickler
2010-09-10 11:04 ` Mark Brown
2010-09-10 11:15 ` Florian Mickler
2010-09-10 21:04 ` Andrew Morton
2010-09-10 21:39 ` Florian Mickler
2010-09-10 21:44 ` Joe Perches
2010-09-13 4:01 ` Valdis.Kletnieks
2010-09-13 5:21 ` [PATCH] get_maintainer.pl: Look for .get_maintainer.conf in lk, then $HOME then scripts Joe Perches
2010-09-13 6:13 ` Florian Mickler
2010-09-13 13:21 ` Valdis.Kletnieks
2010-09-10 11:11 ` [PATCH] get_maintainer.pl: append reason for cc to the name by default Florian Mickler
2010-09-10 15:12 ` Joe Perches
2010-09-11 9:34 ` Florian Mickler
2010-09-11 0:13 ` Christoph Hellwig
2010-09-11 0:31 ` Joe Perches
2010-09-11 0:45 ` Christoph Hellwig
2010-09-11 0:56 ` Joe Perches
2010-09-11 9:28 ` Florian Mickler
2010-09-13 7:16 ` Eric W. Biederman
2010-09-13 7:57 ` Joe Perches
2010-09-13 8:54 ` Florian Mickler
2010-09-14 17:19 ` Eric W. Biederman
2010-09-14 17:46 ` Florian Mickler
2010-09-15 3:28 ` Joe Perches
2010-09-15 4:34 ` Florian Mickler
2010-09-15 4:45 ` Joe Perches
2010-09-15 12:49 ` Florian Mickler
2010-09-14 23:15 ` Joe Perches
2010-09-13 9:01 ` Florian Mickler
2010-09-14 17:24 ` Eric W. Biederman
2010-09-26 18:52 ` RFC: " Joe Perches
2010-09-27 14:57 ` Florian Mickler
2010-09-27 15:44 ` Ted Ts'o
2010-09-27 17:00 ` Florian Mickler
2010-09-27 18:21 ` Ted Ts'o
2010-09-27 19:26 ` Florian Mickler
2010-09-27 20:08 ` Joe Perches
2010-09-27 20:47 ` Ted Ts'o
2010-09-27 21:16 ` Joe Perches
2010-09-28 4:22 ` Ted Ts'o
2010-09-28 4:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100911120243.7cce451e@schatten.dmk.lab \
--to=florian@mickler.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).