From: Florian Mickler <florian@mickler.org>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Joe Perches <joe@perches.com>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Hemminger <shemminger@vyatta.com>,
Wolfram Sang <w.sang@pengutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: RFC: get_maintainer.pl: append reason for cc to the name by default
Date: Mon, 27 Sep 2010 19:00:26 +0200 [thread overview]
Message-ID: <20100927190026.20ddc268@schatten.dmk.lab> (raw)
In-Reply-To: <20100927154441.GE3602@thunk.org>
On Mon, 27 Sep 2010 11:44:41 -0400
Ted Ts'o <tytso@mit.edu> wrote:
> On Mon, Sep 27, 2010 at 04:57:48PM +0200, Florian Mickler wrote:
> >
> > Would in essence have the same effect, but I think it's slightly better
> > to have some shorter tags in the mail addresses, as I expect them to
> > actually show up on lkml quite a bit.
>
> What if there are no tags on mail addresses that come from the
> MAINTAINERS file, but only tags on the mail addresses that come from
> guessing wildly based on git sign-offs? People should just be looking
> in the MAINTAINERS file, after all, and I don't think that's something
> that needs an explanation.
>
> The thing that needs explanation is when someone like Steve Hemminger
> gets cc'ed on a patch for fs/ext4/acl.c, which really makes no sense
> at all, where you desperately need some kind of tag:
>
> shemminger@vyatta.com (Wild guess using get_maintainer.pl --git)
>
> - Ted
Might make sense to omit the tags on the MAINTAINER-source. I can
agree to your reasoning there.
As far as I can see, the use and the use cases for the git-part of
get_maintainer.pl are mostly to get patches to not-so-well-maintained
parts of the tree upstream. What I envision for the git part is a
scoring based classification scheme that uses all readily available
information of the git-history to determine relevant people for patch
review and patch routing.
I already have implemented a small parser that extracts that information
out of git-log and makes them available to the script, but didn't have
time to wire it up yet.
Another improvement (beyond finding a decent heuristic based on the
artifacts 'authorship', 'signed-off-by', 'reviewed-by', 'acked-by',
'committer' and nr-of-lines-changed.. and maybe time) is probably to
not make an arbitrarily 1-Year-Back cut-off, but to check the last N
commits on that region of the tree. (I'm thinking of the more
"settled down" areas of the tree here)
But let's see what I come up with...
Regards,
Flo
next prev parent reply other threads:[~2010-09-27 17:00 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 9:33 [PATCH] get_maintainer.pl: append reason for cc to the name by default florian
2010-09-10 9:42 ` Joe Perches
2010-09-10 9:46 ` Wolfram Sang
2010-09-10 9:53 ` Mark Brown
2010-09-10 10:04 ` Joe Perches
2010-09-10 10:18 ` Mark Brown
2010-09-10 10:47 ` Joe Perches
2010-09-10 11:07 ` Mark Brown
2010-09-11 0:22 ` [PATCH] scripts/get_maintainer.pl: Add --git-blame --rolestats "Authored lines" information Joe Perches
2010-09-11 9:38 ` Florian Mickler
2010-09-11 9:52 ` Joe Perches
2010-09-11 10:02 ` Florian Mickler
2010-09-11 10:22 ` Joe Perches
2010-09-11 19:22 ` [PATCH] Documentation/SubmittingPatches: Add and describe scripts/get_maintainer.pl Joe Perches
2010-09-11 19:34 ` Florian Mickler
2010-09-11 19:43 ` [PATCH V2] " Joe Perches
2010-09-12 16:18 ` Florian Mickler
2010-09-10 11:44 ` [PATCH] get_maintainer.pl: append reason for cc to the name by default Alan Cox
2010-09-10 10:22 ` Florian Mickler
2010-09-10 10:47 ` Joe Perches
2010-09-11 21:22 ` Joe Perches
2010-09-10 10:30 ` Florian Mickler
2010-09-10 11:04 ` Mark Brown
2010-09-10 11:15 ` Florian Mickler
2010-09-10 21:04 ` Andrew Morton
2010-09-10 21:39 ` Florian Mickler
2010-09-10 21:44 ` Joe Perches
2010-09-13 4:01 ` Valdis.Kletnieks
2010-09-13 5:21 ` [PATCH] get_maintainer.pl: Look for .get_maintainer.conf in lk, then $HOME then scripts Joe Perches
2010-09-13 6:13 ` Florian Mickler
2010-09-13 13:21 ` Valdis.Kletnieks
2010-09-10 11:11 ` [PATCH] get_maintainer.pl: append reason for cc to the name by default Florian Mickler
2010-09-10 15:12 ` Joe Perches
2010-09-11 9:34 ` Florian Mickler
2010-09-11 0:13 ` Christoph Hellwig
2010-09-11 0:31 ` Joe Perches
2010-09-11 0:45 ` Christoph Hellwig
2010-09-11 0:56 ` Joe Perches
2010-09-11 9:28 ` Florian Mickler
2010-09-13 7:16 ` Eric W. Biederman
2010-09-13 7:57 ` Joe Perches
2010-09-13 8:54 ` Florian Mickler
2010-09-14 17:19 ` Eric W. Biederman
2010-09-14 17:46 ` Florian Mickler
2010-09-15 3:28 ` Joe Perches
2010-09-15 4:34 ` Florian Mickler
2010-09-15 4:45 ` Joe Perches
2010-09-15 12:49 ` Florian Mickler
2010-09-14 23:15 ` Joe Perches
2010-09-13 9:01 ` Florian Mickler
2010-09-14 17:24 ` Eric W. Biederman
2010-09-26 18:52 ` RFC: " Joe Perches
2010-09-27 14:57 ` Florian Mickler
2010-09-27 15:44 ` Ted Ts'o
2010-09-27 17:00 ` Florian Mickler [this message]
2010-09-27 18:21 ` Ted Ts'o
2010-09-27 19:26 ` Florian Mickler
2010-09-27 20:08 ` Joe Perches
2010-09-27 20:47 ` Ted Ts'o
2010-09-27 21:16 ` Joe Perches
2010-09-28 4:22 ` Ted Ts'o
2010-09-28 4:37 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100927190026.20ddc268@schatten.dmk.lab \
--to=florian@mickler.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=tytso@mit.edu \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).