* [PATCH] misc: phantom: Added missing warning messages in phantom_probe
@ 2010-09-25 13:48 Rahul Ruikar
2010-09-25 14:15 ` Rahul Ruikar
2010-09-26 9:26 ` Jiri Slaby
0 siblings, 2 replies; 6+ messages in thread
From: Rahul Ruikar @ 2010-09-25 13:48 UTC (permalink / raw)
To: jirislaby; +Cc: ak, adobriyan, akpm, linux-kernel, Rahul Ruikar
phantom_probe can fail at many places. missing warning messages
have been added for 2 cases.
pci_enable_device()
pci_request_regions()
Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
---
drivers/misc/phantom.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c
index 75ee0d3..b4c105f 100644
--- a/drivers/misc/phantom.c
+++ b/drivers/misc/phantom.c
@@ -341,8 +341,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
int retval;
retval = pci_enable_device(pdev);
- if (retval)
+ if (retval) {
+ dev_err(&pdev->dev, "pci_enable_device failed!\n");
goto err;
+ }
minor = phantom_get_free();
if (minor == PHANTOM_MAX_MINORS) {
@@ -354,8 +356,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
phantom_devices[minor] = 1;
retval = pci_request_regions(pdev, "phantom");
- if (retval)
+ if (retval) {
+ dev_err(&pdev->dev, "pci_request_regions failed!\n");
goto err_null;
+ }
retval = -ENOMEM;
pht = kzalloc(sizeof(*pht), GFP_KERNEL);
--
1.7.2.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] misc: phantom: Added missing warning messages in phantom_probe
2010-09-25 13:48 [PATCH] misc: phantom: Added missing warning messages in phantom_probe Rahul Ruikar
@ 2010-09-25 14:15 ` Rahul Ruikar
2010-09-25 15:04 ` Greg KH
2010-09-26 9:26 ` Jiri Slaby
1 sibling, 1 reply; 6+ messages in thread
From: Rahul Ruikar @ 2010-09-25 14:15 UTC (permalink / raw)
To: jirislaby; +Cc: ak, adobriyan, akpm, linux-kernel, Rahul Ruikar, gregkh
missed greg in earlier mail.
- Rahul Ruikar
On 25 September 2010 19:18, Rahul Ruikar <rahul.ruikar@gmail.com> wrote:
> phantom_probe can fail at many places. missing warning messages
> have been added for 2 cases.
> pci_enable_device()
> pci_request_regions()
>
> Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
> ---
> drivers/misc/phantom.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c
> index 75ee0d3..b4c105f 100644
> --- a/drivers/misc/phantom.c
> +++ b/drivers/misc/phantom.c
> @@ -341,8 +341,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
> int retval;
>
> retval = pci_enable_device(pdev);
> - if (retval)
> + if (retval) {
> + dev_err(&pdev->dev, "pci_enable_device failed!\n");
> goto err;
> + }
>
> minor = phantom_get_free();
> if (minor == PHANTOM_MAX_MINORS) {
> @@ -354,8 +356,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
> phantom_devices[minor] = 1;
>
> retval = pci_request_regions(pdev, "phantom");
> - if (retval)
> + if (retval) {
> + dev_err(&pdev->dev, "pci_request_regions failed!\n");
> goto err_null;
> + }
>
> retval = -ENOMEM;
> pht = kzalloc(sizeof(*pht), GFP_KERNEL);
> --
> 1.7.2.3
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] misc: phantom: Added missing warning messages in phantom_probe
2010-09-25 14:15 ` Rahul Ruikar
@ 2010-09-25 15:04 ` Greg KH
2010-09-25 17:27 ` Rahul Ruikar
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2010-09-25 15:04 UTC (permalink / raw)
To: Rahul Ruikar; +Cc: jirislaby, ak, adobriyan, akpm, linux-kernel
On Sat, Sep 25, 2010 at 07:45:10PM +0530, Rahul Ruikar wrote:
> missed greg in earlier mail.
Ok, but why? Is drivers/misc/phantom.c my code?
confused,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc: phantom: Added missing warning messages in phantom_probe
2010-09-25 15:04 ` Greg KH
@ 2010-09-25 17:27 ` Rahul Ruikar
2010-09-25 17:34 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Rahul Ruikar @ 2010-09-25 17:27 UTC (permalink / raw)
To: Greg KH; +Cc: jirislaby, ak, adobriyan, akpm, linux-kernel
Greg,
Actually before sending patch I run get_maintainer.pl script against
this patch and it gave me all following names..
that was reason i added you in maill.
[rahul@Ganesha linux-2.6]$ ./scripts/get_maintainer.pl
0001-misc-phantom-Added-missing-warning-messages-in-phant.patch
Jiri Slaby <jirislaby@gmail.com>
Andi Kleen <ak@linux.intel.com>
Alexey Dobriyan <adobriyan@gmail.com>
Greg Kroah-Hartman <gregkh@suse.de>
Andrew Morton <akpm@linux-foundation.org>
Rahul Ruikar <rahul.ruikar@gmail.com>
linux-kernel@vger.kernel.org
- Rahul Ruikar
On 25 September 2010 20:34, Greg KH <gregkh@suse.de> wrote:
> On Sat, Sep 25, 2010 at 07:45:10PM +0530, Rahul Ruikar wrote:
>> missed greg in earlier mail.
>
> Ok, but why? Is drivers/misc/phantom.c my code?
>
> confused,
>
> greg k-h
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc: phantom: Added missing warning messages in phantom_probe
2010-09-25 17:27 ` Rahul Ruikar
@ 2010-09-25 17:34 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2010-09-25 17:34 UTC (permalink / raw)
To: Rahul Ruikar; +Cc: jirislaby, ak, adobriyan, akpm, linux-kernel
On Sat, Sep 25, 2010 at 10:57:08PM +0530, Rahul Ruikar wrote:
> Greg,
>
> Actually before sending patch I run get_maintainer.pl script against
> this patch and it gave me all following names..
> that was reason i added you in maill.
>
> [rahul@Ganesha linux-2.6]$ ./scripts/get_maintainer.pl
> 0001-misc-phantom-Added-missing-warning-messages-in-phant.patch
> Jiri Slaby <jirislaby@gmail.com>
> Andi Kleen <ak@linux.intel.com>
> Alexey Dobriyan <adobriyan@gmail.com>
> Greg Kroah-Hartman <gregkh@suse.de>
> Andrew Morton <akpm@linux-foundation.org>
> Rahul Ruikar <rahul.ruikar@gmail.com>
> linux-kernel@vger.kernel.org
Ah, ok, that makes more sense, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc: phantom: Added missing warning messages in phantom_probe
2010-09-25 13:48 [PATCH] misc: phantom: Added missing warning messages in phantom_probe Rahul Ruikar
2010-09-25 14:15 ` Rahul Ruikar
@ 2010-09-26 9:26 ` Jiri Slaby
1 sibling, 0 replies; 6+ messages in thread
From: Jiri Slaby @ 2010-09-26 9:26 UTC (permalink / raw)
To: Rahul Ruikar; +Cc: ak, adobriyan, akpm, linux-kernel
On 09/25/2010 04:48 PM, Rahul Ruikar wrote:
> phantom_probe can fail at many places. missing warning messages
> have been added for 2 cases.
> pci_enable_device()
> pci_request_regions()
>
> Signed-off-by: Rahul Ruikar <rahul.ruikar@gmail.com>
Acked-by: Jiri Slaby <jirislaby@gmail.com>
Andrew, could you take it?
> ---
> drivers/misc/phantom.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/phantom.c b/drivers/misc/phantom.c
> index 75ee0d3..b4c105f 100644
> --- a/drivers/misc/phantom.c
> +++ b/drivers/misc/phantom.c
> @@ -341,8 +341,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
> int retval;
>
> retval = pci_enable_device(pdev);
> - if (retval)
> + if (retval) {
> + dev_err(&pdev->dev, "pci_enable_device failed!\n");
> goto err;
> + }
>
> minor = phantom_get_free();
> if (minor == PHANTOM_MAX_MINORS) {
> @@ -354,8 +356,10 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
> phantom_devices[minor] = 1;
>
> retval = pci_request_regions(pdev, "phantom");
> - if (retval)
> + if (retval) {
> + dev_err(&pdev->dev, "pci_request_regions failed!\n");
> goto err_null;
> + }
>
> retval = -ENOMEM;
> pht = kzalloc(sizeof(*pht), GFP_KERNEL);
thanks,
--
js
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-09-26 9:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-09-25 13:48 [PATCH] misc: phantom: Added missing warning messages in phantom_probe Rahul Ruikar
2010-09-25 14:15 ` Rahul Ruikar
2010-09-25 15:04 ` Greg KH
2010-09-25 17:27 ` Rahul Ruikar
2010-09-25 17:34 ` Greg KH
2010-09-26 9:26 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).