From: Andrew Morton <akpm@linux-foundation.org>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, Greg KH <greg@kroah.com>
Subject: Re: [PATCH] support polling of /proc/swaps
Date: Tue, 19 Oct 2010 15:31:36 -0700 [thread overview]
Message-ID: <20101019153136.b2543f7b.akpm@linux-foundation.org> (raw)
In-Reply-To: <1287479956.1729.1.camel@yio.site>
On Tue, 19 Oct 2010 11:19:16 +0200
Kay Sievers <kay.sievers@vrfy.org> wrote:
> From: Kay Sievers <kay.sievers@vrfy.org>
> Subject: support polling of /proc/swaps
>
> System management wants to subscribe to changes in swap
> configuration. Make /proc/swaps pollable like /proc/mounts.
>
It's a bit sad that we have to add quite a pile of infrastructure to
make a procfs file pollable. I wonder if it's possible to provide some
core support for this, and reduce the amount of code at each particular
handler site.
Also, I wonder how we are to communicate the existence of this feature
to our users. Nobody will look in Documentation/filesystems/. Is
there a manpage? Seems not...
> ---
> mm/swapfile.c | 48 +++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 47 insertions(+), 1 deletion(-)
>
> --- a/mm/swapfile.c
> +++ b/mm/swapfile.c
> @@ -30,6 +30,7 @@
> #include <linux/capability.h>
> #include <linux/syscalls.h>
> #include <linux/memcontrol.h>
> +#include <linux/poll.h>
>
> #include <asm/pgtable.h>
> #include <asm/tlbflush.h>
> @@ -58,6 +59,9 @@ static struct swap_info_struct *swap_inf
>
> static DEFINE_MUTEX(swapon_mutex);
>
> +static DECLARE_WAIT_QUEUE_HEAD(proc_poll_wait);
> +static int proc_poll_event;
Please pick a lock to protect proc_poll_event. Then document that
locking here, when you also document proc_poll_event ;)
> static inline unsigned char swap_count(unsigned char ent)
> {
> return ent & ~SWAP_HAS_CACHE; /* may include SWAP_HAS_CONT flag */
> @@ -1680,6 +1684,8 @@ SYSCALL_DEFINE1(swapoff, const char __us
> }
> filp_close(swap_file, NULL);
> err = 0;
> + proc_poll_event++;
Then fix this race.
> + wake_up_interruptible(&proc_poll_wait);
>
> out_dput:
> filp_close(victim, NULL);
next prev parent reply other threads:[~2010-10-19 22:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-19 9:19 [PATCH] support polling of /proc/swaps Kay Sievers
2010-10-19 11:09 ` Peter Zijlstra
2010-10-19 16:11 ` Jonathan Corbet
2010-10-19 18:54 ` Kay Sievers
2010-10-19 22:31 ` Andrew Morton [this message]
2010-10-19 23:25 ` Kay Sievers
2010-10-19 23:38 ` Andrew Morton
2010-11-15 3:44 ` Neil Brown
2010-11-16 15:56 ` Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101019153136.b2543f7b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).