Re: [PATCH] support polling of /proc/swaps

[Kay Sievers <kay.sievers@vrfy.org>]

On Tue, Oct 19, 2010 at 18:11, Jonathan Corbet <corbet@lwn.net> wrote:
> Here we have this:
>
>> +static unsigned swaps_poll(struct file *file, poll_table *wait)
>> +{
>> +     struct proc_swaps *s = file->private_data;
>
> But here I see:
>
>>  static int swaps_open(struct inode *inode, struct file *file)
>>  {
>> -     return seq_open(file, &swaps_op);
>> +     struct proc_swaps *s;
>> +     int ret;
>> +
>> +     s = kmalloc(sizeof(struct proc_swaps), GFP_KERNEL);
>> +     if (!s)
>> +             return -ENOMEM;
>> +
>> +     file->private_data = &s->seq;
>
> It sure looks to me like private_data is a struct seq_file pointer, not a
> struct proc_swaps pointer.  What am I missing?

Right, that looks weird. It's the same pointer though, because it's
the first element. I'll correct that.

Thanks a lot for the sharp eyes,
Kay