* [PATCH] Drivers: edac: Makfile: Cleaned up Makefile
@ 2010-11-06 19:05 Tracey Dent
2010-11-07 10:29 ` Borislav Petkov
0 siblings, 1 reply; 5+ messages in thread
From: Tracey Dent @ 2010-11-06 19:05 UTC (permalink / raw)
To: mchehab; +Cc: linux-kernel, borislav.petkov, Tracey Dent
Changed Makefile to use <modules>-y instead of <modules>-objs.
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
drivers/edac/Makefile | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
index b378139..9b53eda 100644
--- a/drivers/edac/Makefile
+++ b/drivers/edac/Makefile
@@ -10,16 +10,16 @@ obj-$(CONFIG_EDAC) := edac_stub.o
obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
obj-$(CONFIG_EDAC_MCE) += edac_mce.o
-edac_core-objs := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
-edac_core-objs += edac_module.o edac_device_sysfs.o
+edac_core-y := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
+edac_core-y += edac_module.o edac_device_sysfs.o
ifdef CONFIG_PCI
-edac_core-objs += edac_pci.o edac_pci_sysfs.o
+edac_core-y += edac_pci.o edac_pci_sysfs.o
endif
obj-$(CONFIG_EDAC_MCE_INJ) += mce_amd_inj.o
-edac_mce_amd-objs := mce_amd.o
+edac_mce_amd-y := mce_amd.o
obj-$(CONFIG_EDAC_DECODE_MCE) += edac_mce_amd.o
obj-$(CONFIG_EDAC_AMD76X) += amd76x_edac.o
--
1.7.3.1.104.gc752e
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Drivers: edac: Makfile: Cleaned up Makefile
2010-11-06 19:05 [PATCH] Drivers: edac: Makfile: Cleaned up Makefile Tracey Dent
@ 2010-11-07 10:29 ` Borislav Petkov
0 siblings, 0 replies; 5+ messages in thread
From: Borislav Petkov @ 2010-11-07 10:29 UTC (permalink / raw)
To: Tracey Dent; +Cc: mchehab, linux-kernel
On Sat, Nov 06, 2010 at 03:05:07PM -0400, Tracey Dent wrote:
> Changed Makefile to use <modules>-y instead of <modules>-objs.
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
While I don't object the change, I think your commit message should be
fixed not to say _what_ your patch changes (we can see that) but to say
_why_ you're making that change. See, I had to go search lkml just to
find why all of a sudden <..>-objs is being changed.
So please go and add text explaining that -objs is deprecated and so on.
And make sure you've checked out Documentation/SubmittingPatches - it'll
save you a lot of trouble in the future :).
Thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Drivers: edac: Makfile: Cleaned up Makefile
2010-11-11 14:09 ` Borislav Petkov
@ 2010-11-11 15:47 ` Tracey Dent
0 siblings, 0 replies; 5+ messages in thread
From: Tracey Dent @ 2010-11-11 15:47 UTC (permalink / raw)
To: Borislav Petkov; +Cc: mchehab, linux-kernel
On 11/11/10, Borislav Petkov <bp@amd64.org> wrote:
> On Sun, Nov 07, 2010 at 09:43:33AM -0500, Tracey Dent wrote:
>> Changed Makefile to use <modules>-y instead of <modules>-objs because
>> -objs is
>> deprecated and should now be switched. According to
>> (documentation/kbuild/makefiles.txt).
>>
>> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
>
> Applied, thanks.
>
thanks
td
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Drivers: edac: Makfile: Cleaned up Makefile
2010-11-07 14:43 Tracey Dent
@ 2010-11-11 14:09 ` Borislav Petkov
2010-11-11 15:47 ` Tracey Dent
0 siblings, 1 reply; 5+ messages in thread
From: Borislav Petkov @ 2010-11-11 14:09 UTC (permalink / raw)
To: Tracey Dent; +Cc: mchehab, linux-kernel
On Sun, Nov 07, 2010 at 09:43:33AM -0500, Tracey Dent wrote:
> Changed Makefile to use <modules>-y instead of <modules>-objs because -objs is
> deprecated and should now be switched. According to (documentation/kbuild/makefiles.txt).
>
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>
Applied, thanks.
--
Regards/Gruss,
Boris.
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Drivers: edac: Makfile: Cleaned up Makefile
@ 2010-11-07 14:43 Tracey Dent
2010-11-11 14:09 ` Borislav Petkov
0 siblings, 1 reply; 5+ messages in thread
From: Tracey Dent @ 2010-11-07 14:43 UTC (permalink / raw)
To: bp; +Cc: mchehab, linux-kernel, Tracey Dent
Changed Makefile to use <modules>-y instead of <modules>-objs because -objs is
deprecated and should now be switched. According to (documentation/kbuild/makefiles.txt).
Signed-off-by: Tracey Dent <tdent48227@gmail.com>
---
drivers/edac/Makefile | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/edac/Makefile b/drivers/edac/Makefile
index b378139..9b53eda 100644
--- a/drivers/edac/Makefile
+++ b/drivers/edac/Makefile
@@ -10,16 +10,16 @@ obj-$(CONFIG_EDAC) := edac_stub.o
obj-$(CONFIG_EDAC_MM_EDAC) += edac_core.o
obj-$(CONFIG_EDAC_MCE) += edac_mce.o
-edac_core-objs := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
-edac_core-objs += edac_module.o edac_device_sysfs.o
+edac_core-y := edac_mc.o edac_device.o edac_mc_sysfs.o edac_pci_sysfs.o
+edac_core-y += edac_module.o edac_device_sysfs.o
ifdef CONFIG_PCI
-edac_core-objs += edac_pci.o edac_pci_sysfs.o
+edac_core-y += edac_pci.o edac_pci_sysfs.o
endif
obj-$(CONFIG_EDAC_MCE_INJ) += mce_amd_inj.o
-edac_mce_amd-objs := mce_amd.o
+edac_mce_amd-y := mce_amd.o
obj-$(CONFIG_EDAC_DECODE_MCE) += edac_mce_amd.o
obj-$(CONFIG_EDAC_AMD76X) += amd76x_edac.o
--
1.7.3.1.104.gc752e
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-11-11 15:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-06 19:05 [PATCH] Drivers: edac: Makfile: Cleaned up Makefile Tracey Dent
2010-11-07 10:29 ` Borislav Petkov
2010-11-07 14:43 Tracey Dent
2010-11-11 14:09 ` Borislav Petkov
2010-11-11 15:47 ` Tracey Dent
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).