linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Stefan Achatz <stefan_achatz@web.de>
Cc: "Eric W. Biederman" <ebiederm@aristanetworks.com>,
	"Serge E. Hallyn" <serue@us.ibm.com>, Tejun Heo <tj@kernel.org>,
	Jiri Kosina <jkosina@suse.cz>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Benjamin Thery <benjamin.thery@bull.net>
Subject: Re: [PATCH 1/2] sysfs: Introducing sysfs_create_bin_group()
Date: Fri, 12 Nov 2010 11:29:58 -0800	[thread overview]
Message-ID: <20101112192958.GA22233@suse.de> (raw)
In-Reply-To: <1289585918.2629.12.camel@neuromancer>

On Fri, Nov 12, 2010 at 07:18:38PM +0100, Stefan Achatz wrote:
> Implemented group functions for easier creation of multiple binary sysfs
> attributes similar to existing attribute_group handling functions.
> The code reuses struct attribute_group instead of inventing a new struct
> binary_attribute_group.
> 
> Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>

Looks good to me, nice job.

Dmitry, do you want to take this through your tree as the mouse driver
change needs it?  If so, feel free to do so and add a:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>

to the patch.

If not, I'll be glad to take it, and the mouse driver change through my
tree if needed.

Just let me know which is easier for you.

thanks,

greg k-h

  parent reply	other threads:[~2010-11-12 19:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-12 18:18 [PATCH 1/2] sysfs: Introducing sysfs_create_bin_group() Stefan Achatz
2010-11-12 18:57 ` Dmitry Torokhov
2010-11-12 19:29 ` Greg KH [this message]
2010-11-12 19:38   ` Dmitry Torokhov
2010-11-12 19:50     ` Greg KH
2010-11-12 20:02       ` Dmitry Torokhov
2010-11-15 13:49         ` Jiri Kosina
2010-11-15 13:51           ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101112192958.GA22233@suse.de \
    --to=gregkh@suse.de \
    --cc=benjamin.thery@bull.net \
    --cc=dmitry.torokhov@gmail.com \
    --cc=ebiederm@aristanetworks.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serue@us.ibm.com \
    --cc=stefan_achatz@web.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).