Re: [PATCH 1/2] sysfs: Introducing sysfs_create_bin_group()

[Jiri Kosina <jkosina@suse.cz>]

On Fri, 12 Nov 2010, Dmitry Torokhov wrote:

> > > > > Implemented group functions for easier creation of multiple binary sysfs
> > > > > attributes similar to existing attribute_group handling functions.
> > > > > The code reuses struct attribute_group instead of inventing a new struct
> > > > > binary_attribute_group.
> > > > > 
> > > > > Signed-off-by: Stefan Achatz <erazor_de@users.sourceforge.net>
> > > > 
> > > > Looks good to me, nice job.
> > > > 
> > > > Dmitry, do you want to take this through your tree as the mouse driver
> > > > change needs it?  If so, feel free to do so and add a:
> > > > 	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> > > > 
> > > > to the patch.
> > > > 
> > > > If not, I'll be glad to take it, and the mouse driver change through my
> > > > tree if needed.
> > > > 
> > > > Just let me know which is easier for you.
> > > > 
> > > 
> > > Actually the driver lives in hid so it's up to Jiri how he wants to
> > > handle this.
> > 
> > Ah.  He's on vacation for a few weeks so I guess I'll take this for now.
> > 
> 
> Those Europeans with their long vacations, geeze... Well, I hope he's
> having fun ;)

Oh definitely. We haven't expected snow and ice already being there in 
White Mountain :) Quite a fun.

sysfs_create_bin_group() definitely looks like an improvement. I'd like to 
take it together with the Roccat driver patch, as it depends on it. Greg 
-- would you mind me taking it through my tree with your signoff?

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.