From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Atul Sowani <sowani@gmail.com>
Cc: linux-kernel@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
ralf@linux-mips.org, linux-arm-kernel@lists.infradead.org,
alan@linux.intel.com
Subject: Re: [PATCH 2.6.36 1/1 RESEND] kernel SPIN_LOCK_UNLOCKED changed to __SPIN_LOCK_UNLOCKED()
Date: Mon, 15 Nov 2010 09:54:25 +0100 [thread overview]
Message-ID: <20101115085425.GA8942@pengutronix.de> (raw)
In-Reply-To: <4CDED96A.9080404@gmail.com>
Hi Atul,
On Sun, Nov 14, 2010 at 12:01:06AM +0530, Atul Sowani wrote:
> There are still some files containing .lock = SPIN_LOCK_UNLOCKED type
> assignments which should be converted to __SPIN_LOCK_UNLOCKED().
> Corrected spacing between __SPIN_LOCK_UNLOCKED and ( for ARM.
IMHO the last sentence shouldn't appear in the commit log. (If you
still want to let your readers know what you changed---generally a good
idea---you can do so after the triple-dash below.)
I don't know you patch series, but I'd expect that all archs don't want
the space between __SPIN_LOCK_UNLOCKED and (.
Other than that
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
>
> Signed-off-by: Atul Sowani <sowani@gmail.com>
> ---
>
> diff -uprN a/arch/arm/kernel/smp.c b/arch/arm/kernel/smp.c
> --- a/arch/arm/kernel/smp.c 2010-10-21 02:00:22.000000000 +0530
> +++ b/arch/arm/kernel/smp.c 2010-11-07 00:47:32.000000000 +0530
> @@ -56,7 +56,7 @@ struct ipi_data {
> };
>
> static DEFINE_PER_CPU(struct ipi_data, ipi_data) = {
> - .lock = SPIN_LOCK_UNLOCKED,
> + .lock = __SPIN_LOCK_UNLOCKED(ipi_data.lock),
> };
>
> enum ipi_msg_type {
> diff -uprN a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
> --- a/arch/mips/kernel/vpe.c 2010-10-21 02:00:22.000000000 +0530
> +++ b/arch/mips/kernel/vpe.c 2010-11-07 00:51:37.000000000 +0530
> @@ -148,9 +148,9 @@ struct {
> spinlock_t tc_list_lock;
> struct list_head tc_list; /* Thread contexts */
> } vpecontrol = {
> - .vpe_list_lock = SPIN_LOCK_UNLOCKED,
> + .vpe_list_lock = __SPIN_LOCK_UNLOCKED(vpecontrol.vpe_list_lock),
> .vpe_list = LIST_HEAD_INIT(vpecontrol.vpe_list),
> - .tc_list_lock = SPIN_LOCK_UNLOCKED,
> + .tc_list_lock = __SPIN_LOCK_UNLOCKED(vpecontrol.tc_list_lock),
> .tc_list = LIST_HEAD_INIT(vpecontrol.tc_list)
> };
> diff -uprN a/kernel/cred.c b/kernel/cred.c
> --- a/kernel/cred.c 2010-10-21 02:00:22.000000000 +0530
> +++ b/kernel/cred.c 2010-11-07 00:52:22.000000000 +0530
> @@ -35,7 +35,7 @@ static struct kmem_cache *cred_jar;
> static struct thread_group_cred init_tgcred = {
> .usage = ATOMIC_INIT(2),
> .tgid = 0,
> - .lock = SPIN_LOCK_UNLOCKED,
> + .lock = __SPIN_LOCK_UNLOCKED(init_tgcred.lock),
> };
> #endif
>
> --
> Atul Sowani (sowani@gmail.com)
> http://savannah.gnu.org/users/atul
> ------------------------------------------------------------------------
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2010-11-15 8:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-13 18:31 [PATCH 2.6.36 1/1 RESEND] kernel SPIN_LOCK_UNLOCKED changed to __SPIN_LOCK_UNLOCKED() Atul Sowani
2010-11-15 8:54 ` Uwe Kleine-König [this message]
2010-11-15 9:24 ` Russell King - ARM Linux
2010-11-15 9:44 ` Arnd Bergmann
2010-11-15 10:06 ` Russell King - ARM Linux
2010-11-15 14:46 Atul Sowani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115085425.GA8942@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alan@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=sowani@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).