From: Atul Sowani <sowani@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: alan@linux.intel.com, ralf@linux-mips.org,
u.kleine-koenig@pengutronix.de, linux@arm.linux.org.uk
Subject: Re: [PATCH 2.6.36 1/1 RESEND] kernel SPIN_LOCK_UNLOCKED changed to __SPIN_LOCK_UNLOCKED()
Date: Mon, 15 Nov 2010 20:16:06 +0530 [thread overview]
Message-ID: <4CE147AE.2030102@gmail.com> (raw)
There are still some files containing .lock = SPIN_LOCK_UNLOCKED type
assignments which should be converted to __SPIN_LOCK_UNLOCKED().
--- Corrected spacing between __SPIN_LOCK_UNLOCKED and ( for ARM.
--- Resubmitting the patch with spacing fixes.
--- Removed ARM related changes after Russell King's NACK.
Signed-off-by: Atul Sowani <sowani@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
diff -uprN a/arch/mips/kernel/vpe.c b/arch/mips/kernel/vpe.c
--- a/arch/mips/kernel/vpe.c 2010-10-21 02:00:22.000000000 +0530
+++ b/arch/mips/kernel/vpe.c 2010-11-07 00:51:37.000000000 +0530
@@ -148,9 +148,9 @@ struct {
spinlock_t tc_list_lock;
struct list_head tc_list; /* Thread contexts */
} vpecontrol = {
- .vpe_list_lock = SPIN_LOCK_UNLOCKED,
+ .vpe_list_lock = __SPIN_LOCK_UNLOCKED(vpecontrol.vpe_list_lock),
.vpe_list = LIST_HEAD_INIT(vpecontrol.vpe_list),
- .tc_list_lock = SPIN_LOCK_UNLOCKED,
+ .tc_list_lock = __SPIN_LOCK_UNLOCKED(vpecontrol.tc_list_lock),
.tc_list = LIST_HEAD_INIT(vpecontrol.tc_list)
};
diff -uprN a/kernel/cred.c b/kernel/cred.c
--- a/kernel/cred.c 2010-10-21 02:00:22.000000000 +0530
+++ b/kernel/cred.c 2010-11-07 00:52:22.000000000 +0530
@@ -35,7 +35,7 @@ static struct kmem_cache *cred_jar;
static struct thread_group_cred init_tgcred = {
.usage = ATOMIC_INIT(2),
.tgid = 0,
- .lock = SPIN_LOCK_UNLOCKED,
+ .lock = __SPIN_LOCK_UNLOCKED(init_tgcred.lock),
};
#endif
--
Atul Sowani (sowani@gmail.com)
http://savannah.gnu.org/users/atul
------------------------------------------------------------------------
next reply other threads:[~2010-11-15 14:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 14:46 Atul Sowani [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-11-13 18:31 [PATCH 2.6.36 1/1 RESEND] kernel SPIN_LOCK_UNLOCKED changed to __SPIN_LOCK_UNLOCKED() Atul Sowani
2010-11-15 8:54 ` Uwe Kleine-König
2010-11-15 9:24 ` Russell King - ARM Linux
2010-11-15 9:44 ` Arnd Bergmann
2010-11-15 10:06 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CE147AE.2030102@gmail.com \
--to=sowani@gmail.com \
--cc=alan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ralf@linux-mips.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).