linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Eric Cooper <ecc@cmu.edu>
Cc: linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
	Greg KH <greg@kroah.com>
Subject: Re: [PATCH] add netdev led trigger
Date: Wed, 17 Nov 2010 12:05:16 +0100	[thread overview]
Message-ID: <20101117105925.GC1574@ucw.cz> (raw)
In-Reply-To: <1289768305-1224-1-git-send-email-ecc@cmu.edu>

Hi!

> Add a netdev LED trigger for all Blinkenlights lovers...
> Originally taken from https://dev.openwrt.org/ticket/2776
> Slightly updated for 2.6.24 by Mickey Lauer <mickey@openmoko.org>
> and for 2.6.36 by Eric Cooper <ecc@cmu.edu>

Nice!

> +/*
> + * Configurable sysfs attributes:
> + *
> + * device_name - network device name to monitor
> + *
> + * interval - duration of LED blink, in milliseconds

This needs to go to Doc/ somewhere.

> + * mode - either "none" (LED is off) or a space separated list
> + * of one or more of:
> + *   link: LED's normal state reflects whether the link is up (has carrier)
> + *         or not
> + *   tx:   LED blinks on transmitted data
> + *   rx:   LED blinks on receive data
> + *
> + * Some suggestions:
> + *
> + *  Simple link status LED:
> + *  $ echo netdev >someled/trigger
> + *  $ echo eth0 >someled/device_name
> + *  $ echo link >someled/mode
> + *
> + *  Ethernet-style link/activity LED:
> + *  $ echo netdev >someled/trigger
> + *  $ echo eth0 >someled/device_name
> + *  $ echo "link tx rx" >someled/mode

One value per file?

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2010-11-17 11:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 20:58 [PATCH] add netdev led trigger Eric Cooper
2010-11-15 23:41 ` Lars-Peter Clausen
2010-11-17 11:05 ` Pavel Machek [this message]
2010-11-17 16:09   ` Greg KH
2010-11-17 19:58     ` Pavel Machek
2010-11-17 20:01       ` Greg KH
2010-11-17 20:06       ` Eric Cooper
2010-11-30 19:20         ` Pavel Machek
2010-11-30 23:22           ` Eric Cooper
2010-12-01 19:56             ` Pavel Machek
2010-11-21 20:53     ` Eric Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117105925.GC1574@ucw.cz \
    --to=pavel@ucw.cz \
    --cc=ecc@cmu.edu \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).