linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Eric Cooper <ecc@cmu.edu>,
	linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH] add netdev led trigger
Date: Wed, 17 Nov 2010 12:01:00 -0800	[thread overview]
Message-ID: <20101117200100.GA30815@kroah.com> (raw)
In-Reply-To: <20101117195843.GA31357@elf.ucw.cz>

On Wed, Nov 17, 2010 at 08:58:43PM +0100, Pavel Machek wrote:
> Hi!
> 
> > > > Add a netdev LED trigger for all Blinkenlights lovers...
> > > > Originally taken from https://dev.openwrt.org/ticket/2776
> > > > Slightly updated for 2.6.24 by Mickey Lauer <mickey@openmoko.org>
> > > > and for 2.6.36 by Eric Cooper <ecc@cmu.edu>
> > > 
> > > Nice!
> > > 
> > > > +/*
> > > > + * Configurable sysfs attributes:
> > > > + *
> > > > + * device_name - network device name to monitor
> > > > + *
> > > > + * interval - duration of LED blink, in milliseconds
> > > 
> > > This needs to go to Doc/ somewhere.
> > 
> > Documentation/ABI is the correct place for it.
> 
> I was hoping you'd comment on the ABI itself, too. It uses 
> 
> echo "foo bar baz" > file
> 
> to enable/disable specific events to be "displayed". More traditional
> interface would be 
> 
> echo disable > file_foo

Sorry, yes, I missed that.  It would be obvious that the api was
incorrect once it was documented in the correct format :)

thanks,

greg k-h

  reply	other threads:[~2010-11-17 20:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-14 20:58 [PATCH] add netdev led trigger Eric Cooper
2010-11-15 23:41 ` Lars-Peter Clausen
2010-11-17 11:05 ` Pavel Machek
2010-11-17 16:09   ` Greg KH
2010-11-17 19:58     ` Pavel Machek
2010-11-17 20:01       ` Greg KH [this message]
2010-11-17 20:06       ` Eric Cooper
2010-11-30 19:20         ` Pavel Machek
2010-11-30 23:22           ` Eric Cooper
2010-12-01 19:56             ` Pavel Machek
2010-11-21 20:53     ` Eric Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101117200100.GA30815@kroah.com \
    --to=greg@kroah.com \
    --cc=ecc@cmu.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).