* [PATCH 1/2] drivers: regulator: core: use pr_fmt
@ 2010-11-17 23:30 Daniel Walker
2010-11-17 23:30 ` [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros Daniel Walker
` (2 more replies)
0 siblings, 3 replies; 14+ messages in thread
From: Daniel Walker @ 2010-11-17 23:30 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown; +Cc: linux-kernel, Daniel Walker, bleong
This adds a pr_fmt line which uses the __func__ macro. I also
convert the current pr_ lines to remove their __func__ usage.
Cc: bleong@codeaurora.org
Signed-off-by: Daniel Walker <dwalker@codeaurora.org>
---
drivers/regulator/core.c | 22 ++++++++++++----------
1 files changed, 12 insertions(+), 10 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index f1d10c9..a3ca3d6 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -13,6 +13,8 @@
*
*/
+#define pr_fmt(fmt) "%s:" fmt, __func__
+
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/device.h>
@@ -765,8 +767,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
/* else require explicit machine-level constraints */
if (cmin <= 0 || cmax <= 0 || cmax < cmin) {
- pr_err("%s: %s '%s' voltage constraints\n",
- __func__, "invalid", name);
+ pr_err("%s '%s' voltage constraints\n", "invalid",
+ name);
return -EINVAL;
}
@@ -787,22 +789,22 @@ static int machine_constraints_voltage(struct regulator_dev *rdev,
/* final: [min_uV..max_uV] valid iff constraints valid */
if (max_uV < min_uV) {
- pr_err("%s: %s '%s' voltage constraints\n",
- __func__, "unsupportable", name);
+ pr_err("%s '%s' voltage constraints\n", "unsupportable",
+ name);
return -EINVAL;
}
/* use regulator's subset of machine constraints */
if (constraints->min_uV < min_uV) {
- pr_debug("%s: override '%s' %s, %d -> %d\n",
- __func__, name, "min_uV",
- constraints->min_uV, min_uV);
+ pr_debug("override '%s' %s, %d -> %d\n",
+ name, "min_uV",
+ constraints->min_uV, min_uV);
constraints->min_uV = min_uV;
}
if (constraints->max_uV > max_uV) {
- pr_debug("%s: override '%s' %s, %d -> %d\n",
- __func__, name, "max_uV",
- constraints->max_uV, max_uV);
+ pr_debug("override '%s' %s, %d -> %d\n",
+ name, "max_uV",
+ constraints->max_uV, max_uV);
constraints->max_uV = max_uV;
}
}
--
1.7.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros 2010-11-17 23:30 [PATCH 1/2] drivers: regulator: core: use pr_fmt Daniel Walker @ 2010-11-17 23:30 ` Daniel Walker 2010-11-18 0:36 ` Joe Perches 2010-11-18 0:29 ` [PATCH 1/2] drivers: regulator: core: use pr_fmt Joe Perches 2010-11-18 10:35 ` Mark Brown 2 siblings, 1 reply; 14+ messages in thread From: Daniel Walker @ 2010-11-17 23:30 UTC (permalink / raw) To: Liam Girdwood, Mark Brown; +Cc: linux-kernel, Daniel Walker, bleong The regulator framework uses a lot of printks with a specific formatting using __func__. This converts them to use pr_ calls with a central format string. Cc: bleong@codeaurora.org Signed-off-by: Daniel Walker <dwalker@codeaurora.org> --- drivers/regulator/core.c | 131 +++++++++++++++++++--------------------------- 1 files changed, 54 insertions(+), 77 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index a3ca3d6..67cae17 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -13,7 +13,7 @@ * */ -#define pr_fmt(fmt) "%s:" fmt, __func__ +#define pr_fmt(fmt) "%s: " fmt, __func__ #include <linux/kernel.h> #include <linux/init.h> @@ -113,13 +113,11 @@ static int regulator_check_voltage(struct regulator_dev *rdev, BUG_ON(*min_uV > *max_uV); if (!rdev->constraints) { - printk(KERN_ERR "%s: no constraints for %s\n", __func__, - rdev_get_name(rdev)); + pr_err("no constraints for %s\n", rdev_get_name(rdev)); return -ENODEV; } if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE)) { - printk(KERN_ERR "%s: operation not allowed for %s\n", - __func__, rdev_get_name(rdev)); + pr_err("operation not allowed for %s\n", rdev_get_name(rdev)); return -EPERM; } @@ -141,13 +139,11 @@ static int regulator_check_current_limit(struct regulator_dev *rdev, BUG_ON(*min_uA > *max_uA); if (!rdev->constraints) { - printk(KERN_ERR "%s: no constraints for %s\n", __func__, - rdev_get_name(rdev)); + pr_err("no constraints for %s\n", rdev_get_name(rdev)); return -ENODEV; } if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_CURRENT)) { - printk(KERN_ERR "%s: operation not allowed for %s\n", - __func__, rdev_get_name(rdev)); + pr_err("operation not allowed for %s\n", rdev_get_name(rdev)); return -EPERM; } @@ -176,18 +172,15 @@ static int regulator_check_mode(struct regulator_dev *rdev, int mode) } if (!rdev->constraints) { - printk(KERN_ERR "%s: no constraints for %s\n", __func__, - rdev_get_name(rdev)); + pr_err("no constraints for %s\n", rdev_get_name(rdev)); return -ENODEV; } if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_MODE)) { - printk(KERN_ERR "%s: operation not allowed for %s\n", - __func__, rdev_get_name(rdev)); + pr_err("operation not allowed for %s\n", rdev_get_name(rdev)); return -EPERM; } if (!(rdev->constraints->valid_modes_mask & mode)) { - printk(KERN_ERR "%s: invalid mode %x for %s\n", - __func__, mode, rdev_get_name(rdev)); + pr_err("invalid mode %x for %s\n", mode, rdev_get_name(rdev)); return -EINVAL; } return 0; @@ -197,13 +190,11 @@ static int regulator_check_mode(struct regulator_dev *rdev, int mode) static int regulator_check_drms(struct regulator_dev *rdev) { if (!rdev->constraints) { - printk(KERN_ERR "%s: no constraints for %s\n", __func__, - rdev_get_name(rdev)); + pr_err("no constraints for %s\n", rdev_get_name(rdev)); return -ENODEV; } if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_DRMS)) { - printk(KERN_ERR "%s: operation not allowed for %s\n", - __func__, rdev_get_name(rdev)); + pr_err("operation not allowed for %s\n", rdev_get_name(rdev)); return -EPERM; } return 0; @@ -600,20 +591,18 @@ static int suspend_set_state(struct regulator_dev *rdev, */ if (!rstate->enabled && !rstate->disabled) { if (can_set_state) - printk(KERN_WARNING "%s: No configuration for %s\n", - __func__, rdev_get_name(rdev)); + pr_warning("No configuration for %s\n", + rdev_get_name(rdev)); return 0; } if (rstate->enabled && rstate->disabled) { - printk(KERN_ERR "%s: invalid configuration for %s\n", - __func__, rdev_get_name(rdev)); + pr_err("invalid configuration for %s\n", rdev_get_name(rdev)); return -EINVAL; } if (!can_set_state) { - printk(KERN_ERR "%s: no way to set suspend state\n", - __func__); + pr_err("no way to set suspend state\n"); return -EINVAL; } @@ -622,15 +611,14 @@ static int suspend_set_state(struct regulator_dev *rdev, else ret = rdev->desc->ops->set_suspend_disable(rdev); if (ret < 0) { - printk(KERN_ERR "%s: failed to enabled/disable\n", __func__); + pr_err("failed to enabled/disable\n"); return ret; } if (rdev->desc->ops->set_suspend_voltage && rstate->uV > 0) { ret = rdev->desc->ops->set_suspend_voltage(rdev, rstate->uV); if (ret < 0) { - printk(KERN_ERR "%s: failed to set voltage\n", - __func__); + pr_err("failed to set voltage\n"); return ret; } } @@ -638,7 +626,7 @@ static int suspend_set_state(struct regulator_dev *rdev, if (rdev->desc->ops->set_suspend_mode && rstate->mode > 0) { ret = rdev->desc->ops->set_suspend_mode(rdev, rstate->mode); if (ret < 0) { - printk(KERN_ERR "%s: failed to set mode\n", __func__); + pr_err("failed to set mode\n"); return ret; } } @@ -733,9 +721,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, ret = ops->set_voltage(rdev, rdev->constraints->min_uV, rdev->constraints->max_uV); if (ret < 0) { - printk(KERN_ERR "%s: failed to apply %duV constraint to %s\n", - __func__, - rdev->constraints->min_uV, name); + pr_err("failed to apply %duV constraint to %s\n", + rdev->constraints->min_uV, name); rdev->constraints = NULL; return ret; } @@ -842,8 +829,8 @@ static int set_machine_constraints(struct regulator_dev *rdev, if (constraints->initial_state) { ret = suspend_prepare(rdev, constraints->initial_state); if (ret < 0) { - printk(KERN_ERR "%s: failed to set suspend state for %s\n", - __func__, name); + pr_err("failed to set suspend state for %s\n", + name); rdev->constraints = NULL; goto out; } @@ -851,17 +838,16 @@ static int set_machine_constraints(struct regulator_dev *rdev, if (constraints->initial_mode) { if (!ops->set_mode) { - printk(KERN_ERR "%s: no set_mode operation for %s\n", - __func__, name); + pr_err("no set_mode operation for %s\n", + name); ret = -EINVAL; goto out; } ret = ops->set_mode(rdev, constraints->initial_mode); if (ret < 0) { - printk(KERN_ERR - "%s: failed to set initial mode for %s: %d\n", - __func__, name, ret); + pr_err("failed to set initial mode for %s: %d\n", + name, ret); goto out; } } @@ -872,8 +858,7 @@ static int set_machine_constraints(struct regulator_dev *rdev, if ((constraints->always_on || constraints->boot_on) && ops->enable) { ret = ops->enable(rdev); if (ret < 0) { - printk(KERN_ERR "%s: failed to enable %s\n", - __func__, name); + pr_err("failed to enable %s\n", name); rdev->constraints = NULL; goto out; } @@ -901,9 +886,8 @@ static int set_supply(struct regulator_dev *rdev, err = sysfs_create_link(&rdev->dev.kobj, &supply_rdev->dev.kobj, "supply"); if (err) { - printk(KERN_ERR - "%s: could not add device link %s err %d\n", - __func__, supply_rdev->dev.kobj.name, err); + pr_err("could not add device link %s err %d\n", + supply_rdev->dev.kobj.name, err); goto out; } rdev->supply = supply_rdev; @@ -1051,9 +1035,8 @@ static struct regulator *create_regulator(struct regulator_dev *rdev, err = sysfs_create_link(&rdev->dev.kobj, &dev->kobj, buf); if (err) { - printk(KERN_WARNING - "%s: could not add device link %s err %d\n", - __func__, dev->kobj.name, err); + pr_warning("could not add device link %s err %d\n", + dev->kobj.name, err); device_remove_file(dev, ®ulator->dev_attr); goto link_name_err; } @@ -1274,8 +1257,8 @@ static int _regulator_enable(struct regulator_dev *rdev) if (rdev->supply) { ret = _regulator_enable(rdev->supply); if (ret < 0) { - printk(KERN_ERR "%s: failed to enable %s: %d\n", - __func__, rdev_get_name(rdev), ret); + pr_err("failed to enable %s: %d\n", + rdev_get_name(rdev), ret); return ret; } } @@ -1301,10 +1284,9 @@ static int _regulator_enable(struct regulator_dev *rdev) if (ret >= 0) { delay = ret; } else { - printk(KERN_WARNING - "%s: enable_time() failed for %s: %d\n", - __func__, rdev_get_name(rdev), - ret); + pr_warning("enable_time() failed for %s: %d\n", + rdev_get_name(rdev), + ret); delay = 0; } @@ -1321,8 +1303,8 @@ static int _regulator_enable(struct regulator_dev *rdev) udelay(delay); } else if (ret < 0) { - printk(KERN_ERR "%s: is_enabled() failed for %s: %d\n", - __func__, rdev_get_name(rdev), ret); + pr_err("is_enabled() failed for %s: %d\n", + rdev_get_name(rdev), ret); return ret; } /* Fallthrough on positive return values - already enabled */ @@ -1376,8 +1358,8 @@ static int _regulator_disable(struct regulator_dev *rdev, rdev->desc->ops->disable) { ret = rdev->desc->ops->disable(rdev); if (ret < 0) { - printk(KERN_ERR "%s: failed to disable %s\n", - __func__, rdev_get_name(rdev)); + pr_err("failed to disable %s\n", + rdev_get_name(rdev)); return ret; } @@ -1447,8 +1429,8 @@ static int _regulator_force_disable(struct regulator_dev *rdev, /* ah well, who wants to live forever... */ ret = rdev->desc->ops->disable(rdev); if (ret < 0) { - printk(KERN_ERR "%s: failed to force disable %s\n", - __func__, rdev_get_name(rdev)); + pr_err("failed to force disable %s\n", + rdev_get_name(rdev)); return ret; } /* notify other consumers that power has been forced off */ @@ -1878,8 +1860,8 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load) /* get output voltage */ output_uV = rdev->desc->ops->get_voltage(rdev); if (output_uV <= 0) { - printk(KERN_ERR "%s: invalid output voltage found for %s\n", - __func__, rdev_get_name(rdev)); + pr_err("invalid output voltage found for %s\n", + rdev_get_name(rdev)); goto out; } @@ -1889,8 +1871,8 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load) else input_uV = rdev->constraints->input_uV; if (input_uV <= 0) { - printk(KERN_ERR "%s: invalid input voltage found for %s\n", - __func__, rdev_get_name(rdev)); + pr_err("invalid input voltage found for %s\n", + rdev_get_name(rdev)); goto out; } @@ -1903,16 +1885,16 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load) total_uA_load); ret = regulator_check_mode(rdev, mode); if (ret < 0) { - printk(KERN_ERR "%s: failed to get optimum mode for %s @" - " %d uA %d -> %d uV\n", __func__, rdev_get_name(rdev), + pr_err("failed to get optimum mode for %s @" + " %d uA %d -> %d uV\n", rdev_get_name(rdev), total_uA_load, input_uV, output_uV); goto out; } ret = rdev->desc->ops->set_mode(rdev, mode); if (ret < 0) { - printk(KERN_ERR "%s: failed to set optimum mode %x for %s\n", - __func__, mode, rdev_get_name(rdev)); + pr_err("failed to set optimum mode %x for %s\n", + mode, rdev_get_name(rdev)); goto out; } ret = mode; @@ -2459,8 +2441,7 @@ int regulator_suspend_prepare(suspend_state_t state) mutex_unlock(&rdev->mutex); if (ret < 0) { - printk(KERN_ERR "%s: failed to prepare %s\n", - __func__, rdev_get_name(rdev)); + pr_err("failed to prepare %s\n", rdev_get_name(rdev)); goto out; } } @@ -2618,13 +2599,10 @@ static int __init regulator_init_complete(void) if (has_full_constraints) { /* We log since this may kill the system if it * goes wrong. */ - printk(KERN_INFO "%s: disabling %s\n", - __func__, name); + pr_info("disabling %s\n", name); ret = ops->disable(rdev); if (ret != 0) { - printk(KERN_ERR - "%s: couldn't disable %s: %d\n", - __func__, name, ret); + pr_err("couldn't disable %s: %d\n", name, ret); } } else { /* The intention is that in future we will @@ -2632,9 +2610,8 @@ static int __init regulator_init_complete(void) * so warn even if we aren't going to do * anything here. */ - printk(KERN_WARNING - "%s: incomplete constraints, leaving %s on\n", - __func__, name); + pr_warning("incomplete constraints, leaving %s on\n", + name); } unlock: -- 1.7.1 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros 2010-11-17 23:30 ` [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros Daniel Walker @ 2010-11-18 0:36 ` Joe Perches 2010-11-18 1:30 ` Joe Perches 2010-11-18 13:29 ` Mark Brown 0 siblings, 2 replies; 14+ messages in thread From: Joe Perches @ 2010-11-18 0:36 UTC (permalink / raw) To: Daniel Walker; +Cc: Liam Girdwood, Mark Brown, linux-kernel, bleong On Wed, 2010-11-17 at 15:30 -0800, Daniel Walker wrote: > The regulator framework uses a lot of printks with a > specific formatting using __func__. This converts them > to use pr_ calls with a central format string. [] > drivers/regulator/core.c | 131 +++++++++++++++++++--------------------------- > 1 files changed, 54 insertions(+), 77 deletions(-) > > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > index a3ca3d6..67cae17 100644 > --- a/drivers/regulator/core.c > +++ b/drivers/regulator/core.c [] > @@ -113,13 +113,11 @@ static int regulator_check_voltage(struct regulator_dev *rdev, > BUG_ON(*min_uV > *max_uV); > > if (!rdev->constraints) { > - printk(KERN_ERR "%s: no constraints for %s\n", __func__, > - rdev_get_name(rdev)); > + pr_err("no constraints for %s\n", rdev_get_name(rdev)); > return -ENODEV; Hi Daniel. I think it'd be better to introduce and use: #define rdev_err(rdev, fmt, ...) pr_err("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__); #define rdev_warn(rdev, fmt, ...) pr_warn("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__); #define rdev_info(rdev, fmt, ...) pr_info("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__); There are some pr_<level> uses without any rdev_get_name(rdev), but wherever an rdev is available, I'd use it. cheers, Joe (rest of original patch below, but no additional comments) > } > if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE)) { > - printk(KERN_ERR "%s: operation not allowed for %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("operation not allowed for %s\n", rdev_get_name(rdev)); > return -EPERM; > } > > @@ -141,13 +139,11 @@ static int regulator_check_current_limit(struct regulator_dev *rdev, > BUG_ON(*min_uA > *max_uA); > > if (!rdev->constraints) { > - printk(KERN_ERR "%s: no constraints for %s\n", __func__, > - rdev_get_name(rdev)); > + pr_err("no constraints for %s\n", rdev_get_name(rdev)); > return -ENODEV; > } > if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_CURRENT)) { > - printk(KERN_ERR "%s: operation not allowed for %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("operation not allowed for %s\n", rdev_get_name(rdev)); > return -EPERM; > } > > @@ -176,18 +172,15 @@ static int regulator_check_mode(struct regulator_dev *rdev, int mode) > } > > if (!rdev->constraints) { > - printk(KERN_ERR "%s: no constraints for %s\n", __func__, > - rdev_get_name(rdev)); > + pr_err("no constraints for %s\n", rdev_get_name(rdev)); > return -ENODEV; > } > if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_MODE)) { > - printk(KERN_ERR "%s: operation not allowed for %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("operation not allowed for %s\n", rdev_get_name(rdev)); > return -EPERM; > } > if (!(rdev->constraints->valid_modes_mask & mode)) { > - printk(KERN_ERR "%s: invalid mode %x for %s\n", > - __func__, mode, rdev_get_name(rdev)); > + pr_err("invalid mode %x for %s\n", mode, rdev_get_name(rdev)); > return -EINVAL; > } > return 0; > @@ -197,13 +190,11 @@ static int regulator_check_mode(struct regulator_dev *rdev, int mode) > static int regulator_check_drms(struct regulator_dev *rdev) > { > if (!rdev->constraints) { > - printk(KERN_ERR "%s: no constraints for %s\n", __func__, > - rdev_get_name(rdev)); > + pr_err("no constraints for %s\n", rdev_get_name(rdev)); > return -ENODEV; > } > if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_DRMS)) { > - printk(KERN_ERR "%s: operation not allowed for %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("operation not allowed for %s\n", rdev_get_name(rdev)); > return -EPERM; > } > return 0; > @@ -600,20 +591,18 @@ static int suspend_set_state(struct regulator_dev *rdev, > */ > if (!rstate->enabled && !rstate->disabled) { > if (can_set_state) > - printk(KERN_WARNING "%s: No configuration for %s\n", > - __func__, rdev_get_name(rdev)); > + pr_warning("No configuration for %s\n", > + rdev_get_name(rdev)); > return 0; > } > > if (rstate->enabled && rstate->disabled) { > - printk(KERN_ERR "%s: invalid configuration for %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("invalid configuration for %s\n", rdev_get_name(rdev)); > return -EINVAL; > } > > if (!can_set_state) { > - printk(KERN_ERR "%s: no way to set suspend state\n", > - __func__); > + pr_err("no way to set suspend state\n"); > return -EINVAL; > } > > @@ -622,15 +611,14 @@ static int suspend_set_state(struct regulator_dev *rdev, > else > ret = rdev->desc->ops->set_suspend_disable(rdev); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to enabled/disable\n", __func__); > + pr_err("failed to enabled/disable\n"); > return ret; > } > > if (rdev->desc->ops->set_suspend_voltage && rstate->uV > 0) { > ret = rdev->desc->ops->set_suspend_voltage(rdev, rstate->uV); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to set voltage\n", > - __func__); > + pr_err("failed to set voltage\n"); > return ret; > } > } > @@ -638,7 +626,7 @@ static int suspend_set_state(struct regulator_dev *rdev, > if (rdev->desc->ops->set_suspend_mode && rstate->mode > 0) { > ret = rdev->desc->ops->set_suspend_mode(rdev, rstate->mode); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to set mode\n", __func__); > + pr_err("failed to set mode\n"); > return ret; > } > } > @@ -733,9 +721,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, > ret = ops->set_voltage(rdev, > rdev->constraints->min_uV, rdev->constraints->max_uV); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to apply %duV constraint to %s\n", > - __func__, > - rdev->constraints->min_uV, name); > + pr_err("failed to apply %duV constraint to %s\n", > + rdev->constraints->min_uV, name); > rdev->constraints = NULL; > return ret; > } > @@ -842,8 +829,8 @@ static int set_machine_constraints(struct regulator_dev *rdev, > if (constraints->initial_state) { > ret = suspend_prepare(rdev, constraints->initial_state); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to set suspend state for %s\n", > - __func__, name); > + pr_err("failed to set suspend state for %s\n", > + name); > rdev->constraints = NULL; > goto out; > } > @@ -851,17 +838,16 @@ static int set_machine_constraints(struct regulator_dev *rdev, > > if (constraints->initial_mode) { > if (!ops->set_mode) { > - printk(KERN_ERR "%s: no set_mode operation for %s\n", > - __func__, name); > + pr_err("no set_mode operation for %s\n", > + name); > ret = -EINVAL; > goto out; > } > > ret = ops->set_mode(rdev, constraints->initial_mode); > if (ret < 0) { > - printk(KERN_ERR > - "%s: failed to set initial mode for %s: %d\n", > - __func__, name, ret); > + pr_err("failed to set initial mode for %s: %d\n", > + name, ret); > goto out; > } > } > @@ -872,8 +858,7 @@ static int set_machine_constraints(struct regulator_dev *rdev, > if ((constraints->always_on || constraints->boot_on) && ops->enable) { > ret = ops->enable(rdev); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to enable %s\n", > - __func__, name); > + pr_err("failed to enable %s\n", name); > rdev->constraints = NULL; > goto out; > } > @@ -901,9 +886,8 @@ static int set_supply(struct regulator_dev *rdev, > err = sysfs_create_link(&rdev->dev.kobj, &supply_rdev->dev.kobj, > "supply"); > if (err) { > - printk(KERN_ERR > - "%s: could not add device link %s err %d\n", > - __func__, supply_rdev->dev.kobj.name, err); > + pr_err("could not add device link %s err %d\n", > + supply_rdev->dev.kobj.name, err); > goto out; > } > rdev->supply = supply_rdev; > @@ -1051,9 +1035,8 @@ static struct regulator *create_regulator(struct regulator_dev *rdev, > err = sysfs_create_link(&rdev->dev.kobj, &dev->kobj, > buf); > if (err) { > - printk(KERN_WARNING > - "%s: could not add device link %s err %d\n", > - __func__, dev->kobj.name, err); > + pr_warning("could not add device link %s err %d\n", > + dev->kobj.name, err); > device_remove_file(dev, ®ulator->dev_attr); > goto link_name_err; > } > @@ -1274,8 +1257,8 @@ static int _regulator_enable(struct regulator_dev *rdev) > if (rdev->supply) { > ret = _regulator_enable(rdev->supply); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to enable %s: %d\n", > - __func__, rdev_get_name(rdev), ret); > + pr_err("failed to enable %s: %d\n", > + rdev_get_name(rdev), ret); > return ret; > } > } > @@ -1301,10 +1284,9 @@ static int _regulator_enable(struct regulator_dev *rdev) > if (ret >= 0) { > delay = ret; > } else { > - printk(KERN_WARNING > - "%s: enable_time() failed for %s: %d\n", > - __func__, rdev_get_name(rdev), > - ret); > + pr_warning("enable_time() failed for %s: %d\n", > + rdev_get_name(rdev), > + ret); > delay = 0; > } > > @@ -1321,8 +1303,8 @@ static int _regulator_enable(struct regulator_dev *rdev) > udelay(delay); > > } else if (ret < 0) { > - printk(KERN_ERR "%s: is_enabled() failed for %s: %d\n", > - __func__, rdev_get_name(rdev), ret); > + pr_err("is_enabled() failed for %s: %d\n", > + rdev_get_name(rdev), ret); > return ret; > } > /* Fallthrough on positive return values - already enabled */ > @@ -1376,8 +1358,8 @@ static int _regulator_disable(struct regulator_dev *rdev, > rdev->desc->ops->disable) { > ret = rdev->desc->ops->disable(rdev); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to disable %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("failed to disable %s\n", > + rdev_get_name(rdev)); > return ret; > } > > @@ -1447,8 +1429,8 @@ static int _regulator_force_disable(struct regulator_dev *rdev, > /* ah well, who wants to live forever... */ > ret = rdev->desc->ops->disable(rdev); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to force disable %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("failed to force disable %s\n", > + rdev_get_name(rdev)); > return ret; > } > /* notify other consumers that power has been forced off */ > @@ -1878,8 +1860,8 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load) > /* get output voltage */ > output_uV = rdev->desc->ops->get_voltage(rdev); > if (output_uV <= 0) { > - printk(KERN_ERR "%s: invalid output voltage found for %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("invalid output voltage found for %s\n", > + rdev_get_name(rdev)); > goto out; > } > > @@ -1889,8 +1871,8 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load) > else > input_uV = rdev->constraints->input_uV; > if (input_uV <= 0) { > - printk(KERN_ERR "%s: invalid input voltage found for %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("invalid input voltage found for %s\n", > + rdev_get_name(rdev)); > goto out; > } > > @@ -1903,16 +1885,16 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load) > total_uA_load); > ret = regulator_check_mode(rdev, mode); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to get optimum mode for %s @" > - " %d uA %d -> %d uV\n", __func__, rdev_get_name(rdev), > + pr_err("failed to get optimum mode for %s @" > + " %d uA %d -> %d uV\n", rdev_get_name(rdev), > total_uA_load, input_uV, output_uV); > goto out; > } > > ret = rdev->desc->ops->set_mode(rdev, mode); > if (ret < 0) { > - printk(KERN_ERR "%s: failed to set optimum mode %x for %s\n", > - __func__, mode, rdev_get_name(rdev)); > + pr_err("failed to set optimum mode %x for %s\n", > + mode, rdev_get_name(rdev)); > goto out; > } > ret = mode; > @@ -2459,8 +2441,7 @@ int regulator_suspend_prepare(suspend_state_t state) > mutex_unlock(&rdev->mutex); > > if (ret < 0) { > - printk(KERN_ERR "%s: failed to prepare %s\n", > - __func__, rdev_get_name(rdev)); > + pr_err("failed to prepare %s\n", rdev_get_name(rdev)); > goto out; > } > } > @@ -2618,13 +2599,10 @@ static int __init regulator_init_complete(void) > if (has_full_constraints) { > /* We log since this may kill the system if it > * goes wrong. */ > - printk(KERN_INFO "%s: disabling %s\n", > - __func__, name); > + pr_info("disabling %s\n", name); > ret = ops->disable(rdev); > if (ret != 0) { > - printk(KERN_ERR > - "%s: couldn't disable %s: %d\n", > - __func__, name, ret); > + pr_err("couldn't disable %s: %d\n", name, ret); > } > } else { > /* The intention is that in future we will > @@ -2632,9 +2610,8 @@ static int __init regulator_init_complete(void) > * so warn even if we aren't going to do > * anything here. > */ > - printk(KERN_WARNING > - "%s: incomplete constraints, leaving %s on\n", > - __func__, name); > + pr_warning("incomplete constraints, leaving %s on\n", > + name); > } > > unlock: ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros 2010-11-18 0:36 ` Joe Perches @ 2010-11-18 1:30 ` Joe Perches 2010-11-18 13:30 ` Mark Brown 2010-11-18 13:29 ` Mark Brown 1 sibling, 1 reply; 14+ messages in thread From: Joe Perches @ 2010-11-18 1:30 UTC (permalink / raw) To: Daniel Walker; +Cc: Liam Girdwood, Mark Brown, linux-kernel, bleong On Wed, 2010-11-17 at 16:36 -0800, Joe Perches wrote: > On Wed, 2010-11-17 at 15:30 -0800, Daniel Walker wrote: > > The regulator framework uses a lot of printks with a > > specific formatting using __func__. This converts them > > to use pr_ calls with a central format string. > [] > > drivers/regulator/core.c | 131 +++++++++++++++++++--------------------------- > > 1 files changed, 54 insertions(+), 77 deletions(-) > > > > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > > index a3ca3d6..67cae17 100644 > > --- a/drivers/regulator/core.c > > +++ b/drivers/regulator/core.c > [] > > @@ -113,13 +113,11 @@ static int regulator_check_voltage(struct regulator_dev *rdev, > > BUG_ON(*min_uV > *max_uV); > > > > if (!rdev->constraints) { > > - printk(KERN_ERR "%s: no constraints for %s\n", __func__, > > - rdev_get_name(rdev)); > > + pr_err("no constraints for %s\n", rdev_get_name(rdev)); > > return -ENODEV; > > Hi Daniel. > > I think it'd be better to introduce and use: > > #define rdev_err(rdev, fmt, ...) > pr_err("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__); > #define rdev_warn(rdev, fmt, ...) > pr_warn("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__); > #define rdev_info(rdev, fmt, ...) > pr_info("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__); Perhaps something like this: Compiled/untested. --- drivers/regulator/core.c | 182 ++++++++++++++++++--------------------------- 1 files changed, 73 insertions(+), 109 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index f1d10c9..5dcec73 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -13,6 +13,8 @@ * */ +#define pr_fmt(fmt) "%s: " fmt, __func__ + #include <linux/kernel.h> #include <linux/init.h> #include <linux/device.h> @@ -29,6 +31,15 @@ #define REGULATOR_VERSION "0.5" +#define rdev_err(rdev, fmt, ...) \ + pr_err("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__) +#define rdev_warn(rdev, fmt, ...) \ + pr_warn("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__) +#define rdev_info(rdev, fmt, ...) \ + pr_info("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__) +#define rdev_debug(rdev, fmt, ...) \ + pr_debug("%s: " fmt, rdev_get_name(rdev), ##__VA_ARGS__) + static DEFINE_MUTEX(regulator_list_mutex); static LIST_HEAD(regulator_list); static LIST_HEAD(regulator_map_list); @@ -111,13 +122,11 @@ static int regulator_check_voltage(struct regulator_dev *rdev, BUG_ON(*min_uV > *max_uV); if (!rdev->constraints) { - printk(KERN_ERR "%s: no constraints for %s\n", __func__, - rdev_get_name(rdev)); + rdev_err(rdev, "no constraints\n"); return -ENODEV; } if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_VOLTAGE)) { - printk(KERN_ERR "%s: operation not allowed for %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "operation not allowed\n"); return -EPERM; } @@ -139,13 +148,11 @@ static int regulator_check_current_limit(struct regulator_dev *rdev, BUG_ON(*min_uA > *max_uA); if (!rdev->constraints) { - printk(KERN_ERR "%s: no constraints for %s\n", __func__, - rdev_get_name(rdev)); + rdev_err(rdev, "no constraints\n"); return -ENODEV; } if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_CURRENT)) { - printk(KERN_ERR "%s: operation not allowed for %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "operation not allowed\n"); return -EPERM; } @@ -174,18 +181,15 @@ static int regulator_check_mode(struct regulator_dev *rdev, int mode) } if (!rdev->constraints) { - printk(KERN_ERR "%s: no constraints for %s\n", __func__, - rdev_get_name(rdev)); + rdev_err(rdev, "no constraints\n"); return -ENODEV; } if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_MODE)) { - printk(KERN_ERR "%s: operation not allowed for %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "operation not allowed\n"); return -EPERM; } if (!(rdev->constraints->valid_modes_mask & mode)) { - printk(KERN_ERR "%s: invalid mode %x for %s\n", - __func__, mode, rdev_get_name(rdev)); + rdev_err(rdev, "invalid mode %x\n", mode); return -EINVAL; } return 0; @@ -195,13 +199,11 @@ static int regulator_check_mode(struct regulator_dev *rdev, int mode) static int regulator_check_drms(struct regulator_dev *rdev) { if (!rdev->constraints) { - printk(KERN_ERR "%s: no constraints for %s\n", __func__, - rdev_get_name(rdev)); + rdev_err(rdev, "no constraints\n"); return -ENODEV; } if (!(rdev->constraints->valid_ops_mask & REGULATOR_CHANGE_DRMS)) { - printk(KERN_ERR "%s: operation not allowed for %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "operation not allowed\n"); return -EPERM; } return 0; @@ -598,20 +600,17 @@ static int suspend_set_state(struct regulator_dev *rdev, */ if (!rstate->enabled && !rstate->disabled) { if (can_set_state) - printk(KERN_WARNING "%s: No configuration for %s\n", - __func__, rdev_get_name(rdev)); + rdev_warn(rdev, "No configuration\n"); return 0; } if (rstate->enabled && rstate->disabled) { - printk(KERN_ERR "%s: invalid configuration for %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "invalid configuration\n"); return -EINVAL; } if (!can_set_state) { - printk(KERN_ERR "%s: no way to set suspend state\n", - __func__); + rdev_err(rdev, "no way to set suspend state\n"); return -EINVAL; } @@ -620,15 +619,14 @@ static int suspend_set_state(struct regulator_dev *rdev, else ret = rdev->desc->ops->set_suspend_disable(rdev); if (ret < 0) { - printk(KERN_ERR "%s: failed to enabled/disable\n", __func__); + rdev_err(rdev, "failed to enabled/disable\n"); return ret; } if (rdev->desc->ops->set_suspend_voltage && rstate->uV > 0) { ret = rdev->desc->ops->set_suspend_voltage(rdev, rstate->uV); if (ret < 0) { - printk(KERN_ERR "%s: failed to set voltage\n", - __func__); + rdev_err(rdev, "failed to set voltage\n"); return ret; } } @@ -636,7 +634,7 @@ static int suspend_set_state(struct regulator_dev *rdev, if (rdev->desc->ops->set_suspend_mode && rstate->mode > 0) { ret = rdev->desc->ops->set_suspend_mode(rdev, rstate->mode); if (ret < 0) { - printk(KERN_ERR "%s: failed to set mode\n", __func__); + rdev_err(rdev, "failed to set mode\n"); return ret; } } @@ -714,14 +712,13 @@ static void print_constraints(struct regulator_dev *rdev) if (constraints->valid_modes_mask & REGULATOR_MODE_STANDBY) count += sprintf(buf + count, "standby"); - printk(KERN_INFO "regulator: %s: %s\n", rdev_get_name(rdev), buf); + rdev_info(rdev, "regulator: %s\n", buf); } static int machine_constraints_voltage(struct regulator_dev *rdev, struct regulation_constraints *constraints) { struct regulator_ops *ops = rdev->desc->ops; - const char *name = rdev_get_name(rdev); int ret; /* do we need to apply the constraint voltage */ @@ -731,9 +728,9 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, ret = ops->set_voltage(rdev, rdev->constraints->min_uV, rdev->constraints->max_uV); if (ret < 0) { - printk(KERN_ERR "%s: failed to apply %duV constraint to %s\n", - __func__, - rdev->constraints->min_uV, name); + rdev_err(rdev, + "failed to apply %duV constraint\n", + rdev->constraints->min_uV); rdev->constraints = NULL; return ret; } @@ -765,8 +762,7 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, /* else require explicit machine-level constraints */ if (cmin <= 0 || cmax <= 0 || cmax < cmin) { - pr_err("%s: %s '%s' voltage constraints\n", - __func__, "invalid", name); + rdev_err(rdev, "invalid voltage constraints\n"); return -EINVAL; } @@ -787,22 +783,19 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, /* final: [min_uV..max_uV] valid iff constraints valid */ if (max_uV < min_uV) { - pr_err("%s: %s '%s' voltage constraints\n", - __func__, "unsupportable", name); + rdev_err(rdev, "unsupportable voltage constraints\n"); return -EINVAL; } /* use regulator's subset of machine constraints */ if (constraints->min_uV < min_uV) { - pr_debug("%s: override '%s' %s, %d -> %d\n", - __func__, name, "min_uV", - constraints->min_uV, min_uV); + rdev_debug(rdev, "override min_uV, %d -> %d\n", + constraints->min_uV, min_uV); constraints->min_uV = min_uV; } if (constraints->max_uV > max_uV) { - pr_debug("%s: override '%s' %s, %d -> %d\n", - __func__, name, "max_uV", - constraints->max_uV, max_uV); + rdev_debug(rdev, "override max_uV, %d -> %d\n", + constraints->max_uV, max_uV); constraints->max_uV = max_uV; } } @@ -825,13 +818,10 @@ static int set_machine_constraints(struct regulator_dev *rdev, struct regulation_constraints *constraints) { int ret = 0; - const char *name; struct regulator_ops *ops = rdev->desc->ops; rdev->constraints = constraints; - name = rdev_get_name(rdev); - ret = machine_constraints_voltage(rdev, constraints); if (ret != 0) goto out; @@ -840,8 +830,7 @@ static int set_machine_constraints(struct regulator_dev *rdev, if (constraints->initial_state) { ret = suspend_prepare(rdev, constraints->initial_state); if (ret < 0) { - printk(KERN_ERR "%s: failed to set suspend state for %s\n", - __func__, name); + rdev_err(rdev, "failed to set suspend state\n"); rdev->constraints = NULL; goto out; } @@ -849,17 +838,14 @@ static int set_machine_constraints(struct regulator_dev *rdev, if (constraints->initial_mode) { if (!ops->set_mode) { - printk(KERN_ERR "%s: no set_mode operation for %s\n", - __func__, name); + rdev_err(rdev, "no set_mode operation\n"); ret = -EINVAL; goto out; } ret = ops->set_mode(rdev, constraints->initial_mode); if (ret < 0) { - printk(KERN_ERR - "%s: failed to set initial mode for %s: %d\n", - __func__, name, ret); + rdev_err(rdev, "failed to set initial mode: %d\n", ret); goto out; } } @@ -870,8 +856,7 @@ static int set_machine_constraints(struct regulator_dev *rdev, if ((constraints->always_on || constraints->boot_on) && ops->enable) { ret = ops->enable(rdev); if (ret < 0) { - printk(KERN_ERR "%s: failed to enable %s\n", - __func__, name); + rdev_err(rdev, "failed to enable\n"); rdev->constraints = NULL; goto out; } @@ -899,10 +884,9 @@ static int set_supply(struct regulator_dev *rdev, err = sysfs_create_link(&rdev->dev.kobj, &supply_rdev->dev.kobj, "supply"); if (err) { - printk(KERN_ERR - "%s: could not add device link %s err %d\n", - __func__, supply_rdev->dev.kobj.name, err); - goto out; + pr_err("could not add device link %s err %d\n", + supply_rdev->dev.kobj.name, err); + goto out; } rdev->supply = supply_rdev; list_add(&rdev->slist, &supply_rdev->supply_list); @@ -957,10 +941,10 @@ static int set_consumer_device_supply(struct regulator_dev *rdev, continue; dev_dbg(consumer_dev, "%s/%s is '%s' supply; fail %s/%s\n", - dev_name(&node->regulator->dev), - node->regulator->desc->name, - supply, - dev_name(&rdev->dev), rdev_get_name(rdev)); + dev_name(&node->regulator->dev), + node->regulator->desc->name, + supply, + dev_name(&rdev->dev), rdev_get_name(rdev)); return -EBUSY; } @@ -1031,8 +1015,8 @@ static struct regulator *create_regulator(struct regulator_dev *rdev, regulator->dev_attr.show = device_requested_uA_show; err = device_create_file(dev, ®ulator->dev_attr); if (err < 0) { - printk(KERN_WARNING "%s: could not add regulator_dev" - " load sysfs\n", __func__); + rdev_warn(rdev, + "could not add regulator_dev load sysfs\n"); goto attr_name_err; } @@ -1049,9 +1033,8 @@ static struct regulator *create_regulator(struct regulator_dev *rdev, err = sysfs_create_link(&rdev->dev.kobj, &dev->kobj, buf); if (err) { - printk(KERN_WARNING - "%s: could not add device link %s err %d\n", - __func__, dev->kobj.name, err); + rdev_warn(rdev, "could not add device link %s err %d\n", + dev->kobj.name, err); device_remove_file(dev, ®ulator->dev_attr); goto link_name_err; } @@ -1089,7 +1072,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id, int ret; if (id == NULL) { - printk(KERN_ERR "regulator: get() with no identifier\n"); + pr_err("regulator: get() with no identifier\n"); return regulator; } @@ -1123,8 +1106,8 @@ static struct regulator *_regulator_get(struct device *dev, const char *id, * substitute in a dummy regulator so consumers can continue. */ if (!has_full_constraints) { - pr_warning("%s supply %s not found, using dummy regulator\n", - devname, id); + pr_warn("%s supply %s not found, using dummy regulator\n", + devname, id); rdev = dummy_regulator_rdev; goto found; } @@ -1272,8 +1255,7 @@ static int _regulator_enable(struct regulator_dev *rdev) if (rdev->supply) { ret = _regulator_enable(rdev->supply); if (ret < 0) { - printk(KERN_ERR "%s: failed to enable %s: %d\n", - __func__, rdev_get_name(rdev), ret); + rdev_err(rdev, "failed to enable: %d\n", ret); return ret; } } @@ -1299,10 +1281,8 @@ static int _regulator_enable(struct regulator_dev *rdev) if (ret >= 0) { delay = ret; } else { - printk(KERN_WARNING - "%s: enable_time() failed for %s: %d\n", - __func__, rdev_get_name(rdev), - ret); + rdev_warn(rdev, "enable_time() failed: %d\n", + ret); delay = 0; } @@ -1319,8 +1299,7 @@ static int _regulator_enable(struct regulator_dev *rdev) udelay(delay); } else if (ret < 0) { - printk(KERN_ERR "%s: is_enabled() failed for %s: %d\n", - __func__, rdev_get_name(rdev), ret); + rdev_err(rdev, "is_enabled() failed: %d\n", ret); return ret; } /* Fallthrough on positive return values - already enabled */ @@ -1374,8 +1353,7 @@ static int _regulator_disable(struct regulator_dev *rdev, rdev->desc->ops->disable) { ret = rdev->desc->ops->disable(rdev); if (ret < 0) { - printk(KERN_ERR "%s: failed to disable %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "failed to disable\n"); return ret; } @@ -1445,8 +1423,7 @@ static int _regulator_force_disable(struct regulator_dev *rdev, /* ah well, who wants to live forever... */ ret = rdev->desc->ops->disable(rdev); if (ret < 0) { - printk(KERN_ERR "%s: failed to force disable %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "failed to force disable\n"); return ret; } /* notify other consumers that power has been forced off */ @@ -1876,8 +1853,7 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load) /* get output voltage */ output_uV = rdev->desc->ops->get_voltage(rdev); if (output_uV <= 0) { - printk(KERN_ERR "%s: invalid output voltage found for %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "invalid output voltage found\n"); goto out; } @@ -1887,8 +1863,7 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load) else input_uV = rdev->constraints->input_uV; if (input_uV <= 0) { - printk(KERN_ERR "%s: invalid input voltage found for %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "invalid input voltage found\n"); goto out; } @@ -1901,16 +1876,15 @@ int regulator_set_optimum_mode(struct regulator *regulator, int uA_load) total_uA_load); ret = regulator_check_mode(rdev, mode); if (ret < 0) { - printk(KERN_ERR "%s: failed to get optimum mode for %s @" - " %d uA %d -> %d uV\n", __func__, rdev_get_name(rdev), - total_uA_load, input_uV, output_uV); + rdev_err(rdev, + "failed to get optimum mode @ %d uA %d -> %d uV\n", + total_uA_load, input_uV, output_uV); goto out; } ret = rdev->desc->ops->set_mode(rdev, mode); if (ret < 0) { - printk(KERN_ERR "%s: failed to set optimum mode %x for %s\n", - __func__, mode, rdev_get_name(rdev)); + rdev_err(rdev, "failed to set optimum mode %x\n", mode); goto out; } ret = mode; @@ -2041,7 +2015,7 @@ int regulator_bulk_enable(int num_consumers, return 0; err: - printk(KERN_ERR "Failed to enable %s: %d\n", consumers[i].supply, ret); + pr_err("Failed to enable %s: %d\n", consumers[i].supply, ret); for (--i; i >= 0; --i) regulator_disable(consumers[i].consumer); @@ -2076,8 +2050,7 @@ int regulator_bulk_disable(int num_consumers, return 0; err: - printk(KERN_ERR "Failed to disable %s: %d\n", consumers[i].supply, - ret); + pr_err("Failed to disable %s: %d\n", consumers[i].supply, ret); for (--i; i >= 0; --i) regulator_enable(consumers[i].consumer); @@ -2457,8 +2430,7 @@ int regulator_suspend_prepare(suspend_state_t state) mutex_unlock(&rdev->mutex); if (ret < 0) { - printk(KERN_ERR "%s: failed to prepare %s\n", - __func__, rdev_get_name(rdev)); + rdev_err(rdev, "failed to prepare\n"); goto out; } } @@ -2564,7 +2536,7 @@ static int __init regulator_init(void) { int ret; - printk(KERN_INFO "regulator: core version %s\n", REGULATOR_VERSION); + pr_info("regulator: core version %s\n", REGULATOR_VERSION); ret = class_register(®ulator_class); @@ -2582,7 +2554,6 @@ static int __init regulator_init_complete(void) struct regulator_ops *ops; struct regulation_constraints *c; int enabled, ret; - const char *name; mutex_lock(®ulator_list_mutex); @@ -2594,8 +2565,6 @@ static int __init regulator_init_complete(void) ops = rdev->desc->ops; c = rdev->constraints; - name = rdev_get_name(rdev); - if (!ops->disable || (c && c->always_on)) continue; @@ -2616,13 +2585,10 @@ static int __init regulator_init_complete(void) if (has_full_constraints) { /* We log since this may kill the system if it * goes wrong. */ - printk(KERN_INFO "%s: disabling %s\n", - __func__, name); + rdev_info(rdev, "disabling\n"); ret = ops->disable(rdev); if (ret != 0) { - printk(KERN_ERR - "%s: couldn't disable %s: %d\n", - __func__, name, ret); + rdev_err(rdev, "couldn't disable: %d\n", ret); } } else { /* The intention is that in future we will @@ -2630,9 +2596,7 @@ static int __init regulator_init_complete(void) * so warn even if we aren't going to do * anything here. */ - printk(KERN_WARNING - "%s: incomplete constraints, leaving %s on\n", - __func__, name); + rdev_warn(rdev, "incomplete constraints, leaving on\n"); } unlock: ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros 2010-11-18 1:30 ` Joe Perches @ 2010-11-18 13:30 ` Mark Brown 0 siblings, 0 replies; 14+ messages in thread From: Mark Brown @ 2010-11-18 13:30 UTC (permalink / raw) To: Joe Perches; +Cc: Daniel Walker, Liam Girdwood, linux-kernel, bleong On Wed, Nov 17, 2010 at 05:30:07PM -0800, Joe Perches wrote: > Perhaps something like this: This looks reasonable, please rebase on top of Daniel's patches and submit it properly (with changelog and so on). ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros 2010-11-18 0:36 ` Joe Perches 2010-11-18 1:30 ` Joe Perches @ 2010-11-18 13:29 ` Mark Brown 2010-11-18 16:29 ` Joe Perches 1 sibling, 1 reply; 14+ messages in thread From: Mark Brown @ 2010-11-18 13:29 UTC (permalink / raw) To: Joe Perches; +Cc: Daniel Walker, Liam Girdwood, linux-kernel, bleong On Wed, Nov 17, 2010 at 04:36:51PM -0800, Joe Perches wrote: > (rest of original patch below, but no additional comments) Don't do that, trim unneeded context from your mails. This makes it much easier to find the actual content you've written and is much nicer for those of us who work on mobile connections. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros 2010-11-18 13:29 ` Mark Brown @ 2010-11-18 16:29 ` Joe Perches 0 siblings, 0 replies; 14+ messages in thread From: Joe Perches @ 2010-11-18 16:29 UTC (permalink / raw) To: Mark Brown; +Cc: Daniel Walker, Liam Girdwood, linux-kernel, bleong On Thu, 2010-11-18 at 13:29 +0000, Mark Brown wrote: > On Wed, Nov 17, 2010 at 04:36:51PM -0800, Joe Perches wrote: > > (rest of original patch below, but no additional comments) > Don't do that, trim unneeded context from your mails. This makes it > much easier to find the actual content you've written and is much nicer > for those of us who work on mobile connections. If you check history, you'll find I'm consistent in doing just that, including trimming blank lines from quoted. This was an exceptional case because quoting the original and declaring "no additional comments" allows Daniel to see the changes he could make in place. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt 2010-11-17 23:30 [PATCH 1/2] drivers: regulator: core: use pr_fmt Daniel Walker 2010-11-17 23:30 ` [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros Daniel Walker @ 2010-11-18 0:29 ` Joe Perches 2010-11-18 0:35 ` Daniel Walker 2010-11-18 10:35 ` Mark Brown 2 siblings, 1 reply; 14+ messages in thread From: Joe Perches @ 2010-11-18 0:29 UTC (permalink / raw) To: Daniel Walker; +Cc: Liam Girdwood, Mark Brown, linux-kernel, bleong On Wed, 2010-11-17 at 15:30 -0800, Daniel Walker wrote: > This adds a pr_fmt line which uses the __func__ macro. I also > convert the current pr_ lines to remove their __func__ usage. [] > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > @@ -765,8 +767,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, > > /* else require explicit machine-level constraints */ > if (cmin <= 0 || cmax <= 0 || cmax < cmin) { > - pr_err("%s: %s '%s' voltage constraints\n", > - __func__, "invalid", name); > + pr_err("%s '%s' voltage constraints\n", "invalid", > + name); Using a separate pointer for invalid and unsupportable doesn't save much text space and is very hard to grep. I think it's more intelligible as: pr_err("%s: Invalid voltage constraints\n", name); > - pr_err("%s: %s '%s' voltage constraints\n", > - __func__, "unsupportable", name); > + pr_err("%s '%s' voltage constraints\n", "unsupportable", > + name); and pr_err("%s: Unsupportable voltage constraints\n", name); ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt 2010-11-18 0:29 ` [PATCH 1/2] drivers: regulator: core: use pr_fmt Joe Perches @ 2010-11-18 0:35 ` Daniel Walker 2010-11-18 10:37 ` Mark Brown 0 siblings, 1 reply; 14+ messages in thread From: Daniel Walker @ 2010-11-18 0:35 UTC (permalink / raw) To: Joe Perches; +Cc: Liam Girdwood, Mark Brown, linux-kernel, bleong On Wed, 2010-11-17 at 16:29 -0800, Joe Perches wrote: > On Wed, 2010-11-17 at 15:30 -0800, Daniel Walker wrote: > > This adds a pr_fmt line which uses the __func__ macro. I also > > convert the current pr_ lines to remove their __func__ usage. > [] > > diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > > @@ -765,8 +767,8 @@ static int machine_constraints_voltage(struct regulator_dev *rdev, > > > > /* else require explicit machine-level constraints */ > > if (cmin <= 0 || cmax <= 0 || cmax < cmin) { > > - pr_err("%s: %s '%s' voltage constraints\n", > > - __func__, "invalid", name); > > + pr_err("%s '%s' voltage constraints\n", "invalid", > > + name); > > Using a separate pointer for invalid and unsupportable > doesn't save much text space and is very hard to grep. > > I think it's more intelligible as: > > pr_err("%s: Invalid voltage constraints\n", name); I noticed that also, but I didn't feel like changing it when I did this. there is another one here, printk(KERN_WARNING "%s: could not add regulator_dev" " load sysfs\n", __func__); I'm not sure what this one was suppose to say. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt 2010-11-18 0:35 ` Daniel Walker @ 2010-11-18 10:37 ` Mark Brown 2010-11-18 16:44 ` Joe Perches 0 siblings, 1 reply; 14+ messages in thread From: Mark Brown @ 2010-11-18 10:37 UTC (permalink / raw) To: Daniel Walker; +Cc: Joe Perches, Liam Girdwood, linux-kernel, bleong On Wed, Nov 17, 2010 at 04:35:08PM -0800, Daniel Walker wrote: > On Wed, 2010-11-17 at 16:29 -0800, Joe Perches wrote: > > > + pr_err("%s '%s' voltage constraints\n", "invalid", > > > + name); > > Using a separate pointer for invalid and unsupportable > > doesn't save much text space and is very hard to grep. > > I think it's more intelligible as: > > pr_err("%s: Invalid voltage constraints\n", name); > I noticed that also, but I didn't feel like changing it when I did this. This is some stuff from David Brownell which slipped through in review and should be removed to just have the string. His theory is that this allows the compiler to merge multiple versions of the format string, resulting in a space saving but given how trivial the saving is and the impact on legibility it's really not worth it. > printk(KERN_WARNING "%s: could not add regulator_dev" > " load sysfs\n", __func__); > I'm not sure what this one was suppose to say. That's a different thing - someone's just split the string over multiple lines - the two strings will just be concatenated. ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt 2010-11-18 10:37 ` Mark Brown @ 2010-11-18 16:44 ` Joe Perches 0 siblings, 0 replies; 14+ messages in thread From: Joe Perches @ 2010-11-18 16:44 UTC (permalink / raw) To: Mark Brown; +Cc: Daniel Walker, Liam Girdwood, linux-kernel, bleong On Thu, 2010-11-18 at 10:37 +0000, Mark Brown wrote: > On Wed, Nov 17, 2010 at 04:35:08PM -0800, Daniel Walker wrote: > > printk(KERN_WARNING "%s: could not add regulator_dev" > > " load sysfs\n", __func__); > > I'm not sure what this one was suppose to say. > That's a different thing - someone's just split the string over multiple > lines - the two strings will just be concatenated. I believe he's talking about the concatenated string content itself being unintelligible gibberish. It'd be more standard as "could not create sysfs file". ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt 2010-11-17 23:30 [PATCH 1/2] drivers: regulator: core: use pr_fmt Daniel Walker 2010-11-17 23:30 ` [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros Daniel Walker 2010-11-18 0:29 ` [PATCH 1/2] drivers: regulator: core: use pr_fmt Joe Perches @ 2010-11-18 10:35 ` Mark Brown 2010-11-19 11:09 ` Liam Girdwood 2 siblings, 1 reply; 14+ messages in thread From: Mark Brown @ 2010-11-18 10:35 UTC (permalink / raw) To: Daniel Walker; +Cc: Liam Girdwood, linux-kernel, bleong On Wed, Nov 17, 2010 at 03:30:27PM -0800, Daniel Walker wrote: > This adds a pr_fmt line which uses the __func__ macro. I also > convert the current pr_ lines to remove their __func__ usage. > > Cc: bleong@codeaurora.org > Signed-off-by: Daniel Walker <dwalker@codeaurora.org> Both patches Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt 2010-11-18 10:35 ` Mark Brown @ 2010-11-19 11:09 ` Liam Girdwood 2010-11-19 17:07 ` Joe Perches 0 siblings, 1 reply; 14+ messages in thread From: Liam Girdwood @ 2010-11-19 11:09 UTC (permalink / raw) To: Mark Brown, Joe Perches; +Cc: Daniel Walker, linux-kernel, bleong On Thu, 2010-11-18 at 10:35 +0000, Mark Brown wrote: > On Wed, Nov 17, 2010 at 03:30:27PM -0800, Daniel Walker wrote: > > This adds a pr_fmt line which uses the __func__ macro. I also > > convert the current pr_ lines to remove their __func__ usage. > > > > Cc: bleong@codeaurora.org > > Signed-off-by: Daniel Walker <dwalker@codeaurora.org> > > Both patches > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> Applied with some merge fixups. Joe, I'd be happy to take any subsequent patches you have for this. Thanks Liam -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] drivers: regulator: core: use pr_fmt 2010-11-19 11:09 ` Liam Girdwood @ 2010-11-19 17:07 ` Joe Perches 0 siblings, 0 replies; 14+ messages in thread From: Joe Perches @ 2010-11-19 17:07 UTC (permalink / raw) To: Liam Girdwood; +Cc: Mark Brown, Daniel Walker, linux-kernel, bleong On Fri, 2010-11-19 at 11:09 +0000, Liam Girdwood wrote: > On Thu, 2010-11-18 at 10:35 +0000, Mark Brown wrote: > > On Wed, Nov 17, 2010 at 03:30:27PM -0800, Daniel Walker wrote: > > > This adds a pr_fmt line which uses the __func__ macro. I also > > > convert the current pr_ lines to remove their __func__ usage. > > > Cc: bleong@codeaurora.org > > > Signed-off-by: Daniel Walker <dwalker@codeaurora.org> > > Both patches > > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> > Applied with some merge fixups. > Joe, I'd be happy to take any subsequent patches you have for this. After these patches show up in -next. I think there were some other patches about as well, so maybe in a week or so. ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2010-11-19 17:07 UTC | newest] Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2010-11-17 23:30 [PATCH 1/2] drivers: regulator: core: use pr_fmt Daniel Walker 2010-11-17 23:30 ` [PATCH 2/2] drivers: regulator: core: convert to using pr_ macros Daniel Walker 2010-11-18 0:36 ` Joe Perches 2010-11-18 1:30 ` Joe Perches 2010-11-18 13:30 ` Mark Brown 2010-11-18 13:29 ` Mark Brown 2010-11-18 16:29 ` Joe Perches 2010-11-18 0:29 ` [PATCH 1/2] drivers: regulator: core: use pr_fmt Joe Perches 2010-11-18 0:35 ` Daniel Walker 2010-11-18 10:37 ` Mark Brown 2010-11-18 16:44 ` Joe Perches 2010-11-18 10:35 ` Mark Brown 2010-11-19 11:09 ` Liam Girdwood 2010-11-19 17:07 ` Joe Perches
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).