* [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions
@ 2010-12-01 6:38 Axel Lin
2010-12-01 7:43 ` Jarkko Nikula
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Axel Lin @ 2010-12-01 6:38 UTC (permalink / raw)
To: linux-kernel
Cc: Vladimir Barinov, Jarkko Nikula, Liam Girdwood, Mark Brown, alsa-devel
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
sound/soc/codecs/tlv320aic3x.c | 15 ---------------
1 files changed, 0 insertions(+), 15 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
index fc5abdf..8cd4cf5 100644
--- a/sound/soc/codecs/tlv320aic3x.c
+++ b/sound/soc/codecs/tlv320aic3x.c
@@ -1545,21 +1545,6 @@ static struct i2c_driver aic3x_i2c_driver = {
.remove = aic3x_i2c_remove,
.id_table = aic3x_i2c_id,
};
-
-static inline void aic3x_i2c_init(void)
-{
- int ret;
-
- ret = i2c_add_driver(&aic3x_i2c_driver);
- if (ret)
- printk(KERN_ERR "%s: error regsitering i2c driver, %d\n",
- __func__, ret);
-}
-
-static inline void aic3x_i2c_exit(void)
-{
- i2c_del_driver(&aic3x_i2c_driver);
-}
#endif
static int __init aic3x_modinit(void)
--
1.7.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions
2010-12-01 6:38 [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions Axel Lin
@ 2010-12-01 7:43 ` Jarkko Nikula
2010-12-01 11:28 ` Mark Brown
2010-12-02 11:52 ` Liam Girdwood
2 siblings, 0 replies; 4+ messages in thread
From: Jarkko Nikula @ 2010-12-01 7:43 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Vladimir Barinov, Liam Girdwood, Mark Brown, alsa-devel
On Wed, 01 Dec 2010 14:38:24 +0800
Axel Lin <axel.lin@gmail.com> wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/tlv320aic3x.c | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320aic3x.c b/sound/soc/codecs/tlv320aic3x.c
> index fc5abdf..8cd4cf5 100644
> --- a/sound/soc/codecs/tlv320aic3x.c
> +++ b/sound/soc/codecs/tlv320aic3x.c
> @@ -1545,21 +1545,6 @@ static struct i2c_driver aic3x_i2c_driver = {
> .remove = aic3x_i2c_remove,
> .id_table = aic3x_i2c_id,
> };
> -
> -static inline void aic3x_i2c_init(void)
> -{
> - int ret;
> -
> - ret = i2c_add_driver(&aic3x_i2c_driver);
> - if (ret)
> - printk(KERN_ERR "%s: error regsitering i2c driver, %d\n",
> - __func__, ret);
> -}
> -
> -static inline void aic3x_i2c_exit(void)
> -{
> - i2c_del_driver(&aic3x_i2c_driver);
> -}
> #endif
>
True, these are unused nowadays.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions
2010-12-01 6:38 [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions Axel Lin
2010-12-01 7:43 ` Jarkko Nikula
@ 2010-12-01 11:28 ` Mark Brown
2010-12-02 11:52 ` Liam Girdwood
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2010-12-01 11:28 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Vladimir Barinov, Jarkko Nikula, Liam Girdwood, alsa-devel
On Wed, Dec 01, 2010 at 02:38:24PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions
2010-12-01 6:38 [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions Axel Lin
2010-12-01 7:43 ` Jarkko Nikula
2010-12-01 11:28 ` Mark Brown
@ 2010-12-02 11:52 ` Liam Girdwood
2 siblings, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2010-12-02 11:52 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Vladimir Barinov, Jarkko Nikula, Mark Brown, alsa-devel
On Wed, 2010-12-01 at 14:38 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/codecs/tlv320aic3x.c | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)
>
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-02 11:52 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-01 6:38 [PATCH] ASoC: Remove unused aic3x_i2c_init and aic3x_i2c_exit functions Axel Lin
2010-12-01 7:43 ` Jarkko Nikula
2010-12-01 11:28 ` Mark Brown
2010-12-02 11:52 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).