[PATCH] USB: whci-hcd: fix compiler warning

[PATCH] USB: whci-hcd: fix compiler warning

[Namhyung Kim]

Annotate whci_hcd_id_table as '__used' to fix following warning:

  CC      drivers/usb/host/whci/hcd.o
drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
 drivers/usb/host/whci/hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/whci/hcd.c b/drivers/usb/host/whci/hcd.c
index 72b6892..9546f6c 100644
--- a/drivers/usb/host/whci/hcd.c
+++ b/drivers/usb/host/whci/hcd.c
@@ -356,7 +356,7 @@ static void __exit whci_hc_driver_exit(void)
 module_exit(whci_hc_driver_exit);
 
 /* PCI device ID's that we handle (so it gets loaded) */
-static struct pci_device_id whci_hcd_id_table[] = {
+static struct pci_device_id __used whci_hcd_id_table[] = {
 	{ PCI_DEVICE_CLASS(PCI_CLASS_WIRELESS_WHCI, ~0) },
 	{ /* empty last entry */ }
 };
-- 
1.7.0.4

Re: [PATCH] USB: whci-hcd: fix compiler warning

[Greg KH]

On Wed, Dec 01, 2010 at 01:28:41PM +0900, Namhyung Kim wrote:
> Annotate whci_hcd_id_table as '__used' to fix following warning:
> 
>   CC      drivers/usb/host/whci/hcd.o
> drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used

Are you seeing this warning when you build the module into the kernel,
or as a module?

thanks,

greg k-h

Re: [PATCH] USB: whci-hcd: fix compiler warning

[Namhyung Kim]

2010-12-01 (수), 08:10 -0800, Greg KH:
> On Wed, Dec 01, 2010 at 01:28:41PM +0900, Namhyung Kim wrote:
> > Annotate whci_hcd_id_table as '__used' to fix following warning:
> > 
> >   CC      drivers/usb/host/whci/hcd.o
> > drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used
> 
> Are you seeing this warning when you build the module into the kernel,
> or as a module?
> 
> thanks,
> 
> greg k-h

I saw it during allyesconfig build but not on allmodconfig.
Maybe we can wrap it up in #ifdef CONFIG_MODULES ?

Thanks.

-- 
Regards,
Namhyung Kim

Re: [PATCH] USB: whci-hcd: fix compiler warning

[David Vrabel]

Namhyung Kim wrote:
> 2010-12-01 (수), 08:10 -0800, Greg KH:
>> On Wed, Dec 01, 2010 at 01:28:41PM +0900, Namhyung Kim wrote:
>>> Annotate whci_hcd_id_table as '__used' to fix following warning:
>>>
>>>   CC      drivers/usb/host/whci/hcd.o
>>> drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used
>> Are you seeing this warning when you build the module into the kernel,
>> or as a module?
>>
>> thanks,
>>
>> greg k-h
> 
> I saw it during allyesconfig build but not on allmodconfig.
> Maybe we can wrap it up in #ifdef CONFIG_MODULES ?

That might be best.  Can you do the same with drivers/uwb/whc-rc.c?  It
will have the same problem.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom

Re: [PATCH] USB: whci-hcd: fix compiler warning

[Namhyung Kim]

2010-12-01 (수), 16:52 +0000, David Vrabel:
> Namhyung Kim wrote:
> > I saw it during allyesconfig build but not on allmodconfig.
> > Maybe we can wrap it up in #ifdef CONFIG_MODULES ?
> 
> That might be best.  Can you do the same with drivers/uwb/whc-rc.c?  It
> will have the same problem.
> 
> David

No problem. Will send them soon. :)
Thanks.

-- 
Regards,
Namhyung Kim

Re: [PATCH] USB: whci-hcd: fix compiler warning

[David Vrabel]

Namhyung Kim wrote:
> 2010-12-01 (수), 16:52 +0000, David Vrabel:
>> Namhyung Kim wrote:
>>> I saw it during allyesconfig build but not on allmodconfig.
>>> Maybe we can wrap it up in #ifdef CONFIG_MODULES ?
>> That might be best.  Can you do the same with drivers/uwb/whc-rc.c?  It
>> will have the same problem.
>>
>> David
> 
> No problem. Will send them soon. :)

Actually CONFIG_MODULES is wrong. It needs to test if the driver has
been built as a module or not.  I think there's a __MODULE__ or MODULE
#define for this, not sure though.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom

Re: [PATCH] USB: whci-hcd: fix compiler warning

[Namhyung Kim]

2010-12-01 (수), 17:06 +0000, David Vrabel:
> Actually CONFIG_MODULES is wrong. It needs to test if the driver has
> been built as a module or not.  I think there's a __MODULE__ or MODULE
> #define for this, not sure though.
> 
> David

Right, we use MODULE. I was just thinking about that :)

-- 
Regards,
Namhyung Kim

Re: [PATCH] USB: whci-hcd: fix compiler warning

[Greg KH]

On Thu, Dec 02, 2010 at 01:49:11AM +0900, Namhyung Kim wrote:
> 2010-12-01 (수), 08:10 -0800, Greg KH:
> > On Wed, Dec 01, 2010 at 01:28:41PM +0900, Namhyung Kim wrote:
> > > Annotate whci_hcd_id_table as '__used' to fix following warning:
> > > 
> > >   CC      drivers/usb/host/whci/hcd.o
> > > drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used
> > 
> > Are you seeing this warning when you build the module into the kernel,
> > or as a module?
> > 
> > thanks,
> > 
> > greg k-h
> 
> I saw it during allyesconfig build but not on allmodconfig.
> Maybe we can wrap it up in #ifdef CONFIG_MODULES ?

No, don't do that, your __used is the correct thing here, I just wanted
to make sure why you were seeing this warning.

thanks,

greg k-h

Re: [PATCH] USB: whci-hcd: fix compiler warning

[Namhyung Kim]

2010-12-01 (수), 09:36 -0800, Greg KH:
> On Thu, Dec 02, 2010 at 01:49:11AM +0900, Namhyung Kim wrote:
> > 2010-12-01 (수), 08:10 -0800, Greg KH:
> > > On Wed, Dec 01, 2010 at 01:28:41PM +0900, Namhyung Kim wrote:
> > > > Annotate whci_hcd_id_table as '__used' to fix following warning:
> > > > 
> > > >   CC      drivers/usb/host/whci/hcd.o
> > > > drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used
> > > 
> > > Are you seeing this warning when you build the module into the kernel,
> > > or as a module?
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > I saw it during allyesconfig build but not on allmodconfig.
> > Maybe we can wrap it up in #ifdef CONFIG_MODULES ?
> 
> No, don't do that, your __used is the correct thing here, I just wanted
> to make sure why you were seeing this warning.
> 
> thanks,
> 
> greg k-h

Hi, Greg

It seems this one is not applied in your tree yet. Do you need a resend?

Thanks.


-- 
Regards,
Namhyung Kim

Re: [PATCH] USB: whci-hcd: fix compiler warning

[Greg KH]

On Mon, Dec 06, 2010 at 10:05:30PM +0900, Namhyung Kim wrote:
> 2010-12-01 (수), 09:36 -0800, Greg KH:
> > On Thu, Dec 02, 2010 at 01:49:11AM +0900, Namhyung Kim wrote:
> > > 2010-12-01 (수), 08:10 -0800, Greg KH:
> > > > On Wed, Dec 01, 2010 at 01:28:41PM +0900, Namhyung Kim wrote:
> > > > > Annotate whci_hcd_id_table as '__used' to fix following warning:
> > > > > 
> > > > >   CC      drivers/usb/host/whci/hcd.o
> > > > > drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used
> > > > 
> > > > Are you seeing this warning when you build the module into the kernel,
> > > > or as a module?
> > > > 
> > > > thanks,
> > > > 
> > > > greg k-h
> > > 
> > > I saw it during allyesconfig build but not on allmodconfig.
> > > Maybe we can wrap it up in #ifdef CONFIG_MODULES ?
> > 
> > No, don't do that, your __used is the correct thing here, I just wanted
> > to make sure why you were seeing this warning.
> > 
> > thanks,
> > 
> > greg k-h
> 
> Hi, Greg
> 
> It seems this one is not applied in your tree yet. Do you need a resend?

Yes please, I must have missed it, thinking it was part of your other
series.  Sorry.

greg k-h

[PATCH RESEND] USB: whci-hcd: fix compiler warning

[Namhyung Kim]

Annotate whci_hcd_id_table as '__used' to fix following warning:

  CC      drivers/usb/host/whci/hcd.o
drivers/usb/host/whci/hcd.c:359: warning: ‘whci_hcd_id_table’ defined but not used

Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
 drivers/usb/host/whci/hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/whci/hcd.c b/drivers/usb/host/whci/hcd.c
index 72b6892..9546f6c 100644
--- a/drivers/usb/host/whci/hcd.c
+++ b/drivers/usb/host/whci/hcd.c
@@ -356,7 +356,7 @@ static void __exit whci_hc_driver_exit(void)
 module_exit(whci_hc_driver_exit);
 
 /* PCI device ID's that we handle (so it gets loaded) */
-static struct pci_device_id whci_hcd_id_table[] = {
+static struct pci_device_id __used whci_hcd_id_table[] = {
 	{ PCI_DEVICE_CLASS(PCI_CLASS_WIRELESS_WHCI, ~0) },
 	{ /* empty last entry */ }
 };
-- 
1.7.0.4