[PATCH] Add forward declaration of struct device

[PATCH] Add forward declaration of struct device

[Rolf Eike Beer]

This fixes this warning when including linux/dmapool.h first:

warning: ‘struct device’ declared inside parameter list
warning: its scope is only this definition or declaration, which is probably not what you want

Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
---
 include/linux/dmapool.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/include/linux/dmapool.h b/include/linux/dmapool.h
index 022e34f..52456aa 100644
--- a/include/linux/dmapool.h
+++ b/include/linux/dmapool.h
@@ -14,6 +14,8 @@
 #include <asm/io.h>
 #include <asm/scatterlist.h>
 
+struct device;
+
 struct dma_pool *dma_pool_create(const char *name, struct device *dev, 
 			size_t size, size_t align, size_t allocation);
 
-- 
1.6.4.2

Re: [PATCH] Add forward declaration of struct device

[Jiri Kosina]

On Mon, 20 Dec 2010, Rolf Eike Beer wrote:

> This fixes this warning when including linux/dmapool.h first:
> 
> warning: ‘struct device’ declared inside parameter list
> warning: its scope is only this definition or declaration, which is probably not what you want

In what situation do you see this warning? (the one you have posted 
doesn't show the filename that is being compiled).

> 
> Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
> ---
>  include/linux/dmapool.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/dmapool.h b/include/linux/dmapool.h
> index 022e34f..52456aa 100644
> --- a/include/linux/dmapool.h
> +++ b/include/linux/dmapool.h
> @@ -14,6 +14,8 @@
>  #include <asm/io.h>
>  #include <asm/scatterlist.h>
>  
> +struct device;
> +
>  struct dma_pool *dma_pool_create(const char *name, struct device *dev, 
>  			size_t size, size_t align, size_t allocation);
>  

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

Re: [PATCH] Add forward declaration of struct device

[Rolf Eike Beer]

[-- Attachment #1: Type: Text/Plain, Size: 511 bytes --]

Am Mittwoch 19 Januar 2011, 15:56:47 schrieb Jiri Kosina:
> On Mon, 20 Dec 2010, Rolf Eike Beer wrote:
> > This fixes this warning when including linux/dmapool.h first:
> > 
> > warning: ‘struct device’ declared inside parameter list
> > warning: its scope is only this definition or declaration, which is
> > probably not what you want
> 
> In what situation do you see this warning? (the one you have posted
> doesn't show the filename that is being compiled).

Nothing (yet) in tree.

Eike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]