* Re: [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up
[not found] <tip-14bc7a06c6175cfa8070a5f5022210b648c3e0a7@git.kernel.org>
@ 2010-12-22 13:19 ` Peter Zijlstra
2010-12-22 13:21 ` Peter Zijlstra
2010-12-22 13:46 ` Steven Rostedt
0 siblings, 2 replies; 4+ messages in thread
From: Peter Zijlstra @ 2010-12-22 13:19 UTC (permalink / raw)
To: linux-kernel, mingo, hpa, rostedt, srostedt, tglx; +Cc: linux-tip-commits
On Wed, 2010-12-22 at 13:16 +0000, tip-bot for Steven Rostedt wrote:
> Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> Author: Steven Rostedt <srostedt@redhat.com>
> AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500
> Committer: Steven Rostedt <rostedt@goodmis.org>
> CommitDate: Fri, 3 Dec 2010 10:46:59 -0500
>
> tracing: Only trace sched_wakeup if it actually work something up
>
> Currently the tracepoint sched_wakeup traces the wakeup event even
> if the wakeup failed to wake anything up. This is quite stupid
> but it happens because we did not want to add a conditional
> to the core kernel code that would just slow down the wakeup events.
>
> This patch changes the wakeup tracepoints to use the
>
> DEFINE_EVENT_CONDITIONAL()
>
> to test the "success" parameter and will only trace the event if
> the wakeup was successfull.
>
> The success field in the tracepoint is removed since it is no
> longer needed.
I NAKed this, its stupid.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up
2010-12-22 13:19 ` [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up Peter Zijlstra
@ 2010-12-22 13:21 ` Peter Zijlstra
2010-12-22 13:46 ` Steven Rostedt
1 sibling, 0 replies; 4+ messages in thread
From: Peter Zijlstra @ 2010-12-22 13:21 UTC (permalink / raw)
To: linux-kernel; +Cc: mingo, hpa, rostedt, srostedt, tglx, linux-tip-commits
On Wed, 2010-12-22 at 14:19 +0100, Peter Zijlstra wrote:
> On Wed, 2010-12-22 at 13:16 +0000, tip-bot for Steven Rostedt wrote:
> > Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > Author: Steven Rostedt <srostedt@redhat.com>
> > AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500
> > Committer: Steven Rostedt <rostedt@goodmis.org>
> > CommitDate: Fri, 3 Dec 2010 10:46:59 -0500
> >
> > tracing: Only trace sched_wakeup if it actually work something up
> >
> > Currently the tracepoint sched_wakeup traces the wakeup event even
> > if the wakeup failed to wake anything up. This is quite stupid
> > but it happens because we did not want to add a conditional
> > to the core kernel code that would just slow down the wakeup events.
> >
> > This patch changes the wakeup tracepoints to use the
> >
> > DEFINE_EVENT_CONDITIONAL()
> >
> > to test the "success" parameter and will only trace the event if
> > the wakeup was successfull.
> >
> > The success field in the tracepoint is removed since it is no
> > longer needed.
>
> I NAKed this, its stupid.
And wrong too, I got a patch that makes success:=true, I also got a
patch removing success entirely but people started wanking that their
proglets rely on having it :/
Ideally I'd commit the removal and let whatever breaks break.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up
2010-12-22 13:19 ` [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up Peter Zijlstra
2010-12-22 13:21 ` Peter Zijlstra
@ 2010-12-22 13:46 ` Steven Rostedt
2010-12-22 16:12 ` Ingo Molnar
1 sibling, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2010-12-22 13:46 UTC (permalink / raw)
To: Peter Zijlstra
Cc: linux-kernel, mingo, hpa, srostedt, tglx, linux-tip-commits
On Wed, 2010-12-22 at 14:19 +0100, Peter Zijlstra wrote:
> On Wed, 2010-12-22 at 13:16 +0000, tip-bot for Steven Rostedt wrote:
> > Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > Author: Steven Rostedt <srostedt@redhat.com>
> > AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500
> > Committer: Steven Rostedt <rostedt@goodmis.org>
> > CommitDate: Fri, 3 Dec 2010 10:46:59 -0500
> >
> > tracing: Only trace sched_wakeup if it actually work something up
> >
> > Currently the tracepoint sched_wakeup traces the wakeup event even
> > if the wakeup failed to wake anything up. This is quite stupid
> > but it happens because we did not want to add a conditional
> > to the core kernel code that would just slow down the wakeup events.
> >
> > This patch changes the wakeup tracepoints to use the
> >
> > DEFINE_EVENT_CONDITIONAL()
> >
> > to test the "success" parameter and will only trace the event if
> > the wakeup was successfull.
> >
> > The success field in the tracepoint is removed since it is no
> > longer needed.
>
> I NAKed this, its stupid.
I wouldn't call it stupid, but unnecessary, yes.
Anyway, it was the last patch of the series.
Ingo, can you revert this last patch?
Thanks,
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up
2010-12-22 13:46 ` Steven Rostedt
@ 2010-12-22 16:12 ` Ingo Molnar
0 siblings, 0 replies; 4+ messages in thread
From: Ingo Molnar @ 2010-12-22 16:12 UTC (permalink / raw)
To: Steven Rostedt
Cc: Peter Zijlstra, linux-kernel, mingo, hpa, srostedt, tglx,
linux-tip-commits
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 2010-12-22 at 14:19 +0100, Peter Zijlstra wrote:
> > On Wed, 2010-12-22 at 13:16 +0000, tip-bot for Steven Rostedt wrote:
> > > Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > > Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> > > Author: Steven Rostedt <srostedt@redhat.com>
> > > AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500
> > > Committer: Steven Rostedt <rostedt@goodmis.org>
> > > CommitDate: Fri, 3 Dec 2010 10:46:59 -0500
> > >
> > > tracing: Only trace sched_wakeup if it actually work something up
> > >
> > > Currently the tracepoint sched_wakeup traces the wakeup event even
> > > if the wakeup failed to wake anything up. This is quite stupid
> > > but it happens because we did not want to add a conditional
> > > to the core kernel code that would just slow down the wakeup events.
> > >
> > > This patch changes the wakeup tracepoints to use the
> > >
> > > DEFINE_EVENT_CONDITIONAL()
> > >
> > > to test the "success" parameter and will only trace the event if
> > > the wakeup was successfull.
> > >
> > > The success field in the tracepoint is removed since it is no
> > > longer needed.
> >
> > I NAKed this, its stupid.
>
> I wouldn't call it stupid, but unnecessary, yes.
>
> Anyway, it was the last patch of the series.
>
> Ingo, can you revert this last patch?
Yeah, done.
Thanks guys,
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-12-22 16:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tip-14bc7a06c6175cfa8070a5f5022210b648c3e0a7@git.kernel.org>
2010-12-22 13:19 ` [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up Peter Zijlstra
2010-12-22 13:21 ` Peter Zijlstra
2010-12-22 13:46 ` Steven Rostedt
2010-12-22 16:12 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).