* [PATCH] ll_temac: Fix section mismatch from the temac_of_probe
@ 2011-01-03 10:32 Michal Simek
2011-01-03 17:03 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Michal Simek @ 2011-01-03 10:32 UTC (permalink / raw)
To: grant.likely
Cc: netdev, linux-kernel, devicetree-discuss, davem, Michal Simek
Replace __init by __devinit.
Warning message:
WARNING: vmlinux.o(.data+0xbc14): Section mismatch in reference from the variable
temac_of_driver to the function .init.text:temac_of_probe()
The variable temac_of_driver references
the function __init temac_of_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
Signed-off-by: Michal Simek <monstr@monstr.eu>
---
drivers/net/ll_temac_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ll_temac_main.c b/drivers/net/ll_temac_main.c
index 9f8e702..beb6ed8 100644
--- a/drivers/net/ll_temac_main.c
+++ b/drivers/net/ll_temac_main.c
@@ -952,7 +952,7 @@ static const struct attribute_group temac_attr_group = {
.attrs = temac_device_attrs,
};
-static int __init
+static int __devinit
temac_of_probe(struct platform_device *op, const struct of_device_id *match)
{
struct device_node *np;
--
1.5.5.6
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ll_temac: Fix section mismatch from the temac_of_probe
2011-01-03 10:32 [PATCH] ll_temac: Fix section mismatch from the temac_of_probe Michal Simek
@ 2011-01-03 17:03 ` Grant Likely
2011-01-03 20:07 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Grant Likely @ 2011-01-03 17:03 UTC (permalink / raw)
To: Michal Simek; +Cc: netdev, linux-kernel, devicetree-discuss, davem
On Mon, Jan 03, 2011 at 11:32:36AM +0100, Michal Simek wrote:
> Replace __init by __devinit.
>
> Warning message:
> WARNING: vmlinux.o(.data+0xbc14): Section mismatch in reference from the variable
> temac_of_driver to the function .init.text:temac_of_probe()
> The variable temac_of_driver references
> the function __init temac_of_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
> Signed-off-by: Michal Simek <monstr@monstr.eu>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
> ---
> drivers/net/ll_temac_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ll_temac_main.c b/drivers/net/ll_temac_main.c
> index 9f8e702..beb6ed8 100644
> --- a/drivers/net/ll_temac_main.c
> +++ b/drivers/net/ll_temac_main.c
> @@ -952,7 +952,7 @@ static const struct attribute_group temac_attr_group = {
> .attrs = temac_device_attrs,
> };
>
> -static int __init
> +static int __devinit
> temac_of_probe(struct platform_device *op, const struct of_device_id *match)
> {
> struct device_node *np;
> --
> 1.5.5.6
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ll_temac: Fix section mismatch from the temac_of_probe
2011-01-03 17:03 ` Grant Likely
@ 2011-01-03 20:07 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-01-03 20:07 UTC (permalink / raw)
To: grant.likely; +Cc: monstr, netdev, linux-kernel, devicetree-discuss
From: Grant Likely <grant.likely@secretlab.ca>
Date: Mon, 3 Jan 2011 10:03:32 -0700
> On Mon, Jan 03, 2011 at 11:32:36AM +0100, Michal Simek wrote:
>> Replace __init by __devinit.
>>
>> Warning message:
>> WARNING: vmlinux.o(.data+0xbc14): Section mismatch in reference from the variable
>> temac_of_driver to the function .init.text:temac_of_probe()
>> The variable temac_of_driver references
>> the function __init temac_of_probe()
>> If the reference is valid then annotate the
>> variable with __init* or __refdata (see linux/init.h) or name the variable:
>> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>>
>> Signed-off-by: Michal Simek <monstr@monstr.eu>
>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-03 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-03 10:32 [PATCH] ll_temac: Fix section mismatch from the temac_of_probe Michal Simek
2011-01-03 17:03 ` Grant Likely
2011-01-03 20:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).