* checkpatch.pl: never finishes w/ specific file
@ 2011-03-02 16:31 Toralf Förster
2011-03-04 4:07 ` Jovi Zhang
2011-03-16 11:47 ` Andy Whitcroft
0 siblings, 2 replies; 6+ messages in thread
From: Toralf Förster @ 2011-03-02 16:31 UTC (permalink / raw)
To: akpm, apw; +Cc: linux-kernel
Hello,
this runs infinitely :
./scripts/checkpatch.pl --file ./drivers/staging/rtl8192u/r819xU_firmware_img.c
Is this a known behaviour of checkpatch.pl ?
--
MfG/Kind regards
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: checkpatch.pl: never finishes w/ specific file
2011-03-02 16:31 checkpatch.pl: never finishes w/ specific file Toralf Förster
@ 2011-03-04 4:07 ` Jovi Zhang
2011-03-16 11:47 ` Andy Whitcroft
1 sibling, 0 replies; 6+ messages in thread
From: Jovi Zhang @ 2011-03-04 4:07 UTC (permalink / raw)
To: Toralf Förster; +Cc: akpm, apw, linux-kernel
2011/3/3 Toralf Förster <toralf.foerster@gmx.de>:
> Hello,
>
> this runs infinitely :
>
> ./scripts/checkpatch.pl --file ./drivers/staging/rtl8192u/r819xU_firmware_img.c
>
> Is this a known behaviour of checkpatch.pl ?
>
Not infinitely, just need to wait for a long time.
checkpatch.pl works fine, it report like this:
ERROR: space required after that ',' (ctx:VxV)
+0x01,0x00,0x00,0x08,0x00,0x00,0x00,0x00,};
^
That file miss so many whitespace after ',' from checkpatch point of view.
Anyway, forget it, checkpatch.pl is not recommended to check those files.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: checkpatch.pl: never finishes w/ specific file
2011-03-02 16:31 checkpatch.pl: never finishes w/ specific file Toralf Förster
2011-03-04 4:07 ` Jovi Zhang
@ 2011-03-16 11:47 ` Andy Whitcroft
2011-03-16 12:16 ` Toralf Förster
2011-03-21 10:42 ` Toralf Förster
1 sibling, 2 replies; 6+ messages in thread
From: Andy Whitcroft @ 2011-03-16 11:47 UTC (permalink / raw)
To: Toralf Förster; +Cc: akpm, linux-kernel
On Wed, Mar 02, 2011 at 05:31:01PM +0100, Toralf Förster wrote:
> Hello,
>
> this runs infinitely :
>
> ./scripts/checkpatch.pl --file ./drivers/staging/rtl8192u/r819xU_firmware_img.c
>
> Is this a known behaviour of checkpatch.pl ?
That one may be already fixed in my development version. The form of
the file is familiar.
Could you try your file with the one below and let me know:
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
-apw
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: checkpatch.pl: never finishes w/ specific file
2011-03-16 11:47 ` Andy Whitcroft
@ 2011-03-16 12:16 ` Toralf Förster
2011-03-21 10:42 ` Toralf Förster
1 sibling, 0 replies; 6+ messages in thread
From: Toralf Förster @ 2011-03-16 12:16 UTC (permalink / raw)
To: Andy Whitcroft; +Cc: akpm, linux-kernel
Andy Whitcroft wrote at 12:47:52
> That one may be already fixed in my development version. The form of
> the file is familiar.
>
> Could you try your file with the one below and let me know:
> -apw
That works much more faster :
real 0m18.215s
user 0m8.876s
sys 0m0.281s
:-)
--
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: checkpatch.pl: never finishes w/ specific file
2011-03-16 11:47 ` Andy Whitcroft
2011-03-16 12:16 ` Toralf Förster
@ 2011-03-21 10:42 ` Toralf Förster
2011-03-21 23:46 ` Andy Whitcroft
1 sibling, 1 reply; 6+ messages in thread
From: Toralf Förster @ 2011-03-21 10:42 UTC (permalink / raw)
To: Andy Whitcroft; +Cc: akpm, linux-kernel
Andy Whitcroft wrote at 12:47:52
> Could you try your file with the one below and let me know:
>
>
> http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl
I've a question about line 1365 :
if ($realfile =~ m@^include/asm\/@) {
IMO either both "/" or none needs to be escaped, or ?
--
MfG/Sincerely
Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: checkpatch.pl: never finishes w/ specific file
2011-03-21 10:42 ` Toralf Förster
@ 2011-03-21 23:46 ` Andy Whitcroft
0 siblings, 0 replies; 6+ messages in thread
From: Andy Whitcroft @ 2011-03-21 23:46 UTC (permalink / raw)
To: Toralf Förster; +Cc: akpm, linux-kernel
On Mon, Mar 21, 2011 at 11:42:10AM +0100, Toralf Förster wrote:
>
> Andy Whitcroft wrote at 12:47:52
> > Could you try your file with the one below and let me know:
> >
> >
> > http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl
>
> I've a question about line 1365 :
> if ($realfile =~ m@^include/asm\/@) {
>
> IMO either both "/" or none needs to be escaped, or ?
None as we are using '@' as the separator, however the extra \ is
benign.
-apw
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-21 23:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-03-02 16:31 checkpatch.pl: never finishes w/ specific file Toralf Förster
2011-03-04 4:07 ` Jovi Zhang
2011-03-16 11:47 ` Andy Whitcroft
2011-03-16 12:16 ` Toralf Förster
2011-03-21 10:42 ` Toralf Förster
2011-03-21 23:46 ` Andy Whitcroft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).