* [PATCH] fsldma: fix build warning caused by of_platform_device changes
@ 2011-04-07 17:33 Ira W. Snyder
2011-04-11 6:36 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Ira W. Snyder @ 2011-04-07 17:33 UTC (permalink / raw)
To: linux-kernel; +Cc: Ira W. Snyder, Grant Likely, Dan Williams
Commit 000061245a6797d542854106463b6b20fbdcb12e forgot to convert the
type of structure passed into platform_device_register() when it was
converted from of_platform_device_register. Fix it.
Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Dan Williams <dan.j.williams@intel.com>
---
drivers/dma/fsldma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 6b39675..8a78154 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -1448,7 +1448,7 @@ static const struct of_device_id fsldma_of_ids[] = {
{}
};
-static struct of_platform_driver fsldma_of_driver = {
+static struct platform_driver fsldma_of_driver = {
.driver = {
.name = "fsl-elo-dma",
.owner = THIS_MODULE,
--
1.7.3.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fsldma: fix build warning caused by of_platform_device changes
2011-04-07 17:33 [PATCH] fsldma: fix build warning caused by of_platform_device changes Ira W. Snyder
@ 2011-04-11 6:36 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2011-04-11 6:36 UTC (permalink / raw)
To: Ira W. Snyder; +Cc: linux-kernel, Dan Williams
On Thu, Apr 07, 2011 at 10:33:03AM -0700, Ira W. Snyder wrote:
> Commit 000061245a6797d542854106463b6b20fbdcb12e forgot to convert the
> type of structure passed into platform_device_register() when it was
> converted from of_platform_device_register. Fix it.
>
> Signed-off-by: Ira W. Snyder <iws@ovro.caltech.edu>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Dan Williams <dan.j.williams@intel.com>
Applied thanks.
One comment however; when quoting sha1 commit id's, please also quote
the title of the patch. Very few people I know can remember off the
top of their head the commit names that goes with a sha1 id. :-)
g.
> ---
> drivers/dma/fsldma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> index 6b39675..8a78154 100644
> --- a/drivers/dma/fsldma.c
> +++ b/drivers/dma/fsldma.c
> @@ -1448,7 +1448,7 @@ static const struct of_device_id fsldma_of_ids[] = {
> {}
> };
>
> -static struct of_platform_driver fsldma_of_driver = {
> +static struct platform_driver fsldma_of_driver = {
> .driver = {
> .name = "fsl-elo-dma",
> .owner = THIS_MODULE,
> --
> 1.7.3.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-11 6:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-07 17:33 [PATCH] fsldma: fix build warning caused by of_platform_device changes Ira W. Snyder
2011-04-11 6:36 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).