linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] irq: catch more wrong return values from interrupt handlers
Date: Tue, 31 May 2011 14:59:02 +0200	[thread overview]
Message-ID: <20110531125902.GA13217@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <alpine.LFD.2.02.1105311231150.3078@ionos>

* Thomas Gleixner | 2011-05-31 12:32:58 [+0200]:

>On Tue, 31 May 2011, Sebastian Andrzej Siewior wrote:
>
>> We now also accept return value IRQ_WAKE_THREAD from a threaded
>> interrupt or IRQ_HANDLED | IRQ_WAKE_THREAD from primary and theaded
>> handler which is wrong. We need to accept the later on shared handlers
>> where one handler is primary only and the second is a threaded handler.
>> This patch attempts to catch them. Unfortunately this patch introduces
>> two new types so I'm not sure if it is worth it.
>
>I'd rather avoid that ugliness. If driver writers are that stupid,
>there is probably more significant wreckage than this.

Sure. It is just that the "old" code ensured that either NONE or HANDLED
is returned and nothing else and the previous patch broke that check.
This patch just points it out :)
Do you want bad_action_ret() removed or kept as it?

>Thanks,
>
>	tglx

Sebastian

  reply	other threads:[~2011-05-31 12:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31  6:56 [PATCH 1/3] irq/spurious: dump also the name of the threaded handler Sebastian Andrzej Siewior
2011-05-31  6:56 ` [PATCH 2/3] irq: handle spurios irq detection for threaded irqs Sebastian Andrzej Siewior
2011-05-31 10:35   ` Thomas Gleixner
2011-06-01  6:33     ` [PATCH v2] " Sebastian Andrzej Siewior
2011-06-03 12:58   ` [tip:irq/urgent] irq: Handle " tip-bot for Sebastian Andrzej Siewior
2011-05-31  6:56 ` [PATCH 3/3] irq: catch more wrong return values from interrupt handlers Sebastian Andrzej Siewior
2011-05-31 10:32   ` Thomas Gleixner
2011-05-31 12:59     ` Sebastian Andrzej Siewior [this message]
2011-06-03 12:57 ` [tip:irq/urgent] genirq: Print threaded handler in spurious debug output tip-bot for Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110531125902.GA13217@Chamillionaire.breakpoint.cc \
    --to=sebastian@breakpoint.cc \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).