linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] irq: handle spurios irq detection for threaded irqs
Date: Tue, 31 May 2011 12:35:14 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.02.1105311233020.3078@ionos> (raw)
In-Reply-To: <1306824972-27067-2-git-send-email-sebastian@breakpoint.cc>

On Tue, 31 May 2011, Sebastian Andrzej Siewior wrote:
>  			raw_spin_unlock_irq(&desc->lock);
> -			handler_fn(desc, action);
> +			action_ret = handler_fn(desc, action);
> +			if (!noirqdebug) {
> +				raw_spin_lock_irq(&desc->lock);

Hmm. This will deadlock in __report_bad_irq().

> +				note_interrupt(action->irq, desc, action_ret);
> +				raw_spin_unlock_irq(&desc->lock);
> +			}

Thanks,

	tglx

  reply	other threads:[~2011-05-31 10:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-31  6:56 [PATCH 1/3] irq/spurious: dump also the name of the threaded handler Sebastian Andrzej Siewior
2011-05-31  6:56 ` [PATCH 2/3] irq: handle spurios irq detection for threaded irqs Sebastian Andrzej Siewior
2011-05-31 10:35   ` Thomas Gleixner [this message]
2011-06-01  6:33     ` [PATCH v2] " Sebastian Andrzej Siewior
2011-06-03 12:58   ` [tip:irq/urgent] irq: Handle " tip-bot for Sebastian Andrzej Siewior
2011-05-31  6:56 ` [PATCH 3/3] irq: catch more wrong return values from interrupt handlers Sebastian Andrzej Siewior
2011-05-31 10:32   ` Thomas Gleixner
2011-05-31 12:59     ` Sebastian Andrzej Siewior
2011-06-03 12:57 ` [tip:irq/urgent] genirq: Print threaded handler in spurious debug output tip-bot for Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1105311233020.3078@ionos \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).