* [PATCH]Remove a warning for drivers/edac/i82975x_edac.c
@ 2011-06-04 2:22 Harry Wei
2011-06-06 20:36 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Harry Wei @ 2011-06-04 2:22 UTC (permalink / raw)
To: linux-kernel; +Cc: ravi, arvino55, bluesmoke-devel, greg, akpm
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 1200 bytes --]
From: Harry Wei <harryxiyou@gmail.com>
When i compile 2.6.39.1, a warning shows like below.
This patch can fix the warning. And i works well with
my PC.
[...]
CC [M] drivers/edac/e752x_edac.o
CC [M] drivers/edac/i82875p_edac.o
CC [M] drivers/edac/i82975x_edac.o
drivers/edac/i82975x_edac.c: In function ���i82975x_process_error_info���:
drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for ���unsigned long��� type
CC [M] drivers/edac/i3000_edac.o
CC [M] drivers/edac/i3200_edac.o
CC [M] drivers/edac/x38_edac.o
CC [M] drivers/edac/i82860_edac.o
[...]
Signed-off-by: Harry Wei <harryxiyou@gmail.com>
Index: prj/drivers/edac/i82975x_edac.c
===================================================================
--- prj.orig/drivers/edac/i82975x_edac.c 2011-06-04 10:09:55.351174516 +0800
+++ prj/drivers/edac/i82975x_edac.c 2011-06-04 10:10:30.875168437 +0800
@@ -293,9 +293,9 @@
info->errsts = info->errsts2;
}
- page = (unsigned long) info->eap;
+ page = (unsigned long long) info->eap;
if (info->xeap & 1)
- page |= 0x100000000ul;
+ page |= 0x100000000ull;
chan = page & 1;
page >>= 1;
offst = page & ((1 << PAGE_SHIFT) - 1);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]Remove a warning for drivers/edac/i82975x_edac.c
2011-06-04 2:22 [PATCH]Remove a warning for drivers/edac/i82975x_edac.c Harry Wei
@ 2011-06-06 20:36 ` Randy Dunlap
2011-06-07 1:12 ` Harry Wei
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2011-06-06 20:36 UTC (permalink / raw)
To: Harry Wei; +Cc: linux-kernel, ravi, arvino55, bluesmoke-devel, greg, akpm
On Sat, 4 Jun 2011 10:22:21 +0800 Harry Wei wrote:
> From: Harry Wei <harryxiyou@gmail.com>
>
> When i compile 2.6.39.1, a warning shows like below.
> This patch can fix the warning. And i works well with
> my PC.
Hi Harry,
Does "works well with my PC" mean that you boot-tested this patch
or just compile-tested it?
and if you boot-tested it, do you have hardware that actually
exercises this code path?
> [...]
> CC [M] drivers/edac/e752x_edac.o
> CC [M] drivers/edac/i82875p_edac.o
> CC [M] drivers/edac/i82975x_edac.o
> drivers/edac/i82975x_edac.c: In function ���i82975x_process_error_info���:
> drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for ���unsigned long��� type
> CC [M] drivers/edac/i3000_edac.o
> CC [M] drivers/edac/i3200_edac.o
> CC [M] drivers/edac/x38_edac.o
> CC [M] drivers/edac/i82860_edac.o
> [...]
>
> Signed-off-by: Harry Wei <harryxiyou@gmail.com>
>
> Index: prj/drivers/edac/i82975x_edac.c
> ===================================================================
> --- prj.orig/drivers/edac/i82975x_edac.c 2011-06-04 10:09:55.351174516 +0800
> +++ prj/drivers/edac/i82975x_edac.c 2011-06-04 10:10:30.875168437 +0800
> @@ -293,9 +293,9 @@
> info->errsts = info->errsts2;
> }
>
> - page = (unsigned long) info->eap;
> + page = (unsigned long long) info->eap;
but page is still declared as unsigned long. should it be unsigned long long?
> if (info->xeap & 1)
> - page |= 0x100000000ul;
> + page |= 0x100000000ull;
> chan = page & 1;
> page >>= 1;
> offst = page & ((1 << PAGE_SHIFT) - 1);
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]Remove a warning for drivers/edac/i82975x_edac.c
2011-06-06 20:36 ` Randy Dunlap
@ 2011-06-07 1:12 ` Harry Wei
0 siblings, 0 replies; 3+ messages in thread
From: Harry Wei @ 2011-06-07 1:12 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linux-kernel
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 2460 bytes --]
On Mon, Jun 06, 2011 at 01:36:52PM -0700, Randy Dunlap wrote:
> On Sat, 4 Jun 2011 10:22:21 +0800 Harry Wei wrote:
>
> > From: Harry Wei <harryxiyou@gmail.com>
> >
> > When i compile 2.6.39.1, a warning shows like below.
> > This patch can fix the warning. And i works well with
> > my PC.
>
> Hi Harry,
>
> Does "works well with my PC" mean that you boot-tested this patch
> or just compile-tested it?
No, i just test with the following codes.
#include <stdio.h>
int main(void)
{
unsigned long a;
a = 0x100000000ul;
printf("%lu\n", a);
return 0;
}
jiawei@jiawei-laptop:~/GTK$ gcc 5.c -Wall -o 1
5.c: In function ‘main’:
5.c:7: warning: integer constant is too large for ‘unsigned long’ type
5.c:7: warning: large integer implicitly truncated to unsigned type
But if you program it like below, it is well for us.
#include <stdio.h>
int main(void)
{
unsigned long long a;
a = 0x100000000ull;
printf("%llu\n", a);
return 0;
}
>
> and if you boot-tested it, do you have hardware that actually
> exercises this code path?
>
> > [...]
> > CC [M] drivers/edac/e752x_edac.o
> > CC [M] drivers/edac/i82875p_edac.o
> > CC [M] drivers/edac/i82975x_edac.o
> > drivers/edac/i82975x_edac.c: In function ?????????i82975x_process_error_info?????????:
> > drivers/edac/i82975x_edac.c:298: warning: integer constant is too large for ?????????unsigned long????????? type
> > CC [M] drivers/edac/i3000_edac.o
> > CC [M] drivers/edac/i3200_edac.o
> > CC [M] drivers/edac/x38_edac.o
> > CC [M] drivers/edac/i82860_edac.o
> > [...]
> >
> > Signed-off-by: Harry Wei <harryxiyou@gmail.com>
> >
> > Index: prj/drivers/edac/i82975x_edac.c
> > ===================================================================
> > --- prj.orig/drivers/edac/i82975x_edac.c 2011-06-04 10:09:55.351174516 +0800
> > +++ prj/drivers/edac/i82975x_edac.c 2011-06-04 10:10:30.875168437 +0800
> > @@ -293,9 +293,9 @@
> > info->errsts = info->errsts2;
> > }
> >
> > - page = (unsigned long) info->eap;
> > + page = (unsigned long long) info->eap;
>
> but page is still declared as unsigned long. should it be unsigned long long?
I think it should be unsigned long long, unsigned long can not store
0x100000000. It has been beyond its reach. So unsigned long long is
well for us.
>
> > if (info->xeap & 1)
> > - page |= 0x100000000ul;
> > + page |= 0x100000000ull;
> > chan = page & 1;
> > page >>= 1;
> > offst = page & ((1 << PAGE_SHIFT) - 1);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-07 1:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-04 2:22 [PATCH]Remove a warning for drivers/edac/i82975x_edac.c Harry Wei
2011-06-06 20:36 ` Randy Dunlap
2011-06-07 1:12 ` Harry Wei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).