From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Don Zickus <dzickus@redhat.com>
Cc: Stephane Eranian <eranian@google.com>,
Ingo Molnar <mingo@redhat.com>, Lin Ming <ming.m.lin@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf, x86: Add hw_watchdog_set_attr() in a sake of nmi-watchdog on P4
Date: Mon, 27 Jun 2011 23:32:01 +0400 [thread overview]
Message-ID: <20110627193201.GB1159@sun> (raw)
In-Reply-To: <20110627190358.GQ3765@redhat.com>
On Mon, Jun 27, 2011 at 03:03:58PM -0400, Don Zickus wrote:
...
>
> > Index: linux-2.6.git/kernel/watchdog.c
> > ===================================================================
> > --- linux-2.6.git.orig/kernel/watchdog.c
> > +++ linux-2.6.git/kernel/watchdog.c
> > @@ -200,6 +200,8 @@ static int is_softlockup(unsigned long t
> > }
> >
> > #ifdef CONFIG_HARDLOCKUP_DETECTOR
> > +void __weak hw_nmi_watchdog_set_attr(struct perf_event_attr *wd_attr) { }
> > +
>
> Though I do wonder about this call in the watchdog. I thought it might be
> better elsewhere but not sure where.
Yeah, not the _best_ place. Not sure too where to put it, patches are welcome ;)
>
> Cheers,
> Don
Cyrill
next prev parent reply other threads:[~2011-06-28 15:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 12:49 [PATCH] perf, x86: Add hw_watchdog_set_attr() in a sake of nmi-watchdog on P4 Cyrill Gorcunov
2011-06-27 19:03 ` Don Zickus
2011-06-27 19:06 ` Stephane Eranian
2011-06-27 19:21 ` Peter Zijlstra
2011-06-27 19:30 ` Cyrill Gorcunov
2011-06-27 19:32 ` Cyrill Gorcunov [this message]
2011-06-28 15:24 ` Stephane Eranian
2011-06-28 15:28 ` Cyrill Gorcunov
2011-06-28 15:32 ` Stephane Eranian
2011-06-28 15:40 ` Cyrill Gorcunov
2011-06-28 15:56 ` Cyrill Gorcunov
2011-06-28 15:37 ` Don Zickus
2011-06-28 15:44 ` Cyrill Gorcunov
2011-06-28 15:46 ` Cyrill Gorcunov
2011-06-28 15:53 ` Stephane Eranian
2011-06-28 16:11 ` Cyrill Gorcunov
2011-06-28 16:27 ` Don Zickus
2011-06-28 16:42 ` Cyrill Gorcunov
2011-07-01 15:20 ` [tip:perf/core] " tip-bot for Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110627193201.GB1159@sun \
--to=gorcunov@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).