From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Stephane Eranian <eranian@google.com>
Cc: Don Zickus <dzickus@redhat.com>, Ingo Molnar <mingo@redhat.com>,
Lin Ming <ming.m.lin@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf, x86: Add hw_watchdog_set_attr() in a sake of nmi-watchdog on P4
Date: Tue, 28 Jun 2011 20:11:10 +0400 [thread overview]
Message-ID: <20110628161110.GJ1159@sun> (raw)
In-Reply-To: <CABPqkBS4ukQ-asVD68MR_Bb_E89+EcHOcMP3Vv=RMJ9RnuYBSw@mail.gmail.com>
On Tue, Jun 28, 2011 at 05:53:31PM +0200, Stephane Eranian wrote:
> Cyrill,
>
> #ifdef CONFIG_HARDLOCKUP_DETECTOR
> +void __weak hw_nmi_watchdog_set_attr(struct perf_event_attr *wd_attr) { }
>
> The weak function has to remain inside the #ifdef. Remember it's just an
> override in case you cannot using the generic cycle event. It is only needed
> when you have the HARDLOCK detector, i.e., are using the PMU to detect
> deadlocks.
>
> I suspect P4 may be the only one so far which exhibited a problem there.
>
heh ;) Guys, maybe we're talking about different things? Don, when you said
"Though I do wonder about this call in the watchdog" you meant the
wd_attr->sample_period = hw_nmi_get_sample_period(watchdog_thresh);
--> hw_nmi_watchdog_set_attr(wd_attr);
itself? Ie you suspect some different point where to call it?
When I said not a "best place" I meant about __weak function bare implementation
placed that near to call (which is looked somehow suspicious for me from overall
code structure), but I didn't mean the call sequence itself ;)
Cyrill
next prev parent reply other threads:[~2011-06-28 16:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 12:49 [PATCH] perf, x86: Add hw_watchdog_set_attr() in a sake of nmi-watchdog on P4 Cyrill Gorcunov
2011-06-27 19:03 ` Don Zickus
2011-06-27 19:06 ` Stephane Eranian
2011-06-27 19:21 ` Peter Zijlstra
2011-06-27 19:30 ` Cyrill Gorcunov
2011-06-27 19:32 ` Cyrill Gorcunov
2011-06-28 15:24 ` Stephane Eranian
2011-06-28 15:28 ` Cyrill Gorcunov
2011-06-28 15:32 ` Stephane Eranian
2011-06-28 15:40 ` Cyrill Gorcunov
2011-06-28 15:56 ` Cyrill Gorcunov
2011-06-28 15:37 ` Don Zickus
2011-06-28 15:44 ` Cyrill Gorcunov
2011-06-28 15:46 ` Cyrill Gorcunov
2011-06-28 15:53 ` Stephane Eranian
2011-06-28 16:11 ` Cyrill Gorcunov [this message]
2011-06-28 16:27 ` Don Zickus
2011-06-28 16:42 ` Cyrill Gorcunov
2011-07-01 15:20 ` [tip:perf/core] " tip-bot for Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110628161110.GJ1159@sun \
--to=gorcunov@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=dzickus@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).