From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: linux-next: build failure after merge of the final tree (net tree related)
Date: Wed, 29 Jun 2011 16:09:01 +1000 [thread overview]
Message-ID: <20110629160901.2d3cd6da.sfr@canb.auug.org.au> (raw)
In-Reply-To: <20110627152927.943c34dc.sfr@canb.auug.org.au>
Hi all,
On Mon, 27 Jun 2011 15:29:27 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> On Thu, 23 Jun 2011 16:04:13 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> >
> > On Thu, Jun 23, 2011 at 8:29 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> >
> > I build on all powerpc defconfigs, somehow this driver is not pinned
> > by any of them :^)
>
> Well, yes, but an allmodconfig or allyesconfig build will get the error.
>
> > > drivers/net/ll_temac_main.c:209:4: error: implicit declaration of function 'dma_unmap_single'
>
> Is there a fix?
Again, this has taken some time to fix ...
Dave, I think you have raised my expectations too far ;-)
I have added the following patch for today:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 29 Jun 2011 16:03:18 +1000
Subject: [PATCH] net: include dma-mapping.h for dma_map_single etc
fixes thses build errors:
drivers/net/ll_temac_main.c: In function 'temac_dma_bd_release':
drivers/net/ll_temac_main.c:209:4: error: implicit declaration of function 'dma_unmap_single'
drivers/net/ll_temac_main.c:215:3: error: implicit declaration of function 'dma_free_coherent'
drivers/net/ll_temac_main.c: In function 'temac_dma_bd_init':
drivers/net/ll_temac_main.c:243:2: error: implicit declaration of function 'dma_alloc_coherent'
drivers/net/ll_temac_main.c:243:14: warning: assignment makes pointer from integer without a cast
drivers/net/ll_temac_main.c:251:14: warning: assignment makes pointer from integer without a cast
drivers/net/ll_temac_main.c:280:3: error: implicit declaration of function 'dma_map_single'
drivers/net/ll_temac_main.c: In function 'temac_start_xmit_done':
drivers/net/ll_temac_main.c:628:22: warning: cast to pointer from integer of different size
Caused by commit commit b7f080cfe223 ("net: remove mm.h inclusion from
netdevice.h").
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
drivers/net/ll_temac_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ll_temac_main.c b/drivers/net/ll_temac_main.c
index e3f1925..728fe41 100644
--- a/drivers/net/ll_temac_main.c
+++ b/drivers/net/ll_temac_main.c
@@ -49,6 +49,7 @@
#include <linux/ip.h>
#include <linux/slab.h>
#include <linux/interrupt.h>
+#include <linux/dma-mapping.h>
#include "ll_temac.h"
--
1.7.5.4
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
next prev parent reply other threads:[~2011-06-29 6:09 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-23 5:29 linux-next: build failure after merge of the final tree (net tree related) Stephen Rothwell
2011-06-23 13:04 ` Alexey Dobriyan
2011-06-27 5:29 ` Stephen Rothwell
2011-06-29 6:09 ` Stephen Rothwell [this message]
2011-06-29 9:58 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2012-01-09 5:38 Stephen Rothwell
2012-01-09 6:52 ` David Miller
2012-01-16 7:36 ` Glauber Costa
2011-12-22 6:07 Stephen Rothwell
2011-12-22 6:16 ` Eric Dumazet
2011-12-22 7:01 ` David Miller
2011-11-02 5:37 Stephen Rothwell
2011-11-02 5:50 ` David Miller
2011-08-15 5:20 Stephen Rothwell
2011-08-15 5:56 ` David Miller
2011-08-16 5:28 ` Stephen Rothwell
2011-08-16 6:11 ` David Miller
2011-08-16 6:57 ` Stephen Rothwell
2011-08-16 7:17 ` David Miller
2011-06-23 5:25 Stephen Rothwell
2011-06-27 5:35 ` Stephen Rothwell
2011-06-29 6:01 ` Stephen Rothwell
2011-06-29 9:56 ` David Miller
2011-06-08 5:54 Stephen Rothwell
2011-06-08 7:16 ` David Miller
2011-04-21 22:10 Stephen Rothwell
2011-04-21 22:19 ` David Miller
2011-02-03 4:13 Stephen Rothwell
2011-02-03 4:46 ` David Miller
2011-02-03 5:14 ` Stephen Rothwell
2010-11-15 0:46 Stephen Rothwell
2010-11-15 16:52 ` David Miller
2010-11-15 16:58 ` Eric Dumazet
2010-10-18 7:36 Stephen Rothwell
2010-10-18 8:06 ` David Miller
2010-09-27 5:44 Stephen Rothwell
2010-09-27 8:17 ` David Miller
2010-09-27 15:55 ` Ohad Ben-Cohen
2010-09-27 18:04 ` John W. Linville
2010-09-27 18:18 ` David Miller
2010-09-27 18:25 ` John W. Linville
2010-09-27 18:38 ` Ohad Ben-Cohen
2010-09-27 18:44 ` John W. Linville
2010-09-27 19:01 ` Ohad Ben-Cohen
2010-09-27 19:06 ` Ohad Ben-Cohen
2010-09-27 19:44 ` John W. Linville
2010-09-27 20:18 ` Ohad Ben-Cohen
2010-09-03 1:47 Stephen Rothwell
2010-09-03 1:52 ` Stephen Rothwell
2010-09-03 2:16 ` David Miller
2010-09-03 2:14 ` David Miller
2010-08-31 3:18 Stephen Rothwell
2010-08-31 4:43 ` David Miller
2010-08-30 3:04 Stephen Rothwell
2010-08-30 3:29 ` Simon Horman
2010-08-30 4:23 ` David Miller
2010-08-25 2:09 Stephen Rothwell
2010-08-25 4:22 ` Rasesh Mody
2010-08-25 7:35 ` David Miller
2010-08-25 20:59 ` David Miller
2010-08-25 21:53 ` Rasesh Mody
2010-08-26 1:05 ` Stephen Rothwell
2010-08-23 3:27 Stephen Rothwell
2010-08-23 3:31 ` David Miller
2010-07-29 4:13 Stephen Rothwell
2010-07-29 5:21 ` David Miller
2010-04-27 5:25 Stephen Rothwell
2010-04-27 16:34 ` David Miller
2010-04-27 17:18 ` David Miller
2010-04-28 1:11 ` Stephen Rothwell
2010-03-29 6:43 Stephen Rothwell
2010-03-29 6:52 ` Eric Dumazet
2010-03-29 6:59 ` Eric Dumazet
2010-03-29 8:01 ` David Miller
2010-03-29 8:04 ` Stephen Rothwell
2010-03-29 7:01 ` Stephen Rothwell
2010-03-18 4:23 Stephen Rothwell
2010-03-18 6:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110629160901.2d3cd6da.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).