From: Glauber Costa <glommer@parallels.com>
To: David Miller <davem@davemloft.net>
Cc: <sfr@canb.auug.org.au>, <netdev@vger.kernel.org>,
<linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the final tree (net tree related)
Date: Mon, 16 Jan 2012 11:36:22 +0400 [thread overview]
Message-ID: <4F13D376.7020500@parallels.com> (raw)
In-Reply-To: <20120108.225225.1735038078666958154.davem@davemloft.net>
On 01/09/2012 10:52 AM, David Miller wrote:
> From: Stephen Rothwell<sfr@canb.auug.org.au>
> Date: Mon, 9 Jan 2012 16:38:12 +1100
>
>> I applied the following patch for today:
>>
>> From: Stephen Rothwell<sfr@canb.auug.org.au>
>> Date: Mon, 9 Jan 2012 16:33:16 +1100
>> Subject: [PATCH] net: sk_update_clone is only used in net/core/sock.c
>>
>> so move it there. Fixes build errors when CONFIG_INET is not defeined:
>>
>> In file included from include/linux/tcp.h:211:0,
>> from include/linux/ipv6.h:221,
>> from include/net/ipv6.h:16,
>> from include/linux/sunrpc/clnt.h:26,
>> from include/linux/nfs_fs.h:50,
>> from init/do_mounts.c:20:
>> include/net/sock.h: In function 'sk_update_clone':
>> include/net/sock.h:1109:3: error: implicit declaration of function 'sock_update_memcg' [-Werror=implicit-function-declaration]
>>
>> Signed-off-by: Stephen Rothwell<sfr@canb.auug.org.au>
>
> Applied, thanks Stephen.
This is not the proper fix.
Although it can stay for a matter of style if you guys prefer the inline
function definition to live in sock.c since no one else uses it.
I'll send a patch to fix this, that can live ontop of yours, shortly.
next prev parent reply other threads:[~2012-01-16 7:37 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 5:38 linux-next: build failure after merge of the final tree (net tree related) Stephen Rothwell
2012-01-09 6:52 ` David Miller
2012-01-16 7:36 ` Glauber Costa [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-22 6:07 Stephen Rothwell
2011-12-22 6:16 ` Eric Dumazet
2011-12-22 7:01 ` David Miller
2011-11-02 5:37 Stephen Rothwell
2011-11-02 5:50 ` David Miller
2011-08-15 5:20 Stephen Rothwell
2011-08-15 5:56 ` David Miller
2011-08-16 5:28 ` Stephen Rothwell
2011-08-16 6:11 ` David Miller
2011-08-16 6:57 ` Stephen Rothwell
2011-08-16 7:17 ` David Miller
2011-06-23 5:29 Stephen Rothwell
2011-06-23 13:04 ` Alexey Dobriyan
2011-06-27 5:29 ` Stephen Rothwell
2011-06-29 6:09 ` Stephen Rothwell
2011-06-29 9:58 ` David Miller
2011-06-23 5:25 Stephen Rothwell
2011-06-27 5:35 ` Stephen Rothwell
2011-06-29 6:01 ` Stephen Rothwell
2011-06-29 9:56 ` David Miller
2011-06-08 5:54 Stephen Rothwell
2011-06-08 7:16 ` David Miller
2011-04-21 22:10 Stephen Rothwell
2011-04-21 22:19 ` David Miller
2011-02-03 4:13 Stephen Rothwell
2011-02-03 4:46 ` David Miller
2011-02-03 5:14 ` Stephen Rothwell
2010-11-15 0:46 Stephen Rothwell
2010-11-15 16:52 ` David Miller
2010-11-15 16:58 ` Eric Dumazet
2010-10-18 7:36 Stephen Rothwell
2010-10-18 8:06 ` David Miller
2010-09-27 5:44 Stephen Rothwell
2010-09-27 8:17 ` David Miller
2010-09-27 15:55 ` Ohad Ben-Cohen
2010-09-27 18:04 ` John W. Linville
2010-09-27 18:18 ` David Miller
2010-09-27 18:25 ` John W. Linville
2010-09-27 18:38 ` Ohad Ben-Cohen
2010-09-27 18:44 ` John W. Linville
2010-09-27 19:01 ` Ohad Ben-Cohen
2010-09-27 19:06 ` Ohad Ben-Cohen
2010-09-27 19:44 ` John W. Linville
2010-09-27 20:18 ` Ohad Ben-Cohen
2010-09-03 1:47 Stephen Rothwell
2010-09-03 1:52 ` Stephen Rothwell
2010-09-03 2:16 ` David Miller
2010-09-03 2:14 ` David Miller
2010-08-31 3:18 Stephen Rothwell
2010-08-31 4:43 ` David Miller
2010-08-30 3:04 Stephen Rothwell
2010-08-30 3:29 ` Simon Horman
2010-08-30 4:23 ` David Miller
2010-08-25 2:09 Stephen Rothwell
2010-08-25 4:22 ` Rasesh Mody
2010-08-25 7:35 ` David Miller
2010-08-25 20:59 ` David Miller
2010-08-25 21:53 ` Rasesh Mody
2010-08-26 1:05 ` Stephen Rothwell
2010-08-23 3:27 Stephen Rothwell
2010-08-23 3:31 ` David Miller
2010-07-29 4:13 Stephen Rothwell
2010-07-29 5:21 ` David Miller
2010-04-27 5:25 Stephen Rothwell
2010-04-27 16:34 ` David Miller
2010-04-27 17:18 ` David Miller
2010-04-28 1:11 ` Stephen Rothwell
2010-03-29 6:43 Stephen Rothwell
2010-03-29 6:52 ` Eric Dumazet
2010-03-29 6:59 ` Eric Dumazet
2010-03-29 8:01 ` David Miller
2010-03-29 8:04 ` Stephen Rothwell
2010-03-29 7:01 ` Stephen Rothwell
2010-03-18 4:23 Stephen Rothwell
2010-03-18 6:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F13D376.7020500@parallels.com \
--to=glommer@parallels.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).