* [patch] regulator/tps65912: storing error codes in u8
@ 2011-06-23 5:57 Dan Carpenter
2011-06-23 10:35 ` Mark Brown
2011-07-04 16:06 ` Liam Girdwood
0 siblings, 2 replies; 6+ messages in thread
From: Dan Carpenter @ 2011-06-23 5:57 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Mark Brown, open list, kernel-janitors
get_ctrl_reg() returns -EINVAL so the error handling won't work here
if reg is a u8.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c
index d2c6542..3a9313e 100644
--- a/drivers/regulator/tps65912-regulator.c
+++ b/drivers/regulator/tps65912-regulator.c
@@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev)
struct tps65912_reg *pmic = rdev_get_drvdata(dev);
struct tps65912 *mfd = pmic->mfd;
int id = rdev_get_id(dev);
- u8 reg;
+ int reg;
if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10)
return -EINVAL;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] regulator/tps65912: storing error codes in u8
2011-06-23 5:57 [patch] regulator/tps65912: storing error codes in u8 Dan Carpenter
@ 2011-06-23 10:35 ` Mark Brown
2011-07-04 16:06 ` Liam Girdwood
1 sibling, 0 replies; 6+ messages in thread
From: Mark Brown @ 2011-06-23 10:35 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Liam Girdwood, open list, kernel-janitors
On Thu, Jun 23, 2011 at 08:57:15AM +0300, Dan Carpenter wrote:
> get_ctrl_reg() returns -EINVAL so the error handling won't work here
> if reg is a u8.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] regulator/tps65912: storing error codes in u8
2011-06-23 5:57 [patch] regulator/tps65912: storing error codes in u8 Dan Carpenter
2011-06-23 10:35 ` Mark Brown
@ 2011-07-04 16:06 ` Liam Girdwood
2011-07-06 18:32 ` Samuel Ortiz
1 sibling, 1 reply; 6+ messages in thread
From: Liam Girdwood @ 2011-07-04 16:06 UTC (permalink / raw)
To: Dan Carpenter, Samuel Ortiz
Cc: Liam Girdwood, Mark Brown, open list, kernel-janitors
On Thu, 2011-06-23 at 08:57 +0300, Dan Carpenter wrote:
> get_ctrl_reg() returns -EINVAL so the error handling won't work here
> if reg is a u8.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c
> index d2c6542..3a9313e 100644
> --- a/drivers/regulator/tps65912-regulator.c
> +++ b/drivers/regulator/tps65912-regulator.c
> @@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev)
> struct tps65912_reg *pmic = rdev_get_drvdata(dev);
> struct tps65912 *mfd = pmic->mfd;
> int id = rdev_get_id(dev);
> - u8 reg;
> + int reg;
>
> if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10)
> return -EINVAL;
Samuel, would you mind taking this since tps65912 is upstreaming via
mfd.
Thanks !
Liam
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch] regulator/tps65912: storing error codes in u8
2011-07-04 16:06 ` Liam Girdwood
@ 2011-07-06 18:32 ` Samuel Ortiz
2011-07-06 18:57 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Samuel Ortiz @ 2011-07-06 18:32 UTC (permalink / raw)
To: Liam Girdwood
Cc: Dan Carpenter, Liam Girdwood, Mark Brown, open list, kernel-janitors
Hi Liam,
On Mon, Jul 04, 2011 at 05:06:58PM +0100, Liam Girdwood wrote:
> On Thu, 2011-06-23 at 08:57 +0300, Dan Carpenter wrote:
> > get_ctrl_reg() returns -EINVAL so the error handling won't work here
> > if reg is a u8.
> >
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> >
> > diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c
> > index d2c6542..3a9313e 100644
> > --- a/drivers/regulator/tps65912-regulator.c
> > +++ b/drivers/regulator/tps65912-regulator.c
> > @@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev)
> > struct tps65912_reg *pmic = rdev_get_drvdata(dev);
> > struct tps65912 *mfd = pmic->mfd;
> > int id = rdev_get_id(dev);
> > - u8 reg;
> > + int reg;
> >
> > if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10)
> > return -EINVAL;
>
> Samuel, would you mind taking this since tps65912 is upstreaming via
> mfd.
Sure. Would you mind sending the patch to me ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [patch] regulator/tps65912: storing error codes in u8
2011-07-06 18:32 ` Samuel Ortiz
@ 2011-07-06 18:57 ` Dan Carpenter
2011-07-06 19:07 ` Samuel Ortiz
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2011-07-06 18:57 UTC (permalink / raw)
To: Samuel Ortiz
Cc: Liam Girdwood, Liam Girdwood, Mark Brown, open list, kernel-janitors
get_ctrl_reg() returns -EINVAL so the error handling won't work here
if reg is a u8.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Resent to Samuel Ortiz who wasn't CC'd the first time.
diff --git a/drivers/regulator/tps65912-regulator.c b/drivers/regulator/tps65912-regulator.c
index d2c6542..3a9313e 100644
--- a/drivers/regulator/tps65912-regulator.c
+++ b/drivers/regulator/tps65912-regulator.c
@@ -417,7 +417,7 @@ static int tps65912_reg_enable(struct regulator_dev *dev)
struct tps65912_reg *pmic = rdev_get_drvdata(dev);
struct tps65912 *mfd = pmic->mfd;
int id = rdev_get_id(dev);
- u8 reg;
+ int reg;
if (id < TPS65912_REG_DCDC1 || id > TPS65912_REG_LDO10)
return -EINVAL;
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch] regulator/tps65912: storing error codes in u8
2011-07-06 18:57 ` Dan Carpenter
@ 2011-07-06 19:07 ` Samuel Ortiz
0 siblings, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2011-07-06 19:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Liam Girdwood, Mark Brown, open list, kernel-janitors
Hi Dan,
On Wed, Jul 06, 2011 at 09:57:18PM +0300, Dan Carpenter wrote:
> get_ctrl_reg() returns -EINVAL so the error handling won't work here
> if reg is a u8.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Thanks, patch applied.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-06 19:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-23 5:57 [patch] regulator/tps65912: storing error codes in u8 Dan Carpenter
2011-06-23 10:35 ` Mark Brown
2011-07-04 16:06 ` Liam Girdwood
2011-07-06 18:32 ` Samuel Ortiz
2011-07-06 18:57 ` Dan Carpenter
2011-07-06 19:07 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).