linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpio: wm831x: add a missing break in wm831x_gpio_dbg_show
@ 2011-07-10  7:45 Axel Lin
  2011-07-10  8:35 ` Mark Brown
  2011-07-15 20:03 ` Grant Likely
  0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2011-07-10  7:45 UTC (permalink / raw)
  To: linux-kernel; +Cc: Mark Brown, Grant Likely

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/gpio/gpio-wm831x.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c
index 31a9ed7..deb949e 100644
--- a/drivers/gpio/gpio-wm831x.c
+++ b/drivers/gpio/gpio-wm831x.c
@@ -180,6 +180,7 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
 			break;
 		case WM831X_GPIO_PULL_UP:
 			pull = "pullup";
+			break;
 		default:
 			pull = "INVALID PULL";
 			break;
-- 
1.7.4.1




^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: wm831x: add a missing break in wm831x_gpio_dbg_show
  2011-07-10  7:45 [PATCH] gpio: wm831x: add a missing break in wm831x_gpio_dbg_show Axel Lin
@ 2011-07-10  8:35 ` Mark Brown
  2011-07-15 20:03 ` Grant Likely
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-07-10  8:35 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Grant Likely

On Sun, Jul 10, 2011 at 03:45:07PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: wm831x: add a missing break in wm831x_gpio_dbg_show
  2011-07-10  7:45 [PATCH] gpio: wm831x: add a missing break in wm831x_gpio_dbg_show Axel Lin
  2011-07-10  8:35 ` Mark Brown
@ 2011-07-15 20:03 ` Grant Likely
  1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2011-07-15 20:03 UTC (permalink / raw)
  To: Axel Lin; +Cc: linux-kernel, Mark Brown

On Sun, Jul 10, 2011 at 03:45:07PM +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Applied, thanks.

g.

> ---
>  drivers/gpio/gpio-wm831x.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-wm831x.c b/drivers/gpio/gpio-wm831x.c
> index 31a9ed7..deb949e 100644
> --- a/drivers/gpio/gpio-wm831x.c
> +++ b/drivers/gpio/gpio-wm831x.c
> @@ -180,6 +180,7 @@ static void wm831x_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
>  			break;
>  		case WM831X_GPIO_PULL_UP:
>  			pull = "pullup";
> +			break;
>  		default:
>  			pull = "INVALID PULL";
>  			break;
> -- 
> 1.7.4.1
> 
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-07-15 20:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-10  7:45 [PATCH] gpio: wm831x: add a missing break in wm831x_gpio_dbg_show Axel Lin
2011-07-10  8:35 ` Mark Brown
2011-07-15 20:03 ` Grant Likely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).