* [PATCH] sun4m SMP: fix wrong shift instruction in IPI handler
@ 2011-07-16 3:05 Will Simoneau
2011-07-16 17:46 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Will Simoneau @ 2011-07-16 3:05 UTC (permalink / raw)
To: davem; +Cc: linux-kernel
This shift instruction appears to be shifting in the wrong direction.
Without this change, my SparcStation-20MP hangs just after bringing up
the second CPU:
Entering SMP Mode...
Starting CPU 2 at f02b4e90
Brought up 2 CPUs
Total of 2 processors activated (99.52 BogoMIPS).
*** stuck ***
Signed-off-by: Will Simoneau <simoneau@ele.uri.edu>
---
arch/sparc/kernel/entry.S | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/sparc/kernel/entry.S b/arch/sparc/kernel/entry.S
index 9fe08a1..f445e98 100644
--- a/arch/sparc/kernel/entry.S
+++ b/arch/sparc/kernel/entry.S
@@ -293,7 +293,7 @@ maybe_smp4m_msg:
WRITE_PAUSE
wr %l4, PSR_ET, %psr
WRITE_PAUSE
- sll %o3, 28, %o2 ! shift for simpler checks below
+ srl %o3, 28, %o2 ! shift for simpler checks below
maybe_smp4m_msg_check_single:
andcc %o2, 0x1, %g0
beq,a maybe_smp4m_msg_check_mask
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sun4m SMP: fix wrong shift instruction in IPI handler
2011-07-16 3:05 [PATCH] sun4m SMP: fix wrong shift instruction in IPI handler Will Simoneau
@ 2011-07-16 17:46 ` David Miller
2011-07-16 17:49 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2011-07-16 17:46 UTC (permalink / raw)
To: simoneau; +Cc: linux-kernel
From: Will Simoneau <simoneau@ele.uri.edu>
Date: Fri, 15 Jul 2011 23:05:15 -0400
> This shift instruction appears to be shifting in the wrong direction.
> Without this change, my SparcStation-20MP hangs just after bringing up
> the second CPU:
>
> Entering SMP Mode...
> Starting CPU 2 at f02b4e90
> Brought up 2 CPUs
> Total of 2 processors activated (99.52 BogoMIPS).
> *** stuck ***
>
> Signed-off-by: Will Simoneau <simoneau@ele.uri.edu>
Applied, thanks a lot Will.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sun4m SMP: fix wrong shift instruction in IPI handler
2011-07-16 17:46 ` David Miller
@ 2011-07-16 17:49 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-07-16 17:49 UTC (permalink / raw)
To: simoneau; +Cc: linux-kernel
From: David Miller <davem@davemloft.net>
Date: Sat, 16 Jul 2011 10:46:36 -0700 (PDT)
> From: Will Simoneau <simoneau@ele.uri.edu>
> Date: Fri, 15 Jul 2011 23:05:15 -0400
>
>> This shift instruction appears to be shifting in the wrong direction.
>> Without this change, my SparcStation-20MP hangs just after bringing up
>> the second CPU:
>>
>> Entering SMP Mode...
>> Starting CPU 2 at f02b4e90
>> Brought up 2 CPUs
>> Total of 2 processors activated (99.52 BogoMIPS).
>> *** stuck ***
>>
>> Signed-off-by: Will Simoneau <simoneau@ele.uri.edu>
>
> Applied, thanks a lot Will.
BTW, in the future please post sparc patches to
sparclinux@vger.kernel.org so that they 1) go to the correct audience
and 2) get tracked properly at patchwork.ozlabs.org
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-16 17:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-16 3:05 [PATCH] sun4m SMP: fix wrong shift instruction in IPI handler Will Simoneau
2011-07-16 17:46 ` David Miller
2011-07-16 17:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).