linux-next: build failure after merge of the jdelvare-hwmon tree

linux-next: build failure after merge of the jdelvare-hwmon tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

Hi Jean,

After merging the jdelvare-hwmon tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/hwmon/max1111.c: In function 'max1111_remove':
drivers/hwmon/max1111.c:213:2: error: incompatible type for argument 1 of 'mutex_destroy'
include/linux/mutex-debug.h:21:13: note: expected 'struct mutex *' but argument is of type 'struct mutex'

Caused by commit d2fbca2996a8 ("hwmon: (max1111) Fix race condition
causing NULL pointer exception").  Missing '&'?

I have used the jdelvare-hwmon tree from next-20110707 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the jdelvare-hwmon tree

[Jean Delvare]

Hi Stephen,

On Sat, 16 Jul 2011 17:06:01 +1000, Stephen Rothwell wrote:
> After merging the jdelvare-hwmon tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/hwmon/max1111.c: In function 'max1111_remove':
> drivers/hwmon/max1111.c:213:2: error: incompatible type for argument 1 of 'mutex_destroy'
> include/linux/mutex-debug.h:21:13: note: expected 'struct mutex *' but argument is of type 'struct mutex'
> 
> Caused by commit d2fbca2996a8 ("hwmon: (max1111) Fix race condition
> causing NULL pointer exception").  Missing '&'?

Oh, right, good catch. It went unnoticed so far because mutex_destroy
resolves to nothing unless CONFIG_DEBUG_MUTEXES=y. I plan to submit a
patch turning the empty implementation of mutex_destroy to an inline
function, so that this kind of problem gets caught earlier.

> I have used the jdelvare-hwmon tree from next-20110707 for today.

Problem is fixed now, thanks.

-- 
Jean Delvare