From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Danny Huang <dahuang@nvidia.com>
Cc: "lrg@ti.com" <lrg@ti.com>,
"mike@compulab.co.il" <mike@compulab.co.il>,
"sameo@linux.intel.com" <sameo@linux.intel.com>,
Xin Xie <xxie@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: tps6586x: add SMx slew rate setting
Date: Mon, 8 Aug 2011 14:32:59 +0100 [thread overview]
Message-ID: <20110808133259.GA5719@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1BA5D2DFD2730747A2B3725B59933B93C07A475743@HKMAIL01.nvidia.com>
On Mon, Aug 08, 2011 at 08:28:30PM +0800, Danny Huang wrote:
> Zero is a valid setting for the regulator but not the default setting.
> The default setting is 0x07.
> This might affect the system stability under some particular condition.
> I thought that users should pick a proper setting before init.
It'd be good to do something like make the variable wider than the
register then require that users set an out of band bit to program the
value to zero. This would improve robustness in hte case where someone
relies on a zero initialized platform data by default.
next prev parent reply other threads:[~2011-08-08 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-04 11:34 [PATCH] regulator: tps6586x: add SMx slew rate setting dahuang
2011-08-04 12:12 ` Mark Brown
2011-08-05 11:51 ` Danny Huang
2011-08-08 9:37 ` Mark Brown
2011-08-08 12:28 ` Danny Huang
2011-08-08 13:32 ` Mark Brown [this message]
2011-08-04 12:42 ` Mark Brown
2011-08-05 11:53 ` Danny Huang
2011-08-09 10:47 dahuang
2011-08-09 16:06 ` Mark Brown
2011-08-22 9:35 ` Samuel Ortiz
2011-08-22 9:41 ` Liam Girdwood
2011-08-28 16:49 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110808133259.GA5719@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=dahuang@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=mike@compulab.co.il \
--cc=sameo@linux.intel.com \
--cc=xxie@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).