* request for review - DRBD multi volume support for 3.2
@ 2011-08-08 13:57 Philipp Reisner
2011-08-11 18:34 ` Fubo Chen
0 siblings, 1 reply; 3+ messages in thread
From: Philipp Reisner @ 2011-08-08 13:57 UTC (permalink / raw)
To: linux-kernel; +Cc: drbd-dev
This is a request for review of drbd-8.4. I intend to send a pull request
to Jens early next week, for his for-3.2/drivers branch.
I want to point out the idr_for_each_entry() macro, added to
include/linux/idr.h. Though we use this macro extensively in the new DRBD
code, it is not DRBD specific. I intend to leave it in this patch series, as
the following patches depend on it.
The most noticeable change is the support for multiple replicated volumes in
a single DRBD connection. Write-ordering is obeyed among all writes in all
volumes in a single connection. This feature is really important for users
who DRBD for mirroring over longer distances. (Protocol A).
The following changes since commit f963d270cb7bbb8eeb57901d02b22a493e664fd2:
cciss: add transport mode attribute to sys (2011-08-08 11:40:17 +0200)
are available in the git repository at:
git://git.drbd.org/linux-2.6-drbd.git for-jens
and the diffstat can be found below.
drivers/block/drbd/Makefile | 1 +
drivers/block/drbd/drbd_actlog.c | 702 ++++-----
drivers/block/drbd/drbd_bitmap.c | 296 +++-
drivers/block/drbd/drbd_int.h | 1250 ++++++--------
drivers/block/drbd/drbd_interval.c | 177 ++
drivers/block/drbd/drbd_interval.h | 40 +
drivers/block/drbd/drbd_main.c | 3372 ++++++++++++++---------------------
drivers/block/drbd/drbd_nl.c | 3332 +++++++++++++++++++++--------------
drivers/block/drbd/drbd_nla.c | 55 +
drivers/block/drbd/drbd_nla.h | 8 +
drivers/block/drbd/drbd_proc.c | 27 +-
drivers/block/drbd/drbd_receiver.c | 3439 +++++++++++++++++++++---------------
drivers/block/drbd/drbd_req.c | 739 ++++-----
drivers/block/drbd/drbd_req.h | 185 +--
drivers/block/drbd/drbd_state.c | 1749 ++++++++++++++++++
drivers/block/drbd/drbd_state.h | 161 ++
drivers/block/drbd/drbd_strings.c | 1 +
drivers/block/drbd/drbd_worker.c | 974 ++++++-----
drivers/block/drbd/drbd_wrappers.h | 10 +-
include/linux/drbd.h | 68 +-
include/linux/drbd_genl.h | 363 ++++
include/linux/drbd_genl_api.h | 55 +
include/linux/drbd_limits.h | 95 +-
include/linux/drbd_nl.h | 160 --
include/linux/drbd_tag_magic.h | 84 -
include/linux/genl_magic_func.h | 414 +++++
include/linux/genl_magic_struct.h | 277 +++
include/linux/idr.h | 11 +
include/linux/lru_cache.h | 67 +-
lib/lru_cache.c | 357 +++--
30 files changed, 10998 insertions(+), 7471 deletions(-)
create mode 100644 drivers/block/drbd/drbd_interval.c
create mode 100644 drivers/block/drbd/drbd_interval.h
create mode 100644 drivers/block/drbd/drbd_nla.c
create mode 100644 drivers/block/drbd/drbd_nla.h
create mode 100644 drivers/block/drbd/drbd_state.c
create mode 100644 drivers/block/drbd/drbd_state.h
create mode 100644 include/linux/drbd_genl.h
create mode 100644 include/linux/drbd_genl_api.h
delete mode 100644 include/linux/drbd_nl.h
delete mode 100644 include/linux/drbd_tag_magic.h
create mode 100644 include/linux/genl_magic_func.h
create mode 100644 include/linux/genl_magic_struct.h
Best,
Phil
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: request for review - DRBD multi volume support for 3.2
2011-08-08 13:57 request for review - DRBD multi volume support for 3.2 Philipp Reisner
@ 2011-08-11 18:34 ` Fubo Chen
2011-08-16 12:00 ` Philipp Reisner
0 siblings, 1 reply; 3+ messages in thread
From: Fubo Chen @ 2011-08-11 18:34 UTC (permalink / raw)
To: Philipp Reisner; +Cc: linux-kernel, drbd-dev
On Mon, Aug 8, 2011 at 3:57 PM, Philipp Reisner
<philipp.reisner@linbit.com> wrote:
> This is a request for review of drbd-8.4. I intend to send a pull request
> to Jens early next week, for his for-3.2/drivers branch.
>
> I want to point out the idr_for_each_entry() macro, added to
> include/linux/idr.h. Though we use this macro extensively in the new DRBD
> code, it is not DRBD specific. I intend to leave it in this patch series, as
> the following patches depend on it.
>
> The most noticeable change is the support for multiple replicated volumes in
> a single DRBD connection. Write-ordering is obeyed among all writes in all
> volumes in a single connection. This feature is really important for users
> who DRBD for mirroring over longer distances. (Protocol A).
Does not build here. Is EXPORT_SYMBOL(lc_is_used) missing ?
drivers/block/drbd/drbd_main.c: In function 'drbd_buildtag':
drivers/block/drbd/drbd_main.c:3561:19: warning: the comparison will
always evaluate as 'true' for the address of '__this_module' will
never be NULL [-Waddress]
drivers/block/drbd/drbd_nl.c:2463:12: warning: 'drbd_bmio_set_susp_al'
defined but not used [-Wunused-function]
ERROR: "lc_is_used" [drivers/block/drbd/drbd.ko] undefined!
ERROR: "lc_try_lock" [drivers/block/drbd/drbd.ko] undefined!
ERROR: "drbd_nla_parse_nested" [drivers/block/drbd/drbd.ko] undefined!
ERROR: "drbd_nla_find_nested" [drivers/block/drbd/drbd.ko] undefined!
Fubo.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: request for review - DRBD multi volume support for 3.2
2011-08-11 18:34 ` Fubo Chen
@ 2011-08-16 12:00 ` Philipp Reisner
0 siblings, 0 replies; 3+ messages in thread
From: Philipp Reisner @ 2011-08-16 12:00 UTC (permalink / raw)
To: Fubo Chen; +Cc: linux-kernel, drbd-dev
Am Donnerstag, 11. August 2011, 20:34:57 schrieb Fubo Chen:
> On Mon, Aug 8, 2011 at 3:57 PM, Philipp Reisner
>
> <philipp.reisner@linbit.com> wrote:
> > This is a request for review of drbd-8.4. I intend to send a pull request
> > to Jens early next week, for his for-3.2/drivers branch.
> >
> > I want to point out the idr_for_each_entry() macro, added to
> > include/linux/idr.h. Though we use this macro extensively in the new
> > DRBD code, it is not DRBD specific. I intend to leave it in this patch
> > series, as the following patches depend on it.
> >
> > The most noticeable change is the support for multiple replicated volumes
> > in a single DRBD connection. Write-ordering is obeyed among all writes
> > in all volumes in a single connection. This feature is really important
> > for users who DRBD for mirroring over longer distances. (Protocol A).
>
> Does not build here. Is EXPORT_SYMBOL(lc_is_used) missing ?
>
> drivers/block/drbd/drbd_main.c: In function 'drbd_buildtag':
> drivers/block/drbd/drbd_main.c:3561:19: warning: the comparison will
> always evaluate as 'true' for the address of '__this_module' will
> never be NULL [-Waddress]
> drivers/block/drbd/drbd_nl.c:2463:12: warning: 'drbd_bmio_set_susp_al'
> defined but not used [-Wunused-function]
> ERROR: "lc_is_used" [drivers/block/drbd/drbd.ko] undefined!
> ERROR: "lc_try_lock" [drivers/block/drbd/drbd.ko] undefined!
> ERROR: "drbd_nla_parse_nested" [drivers/block/drbd/drbd.ko] undefined!
> ERROR: "drbd_nla_find_nested" [drivers/block/drbd/drbd.ko] undefined!
>
> Fubo.
Hi Fubo,
I fixed the missing EXPORT_SYMBOLS, the missing drbd_nla_* and the
unused drbd_bmio_set_susp_al() issues. I amended the changes into
the commits where the fixes should be.
At you convenience, please retry:
git://git.drbd.org/linux-2.6-drbd.git for-jens
Best,
Phil
--
: Dipl-Ing Philipp Reisner
: LINBIT | Your Way to High Availability
: Tel: +43-1-8178292-50, Fax: +43-1-8178292-82
: http://www.linbit.com
DRBD(R) and LINBIT(R) are registered trademarks of LINBIT, Austria.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-16 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-08 13:57 request for review - DRBD multi volume support for 3.2 Philipp Reisner
2011-08-11 18:34 ` Fubo Chen
2011-08-16 12:00 ` Philipp Reisner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).