linux-next: build failure after merge of the ptrace tree

linux-next: build failure after merge of the ptrace tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi all,

After merging the ptrace tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

ERROR: ".set_current_blocked" [fs/autofs4/autofs4.ko] undefined!

Presumably set_current_blocked() needs to be EXPORTed.

I have used the ptrace tree from next-20110824 for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build failure after merge of the ptrace tree

[Oleg Nesterov]

Hi Stephen,

On 08/25, Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the ptrace tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> ERROR: ".set_current_blocked" [fs/autofs4/autofs4.ko] undefined!

In case you didn't notice, we are doing our best to complicate
your life :/

Sorry.

> Presumably set_current_blocked() needs to be EXPORTed.

Yes. I've reset the last 4 commits which touch the code in fs/.
Will add them back after the patch which exports set_current_blocked.

Thanks a lot!

Oleg.

[PATCH] add EXPORT_SYMBOL(set_current_blocked)

[Oleg Nesterov]

Export set_current_blocked() for modules. We have the code which
wrongly plays with ->blocked, and sigprocmask() should be avoided.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---

 kernel/signal.c |    1 +
 1 file changed, 1 insertion(+)

--- 3.1/kernel/signal.c~export_set_current_blocked	2011-08-25 18:23:42.000000000 +0200
+++ 3.1/kernel/signal.c	2011-08-25 18:24:02.000000000 +0200
@@ -2463,6 +2463,7 @@ void set_current_blocked(const sigset_t 
 	__set_task_blocked(tsk, newset);
 	spin_unlock_irq(&tsk->sighand->siglock);
 }
+EXPORT_SYMBOL(set_current_blocked);
 
 /*
  * This is also useful for kernel threads that want to temporarily