* [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue
@ 2011-08-31 7:22 Shaun Kluzek
2011-09-01 12:53 ` Sergei Shtylyov
0 siblings, 1 reply; 3+ messages in thread
From: Shaun Kluzek @ 2011-08-31 7:22 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel
Signed-off-by: Shaun Kluzek <g0del@bigpond.com>
---
drivers/usb/gadget/u_serial.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
index a8aa469..b86022f 100644
--- a/drivers/usb/gadget/u_serial.c
+++ b/drivers/usb/gadget/u_serial.c
@@ -552,11 +552,8 @@ recycle:
/* Push from tty to ldisc; without low_latency set this is handled by
* a workqueue, so we won't get callbacks and can hold port_lock
*/
- if (tty && do_push) {
+ if (tty && do_push)
tty_flip_buffer_push(tty);
- }
-
-
/* We want our data queue to become empty ASAP, keeping data
* in the tty and ldisc (not here). If we couldn't push any
* this time around, there may be trouble unless there's an
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue
2011-08-31 7:22 [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue Shaun Kluzek
@ 2011-09-01 12:53 ` Sergei Shtylyov
2011-09-18 8:26 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Sergei Shtylyov @ 2011-09-01 12:53 UTC (permalink / raw)
To: Shaun Kluzek; +Cc: gregkh, linux-usb, linux-kernel
Hello.
On 31-08-2011 11:22, Shaun Kluzek wrote:
> Signed-off-by: Shaun Kluzek<g0del@bigpond.com>
> ---
> drivers/usb/gadget/u_serial.c | 5 +----
> 1 files changed, 1 insertions(+), 4 deletions(-)
> diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> index a8aa469..b86022f 100644
> --- a/drivers/usb/gadget/u_serial.c
> +++ b/drivers/usb/gadget/u_serial.c
> @@ -552,11 +552,8 @@ recycle:
> /* Push from tty to ldisc; without low_latency set this is handled by
> * a workqueue, so we won't get callbacks and can hold port_lock
> */
> - if (tty && do_push) {
> + if (tty && do_push)
> tty_flip_buffer_push(tty);
> - }
> -
What's wrong with the first empty line here?
> -
> /* We want our data queue to become empty ASAP, keeping data
> * in the tty and ldisc (not here). If we couldn't push any
> * this time around, there may be trouble unless there's an
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue
2011-09-01 12:53 ` Sergei Shtylyov
@ 2011-09-18 8:26 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2011-09-18 8:26 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Shaun Kluzek, gregkh, linux-usb, linux-kernel
On Thu, Sep 01, 2011 at 04:53:39PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 31-08-2011 11:22, Shaun Kluzek wrote:
>
> >Signed-off-by: Shaun Kluzek<g0del@bigpond.com>
> >---
> > drivers/usb/gadget/u_serial.c | 5 +----
> > 1 files changed, 1 insertions(+), 4 deletions(-)
>
> >diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> >index a8aa469..b86022f 100644
> >--- a/drivers/usb/gadget/u_serial.c
> >+++ b/drivers/usb/gadget/u_serial.c
> >@@ -552,11 +552,8 @@ recycle:
> > /* Push from tty to ldisc; without low_latency set this is handled by
> > * a workqueue, so we won't get callbacks and can hold port_lock
> > */
> >- if (tty && do_push) {
> >+ if (tty && do_push)
> > tty_flip_buffer_push(tty);
> >- }
> >-
>
> What's wrong with the first empty line here?
>
> >-
I agree, don't delete all of the spacing here.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-18 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-31 7:22 [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue Shaun Kluzek
2011-09-01 12:53 ` Sergei Shtylyov
2011-09-18 8:26 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).