* [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init
@ 2011-09-20 8:50 Axel Lin
2011-09-20 14:27 ` Bjarne Steinsbo
2011-09-29 7:08 ` Felipe Balbi
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2011-09-20 8:50 UTC (permalink / raw)
To: linux-kernel
Cc: Felipe Balbi, Tony Lindgren, Russell King, linux-usb, linux-omap,
linux-arm-kernel
Current code calls omap4430_phy_init() twice in usb_musb_init().
Calling omap4430_phy_init() once is enough.
This patch removes the first omap4430_phy_init() call, which using an
uninitialized pointer as parameter.
This patch elimates below build warning:
arch/arm/mach-omap2/usb-musb.c: In function 'usb_musb_init':
arch/arm/mach-omap2/usb-musb.c:141: warning: 'dev' may be used uninitialized in this function
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
arch/arm/mach-omap2/usb-musb.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
index a65145b..19e4dac 100644
--- a/arch/arm/mach-omap2/usb-musb.c
+++ b/arch/arm/mach-omap2/usb-musb.c
@@ -137,9 +137,6 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
musb_plat.mode = board_data->mode;
musb_plat.extvbus = board_data->extvbus;
- if (cpu_is_omap44xx())
- omap4430_phy_init(dev);
-
if (cpu_is_omap3517() || cpu_is_omap3505()) {
oh_name = "am35x_otg_hs";
name = "musb-am35x";
--
1.7.4.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init
2011-09-20 8:50 [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init Axel Lin
@ 2011-09-20 14:27 ` Bjarne Steinsbo
2011-09-29 7:08 ` Felipe Balbi
1 sibling, 0 replies; 5+ messages in thread
From: Bjarne Steinsbo @ 2011-09-20 14:27 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Felipe Balbi, Tony Lindgren, Russell King,
linux-usb, linux-omap, linux-arm-kernel
Ref thread starting at http://marc.info/?l=linux-omap&m=131316289211258&w=2
Bjarne Steinsbo
On Tue, Sep 20, 2011 at 10:50 AM, Axel Lin <axel.lin@gmail.com> wrote:
> Current code calls omap4430_phy_init() twice in usb_musb_init().
> Calling omap4430_phy_init() once is enough.
> This patch removes the first omap4430_phy_init() call, which using an
> uninitialized pointer as parameter.
>
> This patch elimates below build warning:
> arch/arm/mach-omap2/usb-musb.c: In function 'usb_musb_init':
> arch/arm/mach-omap2/usb-musb.c:141: warning: 'dev' may be used uninitialized in this function
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> arch/arm/mach-omap2/usb-musb.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index a65145b..19e4dac 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -137,9 +137,6 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
> musb_plat.mode = board_data->mode;
> musb_plat.extvbus = board_data->extvbus;
>
> - if (cpu_is_omap44xx())
> - omap4430_phy_init(dev);
> -
> if (cpu_is_omap3517() || cpu_is_omap3505()) {
> oh_name = "am35x_otg_hs";
> name = "musb-am35x";
> --
> 1.7.4.1
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init
2011-09-20 8:50 [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init Axel Lin
2011-09-20 14:27 ` Bjarne Steinsbo
@ 2011-09-29 7:08 ` Felipe Balbi
2011-09-30 18:01 ` Tony Lindgren
1 sibling, 1 reply; 5+ messages in thread
From: Felipe Balbi @ 2011-09-29 7:08 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Felipe Balbi, Tony Lindgren, Russell King,
linux-usb, linux-omap, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 1296 bytes --]
On Tue, Sep 20, 2011 at 04:50:29PM +0800, Axel Lin wrote:
> Current code calls omap4430_phy_init() twice in usb_musb_init().
> Calling omap4430_phy_init() once is enough.
> This patch removes the first omap4430_phy_init() call, which using an
> uninitialized pointer as parameter.
>
> This patch elimates below build warning:
> arch/arm/mach-omap2/usb-musb.c: In function 'usb_musb_init':
> arch/arm/mach-omap2/usb-musb.c:141: warning: 'dev' may be used uninitialized in this function
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/mach-omap2/usb-musb.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> index a65145b..19e4dac 100644
> --- a/arch/arm/mach-omap2/usb-musb.c
> +++ b/arch/arm/mach-omap2/usb-musb.c
> @@ -137,9 +137,6 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
> musb_plat.mode = board_data->mode;
> musb_plat.extvbus = board_data->extvbus;
>
> - if (cpu_is_omap44xx())
> - omap4430_phy_init(dev);
> -
> if (cpu_is_omap3517() || cpu_is_omap3505()) {
> oh_name = "am35x_otg_hs";
> name = "musb-am35x";
> --
> 1.7.4.1
>
>
>
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init
2011-09-29 7:08 ` Felipe Balbi
@ 2011-09-30 18:01 ` Tony Lindgren
2011-10-03 18:46 ` Tony Lindgren
0 siblings, 1 reply; 5+ messages in thread
From: Tony Lindgren @ 2011-09-30 18:01 UTC (permalink / raw)
To: Felipe Balbi
Cc: Axel Lin, linux-kernel, Russell King, linux-usb, linux-omap,
linux-arm-kernel
* Felipe Balbi <balbi@ti.com> [110928 23:35]:
> On Tue, Sep 20, 2011 at 04:50:29PM +0800, Axel Lin wrote:
> > Current code calls omap4430_phy_init() twice in usb_musb_init().
> > Calling omap4430_phy_init() once is enough.
> > This patch removes the first omap4430_phy_init() call, which using an
> > uninitialized pointer as parameter.
> >
> > This patch elimates below build warning:
> > arch/arm/mach-omap2/usb-musb.c: In function 'usb_musb_init':
> > arch/arm/mach-omap2/usb-musb.c:141: warning: 'dev' may be used uninitialized in this function
> >
> > Signed-off-by: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Felipe Balbi <balbi@ti.com>
Thanks, applying into fixes.
Tony
>
> > ---
> > arch/arm/mach-omap2/usb-musb.c | 3 ---
> > 1 files changed, 0 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > index a65145b..19e4dac 100644
> > --- a/arch/arm/mach-omap2/usb-musb.c
> > +++ b/arch/arm/mach-omap2/usb-musb.c
> > @@ -137,9 +137,6 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
> > musb_plat.mode = board_data->mode;
> > musb_plat.extvbus = board_data->extvbus;
> >
> > - if (cpu_is_omap44xx())
> > - omap4430_phy_init(dev);
> > -
> > if (cpu_is_omap3517() || cpu_is_omap3505()) {
> > oh_name = "am35x_otg_hs";
> > name = "musb-am35x";
> > --
> > 1.7.4.1
> >
> >
> >
>
> --
> balbi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init
2011-09-30 18:01 ` Tony Lindgren
@ 2011-10-03 18:46 ` Tony Lindgren
0 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2011-10-03 18:46 UTC (permalink / raw)
To: Felipe Balbi, Bjarne Steinsbo
Cc: Russell King, linux-usb, linux-kernel, Axel Lin, linux-omap,
linux-arm-kernel
* Tony Lindgren <tony@atomide.com> [110930 10:28]:
> * Felipe Balbi <balbi@ti.com> [110928 23:35]:
> > On Tue, Sep 20, 2011 at 04:50:29PM +0800, Axel Lin wrote:
> > > Current code calls omap4430_phy_init() twice in usb_musb_init().
> > > Calling omap4430_phy_init() once is enough.
> > > This patch removes the first omap4430_phy_init() call, which using an
> > > uninitialized pointer as parameter.
> > >
> > > This patch elimates below build warning:
> > > arch/arm/mach-omap2/usb-musb.c: In function 'usb_musb_init':
> > > arch/arm/mach-omap2/usb-musb.c:141: warning: 'dev' may be used uninitialized in this function
> > >
> > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
> >
> > Acked-by: Felipe Balbi <balbi@ti.com>
>
> Thanks, applying into fixes.
FYI, I'll update this patch to have also Bjarne's SOB to
this patch because of the earlier reference. Will still
use Axel's patch as it shows the compile warning.
Regards,
Tony
> Tony
>
> >
> > > ---
> > > arch/arm/mach-omap2/usb-musb.c | 3 ---
> > > 1 files changed, 0 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > > index a65145b..19e4dac 100644
> > > --- a/arch/arm/mach-omap2/usb-musb.c
> > > +++ b/arch/arm/mach-omap2/usb-musb.c
> > > @@ -137,9 +137,6 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
> > > musb_plat.mode = board_data->mode;
> > > musb_plat.extvbus = board_data->extvbus;
> > >
> > > - if (cpu_is_omap44xx())
> > > - omap4430_phy_init(dev);
> > > -
> > > if (cpu_is_omap3517() || cpu_is_omap3505()) {
> > > oh_name = "am35x_otg_hs";
> > > name = "musb-am35x";
> > > --
> > > 1.7.4.1
> > >
> > >
> > >
> >
> > --
> > balbi
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-03 18:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-20 8:50 [PATCH] usb: musb: OMAP4430: Remove a redundant omap4430_phy_init call in usb_musb_init Axel Lin
2011-09-20 14:27 ` Bjarne Steinsbo
2011-09-29 7:08 ` Felipe Balbi
2011-09-30 18:01 ` Tony Lindgren
2011-10-03 18:46 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).