* [RFC][PATCH] x86_32: Call do_notify_resume() with interrupts enabled
@ 2011-10-05 17:28 Srikar Dronamraju
0 siblings, 0 replies; only message in thread
From: Srikar Dronamraju @ 2011-10-05 17:28 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar
Cc: Steven Rostedt, Linus Torvalds, Christoph Hellwig,
Ananth N Mavinakayanahalli, Thomas Gleixner, Andi Kleen,
Oleg Nesterov, Andrew Morton, Jim Keniston, Roland McGrath,
Shuah Khan, LKML
do_notify_resume() gets called with interrupts disabled on x86_32. This
is different from the x86_64 behavior, where interrupts are enabled at
the time.
Queries on lkml on this issue hasn't yielded any clear answer. Lets make
x86_32 behave the same as x86_64, unless there is a real reason to
maintain status quo.
Please refer https://lkml.org/lkml/2011/9/27/130 for more details
My 32-bit machine works fine (tm) with the patch below
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---
arch/x86/kernel/entry_32.S | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
index f3f6f53..29d72ca 100644
--- a/arch/x86/kernel/entry_32.S
+++ b/arch/x86/kernel/entry_32.S
@@ -625,6 +625,7 @@ work_notifysig: # deal with pending signals and
movl %esp, %eax
jne work_notifysig_v86 # returning to kernel-space or
# vm86-space
+ ENABLE_INTERRUPTS(CLBR_NONE)
xorl %edx, %edx
call do_notify_resume
jmp resume_userspace_sig
@@ -638,6 +639,7 @@ work_notifysig: # deal with pending signals and
#else
movl %esp, %eax
#endif
+ ENABLE_INTERRUPTS(CLBR_NONE)
xorl %edx, %edx
call do_notify_resume
jmp resume_userspace_sig
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-10-05 17:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-05 17:28 [RFC][PATCH] x86_32: Call do_notify_resume() with interrupts enabled Srikar Dronamraju
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).