* [PATCH] staging: iio: fix compile error
@ 2011-11-24 21:25 Arnd Hannemann
2011-11-25 7:28 ` Jonathan Cameron
2011-11-25 9:33 ` Al Viro
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Hannemann @ 2011-11-24 21:25 UTC (permalink / raw)
To: linux-iio; +Cc: linux-kernel, Arnd Hannemann
Commit b46413367961c2e8bd827e067a231be982aaeee2 introduced the following compile error:
CC drivers/staging/iio/industrialio-core.o
linux-2.6/drivers/staging/iio/industrialio-core.c: In function 'iio_event_getfd':
linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: error: 'ev_int' undeclared (first use in this function)
linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: note: each undeclared identifier is reported only once for each function it appears in
This patch fixes that.
Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
---
drivers/staging/iio/industrialio-core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
index 2656409..a5b4a1f 100644
--- a/drivers/staging/iio/industrialio-core.c
+++ b/drivers/staging/iio/industrialio-core.c
@@ -243,6 +243,7 @@ static const struct file_operations iio_event_chrdev_fileops = {
static int iio_event_getfd(struct iio_dev *indio_dev)
{
int fd;
+ struct iio_event_interface *ev_int = indio_dev->event_interface;
if (indio_dev->event_interface == NULL)
return -ENODEV;
--
1.7.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: iio: fix compile error
2011-11-24 21:25 [PATCH] staging: iio: fix compile error Arnd Hannemann
@ 2011-11-25 7:28 ` Jonathan Cameron
2011-11-25 9:33 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Cameron @ 2011-11-25 7:28 UTC (permalink / raw)
To: Arnd Hannemann, linux-iio; +Cc: linux-kernel
Thanks though this is fix number 4 I think. One will hit Linux next today and Greg has one to push out to Linus.
Arnd Hannemann <arnd@arndnet.de> wrote:
>Commit b46413367961c2e8bd827e067a231be982aaeee2 introduced the
>following compile error:
>
> CC drivers/staging/iio/industrialio-core.o
>linux-2.6/drivers/staging/iio/industrialio-core.c: In function
>'iio_event_getfd':
>linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: error:
>'ev_int' undeclared (first use in this function)
>linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: note: each
>undeclared identifier is reported only once for each function it
>appears in
>
>This patch fixes that.
>
>Signed-off-by: Arnd Hannemann <arnd@arndnet.de>
>---
> drivers/staging/iio/industrialio-core.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/staging/iio/industrialio-core.c
>b/drivers/staging/iio/industrialio-core.c
>index 2656409..a5b4a1f 100644
>--- a/drivers/staging/iio/industrialio-core.c
>+++ b/drivers/staging/iio/industrialio-core.c
>@@ -243,6 +243,7 @@ static const struct file_operations
>iio_event_chrdev_fileops = {
> static int iio_event_getfd(struct iio_dev *indio_dev)
> {
> int fd;
>+ struct iio_event_interface *ev_int = indio_dev->event_interface;
>
> if (indio_dev->event_interface == NULL)
> return -ENODEV;
>--
>1.7.5.4
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-iio" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Sent from my Android phone
with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: iio: fix compile error
2011-11-24 21:25 [PATCH] staging: iio: fix compile error Arnd Hannemann
2011-11-25 7:28 ` Jonathan Cameron
@ 2011-11-25 9:33 ` Al Viro
1 sibling, 0 replies; 3+ messages in thread
From: Al Viro @ 2011-11-25 9:33 UTC (permalink / raw)
To: Arnd Hannemann; +Cc: linux-iio, linux-kernel
On Thu, Nov 24, 2011 at 10:25:50PM +0100, Arnd Hannemann wrote:
> Commit b46413367961c2e8bd827e067a231be982aaeee2 introduced the following compile error:
>
> CC drivers/staging/iio/industrialio-core.o
> linux-2.6/drivers/staging/iio/industrialio-core.c: In function 'iio_event_getfd':
> linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: error: 'ev_int' undeclared (first use in this function)
> linux-2.6/drivers/staging/iio/industrialio-core.c:262:32: note: each undeclared identifier is reported only once for each function it appears in
>
> This patch fixes that.
Arrgh... My fault, sorry. Might be worth using the same local variable
for setting the bit as well...
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
> diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
> index 2656409..a5b4a1f 100644
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -243,6 +243,7 @@ static const struct file_operations iio_event_chrdev_fileops = {
> static int iio_event_getfd(struct iio_dev *indio_dev)
> {
> int fd;
> + struct iio_event_interface *ev_int = indio_dev->event_interface;
>
> if (indio_dev->event_interface == NULL)
> return -ENODEV;
> --
> 1.7.5.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-11-25 9:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-24 21:25 [PATCH] staging: iio: fix compile error Arnd Hannemann
2011-11-25 7:28 ` Jonathan Cameron
2011-11-25 9:33 ` Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).