* linux-next: build warning after merge of the l2-mtd tree
@ 2011-11-29 3:33 Stephen Rothwell
2011-11-29 9:54 ` Robert Jarzmik
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2011-11-29 3:33 UTC (permalink / raw)
To: Artem Bityutskiy; +Cc: linux-next, linux-kernel, Robert Jarzmik
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
Hi Artem,
After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/mtd/devices/docg3.c: In function 'doc_write_page_ecc_init':
drivers/mtd/devices/docg3.c:577:6: warning: suggest parentheses around operand of '!' or change '|' to '||' or '!' to '~' [-Wparentheses]
Introduced by commit 496a5fc59dae ("mtd/docg3: add write functions").
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the l2-mtd tree
2011-11-29 3:33 linux-next: build warning after merge of the l2-mtd tree Stephen Rothwell
@ 2011-11-29 9:54 ` Robert Jarzmik
0 siblings, 0 replies; 6+ messages in thread
From: Robert Jarzmik @ 2011-11-29 9:54 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Artem Bityutskiy, linux-next, linux-kernel
Stephen Rothwell <sfr@canb.auug.org.au> writes:
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/mtd/devices/docg3.c: In function 'doc_write_page_ecc_init':
> drivers/mtd/devices/docg3.c:577:6: warning: suggest parentheses around operand
> of '!' or change '|' to '||' or '!' to '~' [-Wparentheses]
Hi Stephen,
My fault, I've been too lazy with that commit for too long, and code like
writel(!reg1 | reg2, adr) is error prone. Artem did point out the warning
already, so that's on me.
I'll mend the fix in a V2 to a cleanup patch already submitted to linux-mtd.
Cheers.
--
Robert
PS: there will be another warning about an unused function
doc_get_erase_count(). This one will be fixed a bit later I'm afraid.
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build warning after merge of the l2-mtd tree
@ 2017-06-23 1:32 Stephen Rothwell
2017-06-23 4:56 ` Rafał Miłecki
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2017-06-23 1:32 UTC (permalink / raw)
To: Brian Norris
Cc: Linux-Next Mailing List, Linux Kernel Mailing List,
Rafał Miłecki
Hi Brian,
After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
In file included from include/linux/printk.h:6:0,
from include/linux/kernel.h:13,
from include/linux/list.h:8,
from include/linux/module.h:9,
from drivers/mtd/parsers/parser_trx.c:12:
drivers/mtd/parsers/parser_trx.c: In function 'parser_trx_data_part_name':
include/linux/kern_levels.h:4:18: warning: format '%X' expects argument of type 'unsigned int', but argument 2 has type 'size_t {aka long unsigned int}' [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
include/linux/kern_levels.h:10:18: note: in expansion of macro 'KERN_SOH'
#define KERN_ERR KERN_SOH "3" /* error conditions */
^
include/linux/printk.h:301:9: note: in expansion of macro 'KERN_ERR'
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
^
drivers/mtd/parsers/parser_trx.c:42:3: note: in expansion of macro 'pr_err'
pr_err("mtd_read error while parsing (offset: 0x%X): %d\n",
^
Introduced by commit
99352afe8f16 ("mtd: extract TRX parser out of bcm47xxpart into a separated module")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: linux-next: build warning after merge of the l2-mtd tree
2017-06-23 1:32 Stephen Rothwell
@ 2017-06-23 4:56 ` Rafał Miłecki
2017-06-23 17:59 ` Brian Norris
0 siblings, 1 reply; 6+ messages in thread
From: Rafał Miłecki @ 2017-06-23 4:56 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Brian Norris, Linux-Next Mailing List, Linux Kernel Mailing List
On 2017-06-23 03:32, Stephen Rothwell wrote:
> After merging the l2-mtd tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
This code has been just moved, so the warning was already there before.
But it's of course a good opportunity to fix it :)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: build warning after merge of the l2-mtd tree
2017-06-23 4:56 ` Rafał Miłecki
@ 2017-06-23 17:59 ` Brian Norris
0 siblings, 0 replies; 6+ messages in thread
From: Brian Norris @ 2017-06-23 17:59 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Stephen Rothwell, Linux-Next Mailing List, Linux Kernel Mailing List
On Fri, Jun 23, 2017 at 06:56:53AM +0200, Rafał Miłecki wrote:
> On 2017-06-23 03:32, Stephen Rothwell wrote:
> >After merging the l2-mtd tree, today's linux-next build (x86_64
> >allmodconfig) produced this warning:
>
> This code has been just moved, so the warning was already there before.
>
> But it's of course a good opportunity to fix it :)
We now allow it to build with COMPILE_TEST, which means it can show up
on 64-bit architectures, where sizeof(size_t) != sizeof(int). I failed
to add it to my local 64-bit build tests, so I didn't notice this.
But fixed now.
Brian
^ permalink raw reply [flat|nested] 6+ messages in thread
* linux-next: build warning after merge of the l2-mtd tree
@ 2017-07-24 1:48 Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2017-07-24 1:48 UTC (permalink / raw)
To: Brian Norris
Cc: Linux-Next Mailing List, Linux Kernel Mailing List, Mario Rugiero
Hi Brian,
After merging the l2-mtd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:
drivers/mtd/mtdswap.c: In function 'mtdswap_add_debugfs':
drivers/mtd/mtdswap.c:1317:17: warning: unused variable 'dev' [-Wunused-variable]
struct device *dev = disk_to_dev(gd);
^
Introduced by commit
e8e3edb95ce6 ("mtd: create per-device and module-scope debugfs entries")
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-07-24 1:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-29 3:33 linux-next: build warning after merge of the l2-mtd tree Stephen Rothwell
2011-11-29 9:54 ` Robert Jarzmik
2017-06-23 1:32 Stephen Rothwell
2017-06-23 4:56 ` Rafał Miłecki
2017-06-23 17:59 ` Brian Norris
2017-07-24 1:48 Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).