From: Wolfram Sang <w.sang@pengutronix.de>
To: Heiko Schocher <hs@denx.de>
Cc: Wolfgang Denk <wd@denx.de>, Vitaly Bordug <vbordug@ru.mvista.com>,
devicetree-discuss@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org
Subject: Re: [PATCH] drivers, char: add U-Boot bootcount driver
Date: Tue, 6 Dec 2011 22:50:56 +0100 [thread overview]
Message-ID: <20111206215056.GD14154@pengutronix.de> (raw)
In-Reply-To: <4EDCD7B2.5030409@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]
Hi Heiko,
> >> This driver provides read/write access to the U-Boot bootcounter
> >> through PROC FS and/or sysFS file.
> >
> > Why ProcFS? Why ProcFS and/or SysFS? Which has priority? Why not /dev?
>
> I drop the ProcFS support for v2.
Don't bother. This approach starts from the wrong side.
>
> >> The bootcountregister gets configured via DTS.
> >> for example on the enbw_cmc board:
> >>
> >> bootcount@0x23060 {
> >> compatible = "uboot,bootcount";
> >
> > No. I assume you are not the vendor of what is at 0x23060, the actual device.
> > Only the device must be encoded in the compatible-entry which then implies the
> > bootcount functionality. Also, keep in mind that your solution should be
> > generic for bootloaders.
>
> So I should call it compatible = "generic, bootcount" ?
Nope, you should give it the name of the device. Remember that 'compatible' is
no 1:1 replacement for platform_driver-binding. Check
http://devicetree.org/Device_Tree_Usage, especially the sections about the
compatible-property.
bootcount itself is not a device. It is a feature of certain devices. And that
needs to be implemented; possibly generic enough that it can work for register
based, i2c based, and so forth, accesses.
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-12-06 21:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-04 9:45 [PATCH] drivers, char: add U-Boot bootcount driver Heiko Schocher
2011-12-04 10:34 ` Matthias Kaehlcke
2011-12-04 11:47 ` Wolfram Sang
2011-12-04 16:34 ` Wolfgang Denk
2011-12-05 7:43 ` Thierry Reding
2011-12-05 14:39 ` Heiko Schocher
2011-12-06 21:50 ` Wolfram Sang [this message]
2011-12-06 21:56 ` Wolfgang Denk
2011-12-06 22:06 ` Wolfram Sang
2011-12-06 23:22 ` Rob Herring
2012-01-30 12:35 ` Heiko Schocher
2011-12-04 16:42 ` Paul Bolle
2011-12-04 23:30 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111206215056.GD14154@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=hs@denx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=vbordug@ru.mvista.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).