* [PATCH v3] mfd: TPS65910: Make usable even if interrupt unused
@ 2011-12-14 10:35 Afzal Mohammed
2011-12-19 15:44 ` Samuel Ortiz
0 siblings, 1 reply; 2+ messages in thread
From: Afzal Mohammed @ 2011-12-14 10:35 UTC (permalink / raw)
To: sameo, broonie, linux-kernel; +Cc: nsekhar, Afzal Mohammed
TPS65910 can be used even if interrupt is unused.
Hence let probe succeed in case interrupt can't be
configured and let Kernel only to complain about it
Signed-off-by: Afzal Mohammed <afzal@ti.com>
---
v2: free irq only if registered
drivers/mfd/tps65910-irq.c | 3 ++-
drivers/mfd/tps65910.c | 7 ++-----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/tps65910-irq.c b/drivers/mfd/tps65910-irq.c
index a56be93..95c0d79 100644
--- a/drivers/mfd/tps65910-irq.c
+++ b/drivers/mfd/tps65910-irq.c
@@ -215,6 +215,7 @@ int tps65910_irq_init(struct tps65910 *tps65910, int irq,
int tps65910_irq_exit(struct tps65910 *tps65910)
{
- free_irq(tps65910->chip_irq, tps65910);
+ if (tps65910->chip_irq)
+ free_irq(tps65910->chip_irq, tps65910);
return 0;
}
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 6f5b8cf..04814a7 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -172,15 +172,12 @@ static int tps65910_i2c_probe(struct i2c_client *i2c,
tps65910_gpio_init(tps65910, pmic_plat_data->gpio_base);
- ret = tps65910_irq_init(tps65910, init_data->irq, init_data);
- if (ret < 0)
- goto err;
+ tps65910_irq_init(tps65910, init_data->irq, init_data);
kfree(init_data);
return ret;
err:
- mfd_remove_devices(tps65910->dev);
kfree(tps65910);
kfree(init_data);
return ret;
@@ -190,8 +187,8 @@ static int tps65910_i2c_remove(struct i2c_client *i2c)
{
struct tps65910 *tps65910 = i2c_get_clientdata(i2c);
- mfd_remove_devices(tps65910->dev);
tps65910_irq_exit(tps65910);
+ mfd_remove_devices(tps65910->dev);
kfree(tps65910);
return 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] mfd: TPS65910: Make usable even if interrupt unused
2011-12-14 10:35 [PATCH v3] mfd: TPS65910: Make usable even if interrupt unused Afzal Mohammed
@ 2011-12-19 15:44 ` Samuel Ortiz
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Ortiz @ 2011-12-19 15:44 UTC (permalink / raw)
To: Afzal Mohammed; +Cc: broonie, linux-kernel, nsekhar
Hi Mohamed,
On Wed, Dec 14, 2011 at 04:05:35PM +0530, Afzal Mohammed wrote:
> TPS65910 can be used even if interrupt is unused.
> Hence let probe succeed in case interrupt can't be
> configured and let Kernel only to complain about it
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-19 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-14 10:35 [PATCH v3] mfd: TPS65910: Make usable even if interrupt unused Afzal Mohammed
2011-12-19 15:44 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).