From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: fweisbec@gmail.com, mingo@redhat.com, paulus@samba.org,
acme@ghostprotocols.net, a.p.zijlstra@chello.nl,
linux-kernel@vger.kernel.org, aarapov@redhat.com,
Christoph Lameter <christoph@lameter.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCHv2 03/10] ftrace: Add enable/disable ftrace_ops control interface
Date: Tue, 20 Dec 2011 16:35:06 +0100 [thread overview]
Message-ID: <20111220153506.GC4393@m.brq.redhat.com> (raw)
In-Reply-To: <1324394753.5916.53.camel@gandalf.stny.rr.com>
On Tue, Dec 20, 2011 at 10:25:53AM -0500, Steven Rostedt wrote:
> On Tue, 2011-12-20 at 15:57 +0100, Jiri Olsa wrote:
>
> > >
> > > If the above is called with preemption enabled, it will not do what is
> > > expected. We could disable function tracing on one CPU and then
> > > re-enable it for another CPU even though it is already enabled.
> >
> > It is only called inside perf reg callback within the
> > schedule function where the preemption is disabled.
> >
> > The ftrace_function_enable is called when task is scheduled in
> > on respective cpu. Likewise the ftrace_function_disable is called
> > when task is scheduled out on respective cpu.
>
> Yes I know how you use it, but this is an open API. It may be currently
> only used by perf today, but that doesn't mean that it wont be used by
> others. There's no documentation on how to use it. I don't look at this
> and say, "oh this is used by perf, we only need to worry about how perf
> uses it". That doesn't scale. It needs to be documented on how to use
> it, and if it requires preemption disabled when calling it, it should
> definitely be stated that fact and it may need a
> WARN_ON(preempt_count()) or something.
I've already added
if (WARN_ON_ONCE(!(ops->flags & FTRACE_OPS_FL_CONTROL)))
return;
will add similar for preemption and make comments for both functions
thanks,
jirka
>
> -- Steve
>
>
next prev parent reply other threads:[~2011-12-20 15:35 UTC|newest]
Thread overview: 185+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 18:04 [RFC] ftrace, perf: Adding support to use function trace Jiri Olsa
2011-11-27 18:04 ` [PATCH 1/9] trace: Fix uninitialized variable compiler warning Jiri Olsa
2011-11-28 16:19 ` Steven Rostedt
2011-11-28 16:25 ` Jiri Olsa
2011-11-28 19:34 ` Steven Rostedt
2011-11-27 18:04 ` [PATCH 2/9] ftrace: Fix possible NULL dereferencing in __ftrace_hash_rec_update Jiri Olsa
2011-11-28 16:24 ` Steven Rostedt
2011-11-27 18:04 ` [PATCH 3/9] ftrace: Fix shutdown to disable calls properly Jiri Olsa
2011-11-28 19:18 ` Steven Rostedt
2011-11-29 11:21 ` Jiri Olsa
2011-11-27 18:04 ` [PATCH 4/9] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2011-11-28 19:26 ` Steven Rostedt
2011-11-28 20:02 ` Peter Zijlstra
2011-11-28 20:05 ` Peter Zijlstra
2011-11-28 20:14 ` Steven Rostedt
2011-11-28 20:20 ` Peter Zijlstra
2011-11-28 20:12 ` Steven Rostedt
2011-11-28 20:15 ` Peter Zijlstra
2011-11-28 20:24 ` Steven Rostedt
2011-11-28 20:21 ` Steven Rostedt
2011-11-29 10:07 ` Jiri Olsa
2011-11-27 18:04 ` [PATCH 5/9] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2011-11-27 18:04 ` [PATCH 6/9] ftrace, perf: Add add/del " Jiri Olsa
2011-11-27 18:04 ` [PATCH 7/9] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2011-11-28 19:58 ` Steven Rostedt
2011-11-28 20:03 ` Peter Zijlstra
2011-11-28 20:13 ` Steven Rostedt
2011-11-29 10:10 ` Jiri Olsa
2011-11-28 20:08 ` Peter Zijlstra
2011-11-28 20:10 ` Peter Zijlstra
2011-11-28 20:16 ` Steven Rostedt
2011-11-28 20:18 ` Peter Zijlstra
2011-11-27 18:04 ` [PATCH 8/9] ftrace, perf: Add FILTER_TRACE_FN event field type Jiri Olsa
2011-11-28 20:01 ` Steven Rostedt
2011-11-29 10:14 ` Jiri Olsa
2011-11-29 11:22 ` Jiri Olsa
2011-11-29 11:51 ` Peter Zijlstra
2011-11-29 12:21 ` Jiri Olsa
2011-11-27 18:04 ` [PATCH 9/9] ftrace, perf: Add filter support for function trace event Jiri Olsa
2011-11-28 20:07 ` Steven Rostedt
2011-12-05 17:22 ` [RFCv2] ftrace, perf: Adding support to use function trace Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 01/10] ftrace: Fix possible NULL dereferencing in __ftrace_hash_rec_update Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 02/10] ftrace: Change mcount call replacement logic Jiri Olsa
2011-12-19 19:03 ` Steven Rostedt
2011-12-20 13:10 ` Jiri Olsa
2011-12-20 16:33 ` Steven Rostedt
2011-12-20 19:39 ` Steven Rostedt
2011-12-21 9:57 ` Jiri Olsa
2011-12-21 11:34 ` Steven Rostedt
2011-12-21 11:35 ` Steven Rostedt
2011-12-21 11:40 ` Jiri Olsa
2012-01-08 9:13 ` [tip:perf/core] ftrace: Fix unregister ftrace_ops accounting tip-bot for Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 03/10] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2011-12-19 19:19 ` Steven Rostedt
2011-12-19 19:35 ` Steven Rostedt
2011-12-20 14:57 ` Jiri Olsa
2011-12-20 15:25 ` Steven Rostedt
2011-12-20 15:35 ` Jiri Olsa [this message]
2011-12-05 17:22 ` [PATCHv2 04/10] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 05/10] ftrace, perf: Add add/del " Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 06/10] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 07/10] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2011-12-19 19:22 ` Steven Rostedt
2011-12-05 17:22 ` [PATCHv2 08/10] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 09/10] ftrace, perf: Add filter support for function trace event Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 10/10] ftrace, graph: Add global_ops filter callback for graph tracing Jiri Olsa
2011-12-19 19:27 ` Steven Rostedt
2011-12-19 13:40 ` [RFCv2] ftrace, perf: Adding support to use function trace Jiri Olsa
2011-12-19 16:45 ` Steven Rostedt
2011-12-19 16:58 ` Frederic Weisbecker
2011-12-21 11:48 ` [PATCHv3 0/8] " Jiri Olsa
2011-12-21 11:48 ` [PATCH 1/8] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2011-12-21 11:48 ` [PATCH 2/8] ftrace: Fix possible NULL dereferencing in __ftrace_hash_rec_update Jiri Olsa
2011-12-21 15:23 ` Steven Rostedt
2011-12-21 11:48 ` [PATCH 3/8] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2011-12-21 16:01 ` Steven Rostedt
2011-12-21 16:43 ` Jiri Olsa
2011-12-21 16:55 ` Steven Rostedt
2012-01-24 1:26 ` Frederic Weisbecker
2011-12-21 11:48 ` [PATCH 4/8] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2011-12-21 11:48 ` [PATCH 5/8] ftrace, perf: Add add/del " Jiri Olsa
2011-12-21 11:48 ` [PATCH 6/8] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2011-12-21 11:48 ` [PATCH 7/8] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2011-12-21 11:48 ` [PATCH 8/8] ftrace, perf: Add filter support for function trace event Jiri Olsa
2011-12-21 18:56 ` [PATCHv4 0/8] ftrace, perf: Adding support to use function trace Jiri Olsa
2011-12-21 18:56 ` [PATCH 1/7] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2011-12-22 0:12 ` Steven Rostedt
2011-12-22 8:01 ` [PATCHv5 " Jiri Olsa
2011-12-21 18:56 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2011-12-21 18:56 ` [PATCH 3/7] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2011-12-21 18:56 ` [PATCH 4/7] ftrace, perf: Add add/del " Jiri Olsa
2011-12-21 18:56 ` [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2011-12-21 18:56 ` [PATCH 6/7] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2011-12-21 18:56 ` [PATCH 7/7] ftrace, perf: Add filter support for function trace event Jiri Olsa
2011-12-21 22:07 ` Frederic Weisbecker
2011-12-22 12:55 ` Jiri Olsa
2011-12-22 15:26 ` [PATCHvFIXED " Jiri Olsa
2011-12-24 2:35 ` Frederic Weisbecker
2011-12-21 19:02 ` [PATCHv4 0/7] ftrace, perf: Adding support to use function trace Jiri Olsa
2012-01-02 9:04 ` [PATCHv5 " Jiri Olsa
2012-01-02 9:04 ` [PATCH 1/7] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-02-17 13:46 ` [tip:perf/core] ftrace: Change filter/ notrace " tip-bot for Jiri Olsa
2012-01-02 9:04 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-01-17 1:42 ` Frederic Weisbecker
2012-01-17 2:07 ` Steven Rostedt
2012-01-17 2:29 ` Frederic Weisbecker
2012-01-18 13:59 ` Jiri Olsa
2012-01-02 9:04 ` [PATCH 3/7] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2012-01-02 9:04 ` [PATCH 4/7] ftrace, perf: Add add/del " Jiri Olsa
2012-01-02 9:04 ` [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2012-01-02 9:04 ` [PATCH 6/7] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2012-01-02 9:04 ` [PATCH 7/7] ftrace, perf: Add filter support for function trace event Jiri Olsa
2012-01-16 23:59 ` Steven Rostedt
2012-01-18 13:45 ` Jiri Olsa
2012-01-16 8:57 ` [PATCHv5 0/7] ftrace, perf: Adding support to use function trace Jiri Olsa
2012-01-16 16:17 ` Steven Rostedt
2012-01-18 18:44 ` [PATCHv6 " Jiri Olsa
2012-01-18 18:44 ` [PATCH 1/7] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-01-19 16:31 ` Frederic Weisbecker
2012-01-18 18:44 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-01-20 17:02 ` Frederic Weisbecker
2012-01-25 23:13 ` Steven Rostedt
2012-01-26 2:37 ` Frederic Weisbecker
2012-01-27 10:37 ` Jiri Olsa
2012-01-27 10:38 ` Jiri Olsa
2012-01-27 16:40 ` Frederic Weisbecker
2012-01-27 16:54 ` Jiri Olsa
2012-01-27 17:02 ` Frederic Weisbecker
2012-01-27 17:20 ` Jiri Olsa
2012-01-28 16:39 ` Frederic Weisbecker
2012-01-27 17:21 ` Steven Rostedt
2012-01-18 18:44 ` [PATCH 3/7] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2012-01-18 18:44 ` [PATCH 4/7] ftrace, perf: Add add/del " Jiri Olsa
2012-01-18 18:44 ` [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2012-01-18 18:44 ` [PATCH 6/7] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2012-01-18 18:44 ` [PATCH 7/7] ftrace, perf: Add filter support for function trace event Jiri Olsa
2012-01-18 21:43 ` [PATCHv6 0/7] ftrace, perf: Adding support to use function trace Steven Rostedt
2012-01-28 18:43 ` [PATCHv7 " Jiri Olsa
2012-01-28 18:43 ` [PATCH 1/7] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-01-30 5:42 ` Frederic Weisbecker
2012-01-28 18:43 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-01-30 5:59 ` Frederic Weisbecker
2012-01-30 9:18 ` Jiri Olsa
2012-02-03 13:42 ` Steven Rostedt
2012-02-03 13:50 ` Jiri Olsa
2012-02-03 14:08 ` Steven Rostedt
2012-02-03 14:22 ` [PATCHv8 0/2] first 2 patches passed review Jiri Olsa
2012-02-03 14:22 ` [PATCH 1/2] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-02-03 14:22 ` [PATCH 2/2] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-02-04 13:24 ` [PATCHv8 0/2] first 2 patches passed review Frederic Weisbecker
2012-02-03 13:40 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Steven Rostedt
2012-01-28 18:43 ` [PATCH 3/7] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2012-02-02 17:35 ` Frederic Weisbecker
2012-02-03 10:23 ` Jiri Olsa
2012-01-28 18:43 ` [PATCH 4/7] ftrace, perf: Add add/del " Jiri Olsa
2012-02-02 17:42 ` Frederic Weisbecker
2012-01-28 18:43 ` [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2012-02-02 18:14 ` Frederic Weisbecker
2012-02-03 12:54 ` Jiri Olsa
2012-02-03 13:00 ` Jiri Olsa
2012-02-03 14:07 ` Steven Rostedt
2012-02-04 13:21 ` Frederic Weisbecker
2012-02-06 19:35 ` Steven Rostedt
2012-02-03 13:53 ` Steven Rostedt
2012-01-28 18:43 ` [PATCH 6/7] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2012-02-03 14:16 ` Steven Rostedt
2012-01-28 18:43 ` [PATCH 7/7] ftrace, perf: Add filter support for function trace event Jiri Olsa
2012-02-07 0:20 ` Jiri Olsa
2012-02-07 19:44 ` [PATCHv8 0/8] ftrace, perf: Adding support to use function trace Jiri Olsa
2012-02-07 19:44 ` [PATCH 1/8] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-02-07 19:44 ` [PATCH 2/8] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-02-07 19:44 ` [PATCH 3/8] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2012-02-07 19:44 ` [PATCH 4/8] ftrace, perf: Add add/del " Jiri Olsa
2012-02-07 19:44 ` [PATCH 5/8] ftrace: Add FTRACE_ENTRY_REG macro to allow event registration Jiri Olsa
2012-02-07 19:44 ` [PATCH 6/8] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2012-02-07 19:44 ` [PATCH 7/8] ftrace: Allow to specify filter field type for ftrace events Jiri Olsa
2012-02-07 19:44 ` [PATCH 8/8] ftrace, perf: Add filter support for function trace event Jiri Olsa
2012-02-10 13:27 ` [PATCHv8 0/8] ftrace, perf: Adding support to use function trace Steven Rostedt
2012-02-10 14:45 ` Steven Rostedt
2012-02-10 16:07 ` Jiri Olsa
2012-02-10 16:48 ` Frederic Weisbecker
2012-02-10 18:00 ` Steven Rostedt
2012-02-10 18:05 ` Frederic Weisbecker
2012-02-10 18:23 ` David Ahern
2012-02-13 18:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111220153506.GC4393@m.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=a.p.zijlstra@chello.nl \
--cc=aarapov@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=christoph@lameter.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).