From: Frederic Weisbecker <fweisbec@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: rostedt@goodmis.org, mingo@redhat.com, paulus@samba.org,
acme@ghostprotocols.net, a.p.zijlstra@chello.nl,
linux-kernel@vger.kernel.org, aarapov@redhat.com
Subject: Re: [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf
Date: Thu, 2 Feb 2012 19:14:12 +0100 [thread overview]
Message-ID: <20120202181409.GH9071@somewhere.redhat.com> (raw)
In-Reply-To: <1327776209-4883-6-git-send-email-jolsa@redhat.com>
On Sat, Jan 28, 2012 at 07:43:27PM +0100, Jiri Olsa wrote:
> Adding perf registration support for the ftrace function event,
> so it is now possible to register it via perf interface.
>
> The perf_event struct statically contains ftrace_ops as a handle
> for function tracer. The function tracer is registered/unregistered
> in open/close actions.
>
> To be efficient, we enable/disable ftrace_ops each time the traced
> process is scheduled in/out (via TRACE_REG_PERF_(ADD|DELL) handlers).
> This way tracing is enabled only when the process is running.
> Intentionally using this way instead of the event's hw state
> PERF_HES_STOPPED, which would not disable the ftrace_ops.
>
> It is now possible to use function trace within perf commands
> like:
>
> perf record -e ftrace:function ls
> perf stat -e ftrace:function ls
>
> Allowed only for root.
Good idea. We probably don't want to leak the rate of calls of a kernel
function to userspace.
[...]
> +static void
> +perf_ftrace_function_call(unsigned long ip, unsigned long parent_ip)
> +{
> + struct ftrace_entry *entry;
> + struct hlist_head *head;
> + struct pt_regs regs;
> + int rctx;
> +
> +#define ENTRY_SIZE (ALIGN(sizeof(struct ftrace_entry) + sizeof(u32), \
> + sizeof(u64)) - sizeof(u32))
> +
> + BUILD_BUG_ON(ENTRY_SIZE > PERF_MAX_TRACE_SIZE);
> +
> + perf_fetch_caller_regs(®s);
> +
> + entry = perf_trace_buf_prepare(ENTRY_SIZE, TRACE_FN, NULL, &rctx);
> + if (!entry)
> + return;
> +
> + entry->ip = ip;
> + entry->parent_ip = parent_ip;
> +
> + head = this_cpu_ptr(event_function.perf_events);
> + perf_trace_buf_submit(entry, ENTRY_SIZE, rctx, 0,
> + 1, ®s, head);
> +
> +#undef ENTRY_SIZE
> +}
> +
> +static int perf_ftrace_function_register(struct perf_event *event)
> +{
> + struct ftrace_ops *ops = &event->ftrace_ops;
> +
> + ops->flags |= FTRACE_OPS_FL_CONTROL;
> + ops->func = perf_ftrace_function_call;
> + return register_ftrace_function(ops);
> +}
> +
> +static int perf_ftrace_function_unregister(struct perf_event *event)
> +{
> + struct ftrace_ops *ops = &event->ftrace_ops;
> + return unregister_ftrace_function(ops);
> +}
> +
> +static void perf_ftrace_function_enable(struct perf_event *event)
> +{
> + ftrace_function_local_enable(&event->ftrace_ops);
> +}
> +
> +static void perf_ftrace_function_disable(struct perf_event *event)
> +{
> + ftrace_function_local_disable(&event->ftrace_ops);
> +}
> +
> +int perf_ftrace_event_register(struct ftrace_event_call *call,
> + enum trace_reg type, void *data)
> +{
> + int etype = call->event.type;
> +
> + if (etype != TRACE_FN)
> + return -EINVAL;
> +
> + switch (type) {
> + case TRACE_REG_REGISTER:
> + case TRACE_REG_UNREGISTER:
> + break;
> + case TRACE_REG_PERF_REGISTER:
> + case TRACE_REG_PERF_UNREGISTER:
> + return 0;
> + case TRACE_REG_PERF_OPEN:
> + return perf_ftrace_function_register(data);
> + case TRACE_REG_PERF_CLOSE:
> + return perf_ftrace_function_unregister(data);
> + case TRACE_REG_PERF_ADD:
> + perf_ftrace_function_enable(data);
> + return 0;
> + case TRACE_REG_PERF_DEL:
> + perf_ftrace_function_disable(data);
> + return 0;
> + }
> +
> + return -EINVAL;
> +}
All the above from perf_ftrace_function_call() to here should perhaps
go to trace_function.c.
> diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c
> index bbeec31..867653c 100644
> --- a/kernel/trace/trace_export.c
> +++ b/kernel/trace/trace_export.c
> @@ -131,6 +131,28 @@ ftrace_define_fields_##name(struct ftrace_event_call *event_call) \
>
> #include "trace_entries.h"
>
> +static int ftrace_event_class_register(struct ftrace_event_call *call,
> + enum trace_reg type, void *data)
> +{
> + switch (type) {
> + case TRACE_REG_PERF_REGISTER:
> + case TRACE_REG_PERF_UNREGISTER:
> + return 0;
> + case TRACE_REG_PERF_OPEN:
> + case TRACE_REG_PERF_CLOSE:
> + case TRACE_REG_PERF_ADD:
> + case TRACE_REG_PERF_DEL:
> +#ifdef CONFIG_PERF_EVENTS
> + return perf_ftrace_event_register(call, type, data);
> +#endif
> + case TRACE_REG_REGISTER:
> + case TRACE_REG_UNREGISTER:
> + break;
> + }
> +
> + return -EINVAL;
> +}
Hmm, one day we'll need to demux here. What about adding an argument to
FTRACE_ENTRY() to add the pointer to .reg ?
> +
> #undef __entry
> #define __entry REC
>
> @@ -159,6 +181,7 @@ struct ftrace_event_class event_class_ftrace_##call = { \
> .system = __stringify(TRACE_SYSTEM), \
> .define_fields = ftrace_define_fields_##call, \
> .fields = LIST_HEAD_INIT(event_class_ftrace_##call.fields),\
> + .reg = ftrace_event_class_register, \
> }; \
> \
> struct ftrace_event_call __used event_##call = { \
> @@ -170,4 +193,9 @@ struct ftrace_event_call __used event_##call = { \
> struct ftrace_event_call __used \
> __attribute__((section("_ftrace_events"))) *__event_##call = &event_##call;
>
> +int ftrace_event_is_function(struct ftrace_event_call *call)
> +{
> + return call == &event_function;
> +}
> +
> #include "trace_entries.h"
> --
> 1.7.1
>
next prev parent reply other threads:[~2012-02-02 18:14 UTC|newest]
Thread overview: 187+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 18:04 [RFC] ftrace, perf: Adding support to use function trace Jiri Olsa
2011-11-27 18:04 ` [PATCH 1/9] trace: Fix uninitialized variable compiler warning Jiri Olsa
2011-11-28 16:19 ` Steven Rostedt
2011-11-28 16:25 ` Jiri Olsa
2011-11-28 19:34 ` Steven Rostedt
2011-11-27 18:04 ` [PATCH 2/9] ftrace: Fix possible NULL dereferencing in __ftrace_hash_rec_update Jiri Olsa
2011-11-28 16:24 ` Steven Rostedt
2011-11-27 18:04 ` [PATCH 3/9] ftrace: Fix shutdown to disable calls properly Jiri Olsa
2011-11-28 19:18 ` Steven Rostedt
2011-11-29 11:21 ` Jiri Olsa
2011-11-27 18:04 ` [PATCH 4/9] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2011-11-28 19:26 ` Steven Rostedt
2011-11-28 20:02 ` Peter Zijlstra
2011-11-28 20:05 ` Peter Zijlstra
2011-11-28 20:14 ` Steven Rostedt
2011-11-28 20:20 ` Peter Zijlstra
2011-11-28 20:12 ` Steven Rostedt
2011-11-28 20:15 ` Peter Zijlstra
2011-11-28 20:24 ` Steven Rostedt
2011-11-28 20:21 ` Steven Rostedt
2011-11-29 10:07 ` Jiri Olsa
2011-11-27 18:04 ` [PATCH 5/9] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2011-11-27 18:04 ` [PATCH 6/9] ftrace, perf: Add add/del " Jiri Olsa
2011-11-27 18:04 ` [PATCH 7/9] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2011-11-28 19:58 ` Steven Rostedt
2011-11-28 20:03 ` Peter Zijlstra
2011-11-28 20:13 ` Steven Rostedt
2011-11-29 10:10 ` Jiri Olsa
2011-11-28 20:08 ` Peter Zijlstra
2011-11-28 20:10 ` Peter Zijlstra
2011-11-28 20:16 ` Steven Rostedt
2011-11-28 20:18 ` Peter Zijlstra
2011-11-27 18:04 ` [PATCH 8/9] ftrace, perf: Add FILTER_TRACE_FN event field type Jiri Olsa
2011-11-28 20:01 ` Steven Rostedt
2011-11-29 10:14 ` Jiri Olsa
2011-11-29 11:22 ` Jiri Olsa
2011-11-29 11:51 ` Peter Zijlstra
2011-11-29 12:21 ` Jiri Olsa
2011-11-27 18:04 ` [PATCH 9/9] ftrace, perf: Add filter support for function trace event Jiri Olsa
2011-11-28 20:07 ` Steven Rostedt
2011-12-05 17:22 ` [RFCv2] ftrace, perf: Adding support to use function trace Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 01/10] ftrace: Fix possible NULL dereferencing in __ftrace_hash_rec_update Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 02/10] ftrace: Change mcount call replacement logic Jiri Olsa
2011-12-19 19:03 ` Steven Rostedt
2011-12-20 13:10 ` Jiri Olsa
2011-12-20 16:33 ` Steven Rostedt
2011-12-20 19:39 ` Steven Rostedt
2011-12-21 9:57 ` Jiri Olsa
2011-12-21 11:34 ` Steven Rostedt
2011-12-21 11:35 ` Steven Rostedt
2011-12-21 11:40 ` Jiri Olsa
2012-01-08 9:13 ` [tip:perf/core] ftrace: Fix unregister ftrace_ops accounting tip-bot for Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 03/10] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2011-12-19 19:19 ` Steven Rostedt
2011-12-19 19:35 ` Steven Rostedt
2011-12-20 14:57 ` Jiri Olsa
2011-12-20 15:25 ` Steven Rostedt
2011-12-20 15:35 ` Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 04/10] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 05/10] ftrace, perf: Add add/del " Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 06/10] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 07/10] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2011-12-19 19:22 ` Steven Rostedt
2011-12-05 17:22 ` [PATCHv2 08/10] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 09/10] ftrace, perf: Add filter support for function trace event Jiri Olsa
2011-12-05 17:22 ` [PATCHv2 10/10] ftrace, graph: Add global_ops filter callback for graph tracing Jiri Olsa
2011-12-19 19:27 ` Steven Rostedt
2011-12-19 13:40 ` [RFCv2] ftrace, perf: Adding support to use function trace Jiri Olsa
2011-12-19 16:45 ` Steven Rostedt
2011-12-19 16:58 ` Frederic Weisbecker
2011-12-21 11:48 ` [PATCHv3 0/8] " Jiri Olsa
2011-12-21 11:48 ` [PATCH 1/8] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2011-12-21 11:48 ` [PATCH 2/8] ftrace: Fix possible NULL dereferencing in __ftrace_hash_rec_update Jiri Olsa
2011-12-21 15:23 ` Steven Rostedt
2011-12-21 11:48 ` [PATCH 3/8] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2011-12-21 16:01 ` Steven Rostedt
2011-12-21 16:43 ` Jiri Olsa
2011-12-21 16:55 ` Steven Rostedt
2012-01-24 1:26 ` Frederic Weisbecker
2011-12-21 11:48 ` [PATCH 4/8] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2011-12-21 11:48 ` [PATCH 5/8] ftrace, perf: Add add/del " Jiri Olsa
2011-12-21 11:48 ` [PATCH 6/8] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2011-12-21 11:48 ` [PATCH 7/8] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2011-12-21 11:48 ` [PATCH 8/8] ftrace, perf: Add filter support for function trace event Jiri Olsa
2011-12-21 18:56 ` [PATCHv4 0/8] ftrace, perf: Adding support to use function trace Jiri Olsa
2011-12-21 18:56 ` [PATCH 1/7] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2011-12-22 0:12 ` Steven Rostedt
2011-12-22 8:01 ` [PATCHv5 " Jiri Olsa
2011-12-21 18:56 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2011-12-21 18:56 ` [PATCH 3/7] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2011-12-21 18:56 ` [PATCH 4/7] ftrace, perf: Add add/del " Jiri Olsa
2011-12-21 18:56 ` [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2011-12-21 18:56 ` [PATCH 6/7] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2011-12-21 18:56 ` [PATCH 7/7] ftrace, perf: Add filter support for function trace event Jiri Olsa
2011-12-21 22:07 ` Frederic Weisbecker
2011-12-22 12:55 ` Jiri Olsa
2011-12-22 15:26 ` [PATCHvFIXED " Jiri Olsa
2011-12-24 2:35 ` Frederic Weisbecker
2011-12-21 19:02 ` [PATCHv4 0/7] ftrace, perf: Adding support to use function trace Jiri Olsa
2012-01-02 9:04 ` [PATCHv5 " Jiri Olsa
2012-01-02 9:04 ` [PATCH 1/7] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-02-17 13:46 ` [tip:perf/core] ftrace: Change filter/ notrace " tip-bot for Jiri Olsa
2012-01-02 9:04 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-01-17 1:42 ` Frederic Weisbecker
2012-01-17 2:07 ` Steven Rostedt
2012-01-17 2:29 ` Frederic Weisbecker
2012-01-18 13:59 ` Jiri Olsa
2012-01-02 9:04 ` [PATCH 3/7] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2012-01-02 9:04 ` [PATCH 4/7] ftrace, perf: Add add/del " Jiri Olsa
2012-01-02 9:04 ` [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2012-01-02 9:04 ` [PATCH 6/7] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2012-01-02 9:04 ` [PATCH 7/7] ftrace, perf: Add filter support for function trace event Jiri Olsa
2012-01-16 23:59 ` Steven Rostedt
2012-01-18 13:45 ` Jiri Olsa
2012-01-16 8:57 ` [PATCHv5 0/7] ftrace, perf: Adding support to use function trace Jiri Olsa
2012-01-16 16:17 ` Steven Rostedt
2012-01-18 18:44 ` [PATCHv6 " Jiri Olsa
2012-01-18 18:44 ` [PATCH 1/7] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-01-19 16:31 ` Frederic Weisbecker
2012-01-18 18:44 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-01-20 17:02 ` Frederic Weisbecker
2012-01-25 23:13 ` Steven Rostedt
2012-01-26 2:37 ` Frederic Weisbecker
2012-01-27 10:37 ` Jiri Olsa
2012-01-27 10:38 ` Jiri Olsa
2012-01-27 16:40 ` Frederic Weisbecker
2012-01-27 16:54 ` Jiri Olsa
2012-01-27 17:02 ` Frederic Weisbecker
2012-01-27 17:20 ` Jiri Olsa
2012-01-28 16:39 ` Frederic Weisbecker
2012-01-27 17:21 ` Steven Rostedt
2012-01-18 18:44 ` [PATCH 3/7] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2012-01-18 18:44 ` [PATCH 4/7] ftrace, perf: Add add/del " Jiri Olsa
2012-01-18 18:44 ` [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2012-01-18 18:44 ` [PATCH 6/7] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2012-01-18 18:44 ` [PATCH 7/7] ftrace, perf: Add filter support for function trace event Jiri Olsa
2012-01-18 21:43 ` [PATCHv6 0/7] ftrace, perf: Adding support to use function trace Steven Rostedt
2012-01-28 18:43 ` [PATCHv7 " Jiri Olsa
2012-01-28 18:43 ` [PATCH 1/7] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-01-30 5:42 ` Frederic Weisbecker
2012-01-28 18:43 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-01-30 5:59 ` Frederic Weisbecker
2012-01-30 9:18 ` Jiri Olsa
2012-02-03 13:42 ` Steven Rostedt
2012-02-03 13:50 ` Jiri Olsa
2012-02-03 14:08 ` Steven Rostedt
2012-02-03 14:22 ` [PATCHv8 0/2] first 2 patches passed review Jiri Olsa
2012-02-03 14:22 ` [PATCH 1/2] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-02-03 14:22 ` [PATCH 2/2] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-02-04 13:24 ` [PATCHv8 0/2] first 2 patches passed review Frederic Weisbecker
2012-02-03 13:40 ` [PATCH 2/7] ftrace: Add enable/disable ftrace_ops control interface Steven Rostedt
2012-01-28 18:43 ` [PATCH 3/7] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2012-02-02 17:35 ` Frederic Weisbecker
2012-02-03 10:23 ` Jiri Olsa
2012-01-28 18:43 ` [PATCH 4/7] ftrace, perf: Add add/del " Jiri Olsa
2012-02-02 17:42 ` Frederic Weisbecker
2012-01-28 18:43 ` [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2012-02-02 18:14 ` Frederic Weisbecker [this message]
2012-02-03 12:54 ` Jiri Olsa
2012-02-03 13:00 ` Jiri Olsa
2012-02-03 14:07 ` Steven Rostedt
2012-02-04 13:21 ` Frederic Weisbecker
2012-02-06 19:35 ` Steven Rostedt
2012-02-03 13:53 ` Steven Rostedt
2012-01-28 18:43 ` [PATCH 6/7] ftrace, perf: Distinguish ftrace function event field type Jiri Olsa
2012-02-03 14:16 ` Steven Rostedt
2012-01-28 18:43 ` [PATCH 7/7] ftrace, perf: Add filter support for function trace event Jiri Olsa
2012-02-07 0:20 ` Jiri Olsa
2012-02-07 19:44 ` [PATCHv8 0/8] ftrace, perf: Adding support to use function trace Jiri Olsa
2012-02-07 19:44 ` [PATCH 1/8] ftrace: Change filter/notrace set functions to return exit code Jiri Olsa
2012-02-07 19:44 ` [PATCH 2/8] ftrace: Add enable/disable ftrace_ops control interface Jiri Olsa
2012-02-07 19:44 ` [PATCH 3/8] ftrace, perf: Add open/close tracepoint perf registration actions Jiri Olsa
2012-02-07 19:44 ` [PATCH 4/8] ftrace, perf: Add add/del " Jiri Olsa
2012-02-07 19:44 ` [PATCH 5/8] ftrace: Add FTRACE_ENTRY_REG macro to allow event registration Jiri Olsa
2012-02-07 19:44 ` [PATCH 6/8] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2012-02-07 19:44 ` [PATCH 7/8] ftrace: Allow to specify filter field type for ftrace events Jiri Olsa
2012-02-07 19:44 ` [PATCH 8/8] ftrace, perf: Add filter support for function trace event Jiri Olsa
2012-02-10 13:27 ` [PATCHv8 0/8] ftrace, perf: Adding support to use function trace Steven Rostedt
2012-02-10 14:45 ` Steven Rostedt
2012-02-10 16:07 ` Jiri Olsa
2012-02-10 16:48 ` Frederic Weisbecker
2012-02-10 18:00 ` Steven Rostedt
2012-02-10 18:05 ` Frederic Weisbecker
2012-02-10 18:23 ` David Ahern
2012-02-13 18:02 ` Steven Rostedt
2012-02-15 14:51 [PATCHv9 0/7] " Jiri Olsa
2012-02-15 14:51 ` [PATCH 5/7] ftrace, perf: Add support to use function tracepoint in perf Jiri Olsa
2012-02-15 16:03 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120202181409.GH9071@somewhere.redhat.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=aarapov@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).