From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org,
Balbir Singh <bsingharora@gmail.com>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/6] memcg: fix unused variable warning
Date: Mon, 26 Dec 2011 08:47:34 +0200 [thread overview]
Message-ID: <20111226064734.GA13355@shutemov.name> (raw)
In-Reply-To: <20111226154252.d3621532.kamezawa.hiroyu@jp.fujitsu.com>
On Mon, Dec 26, 2011 at 03:42:52PM +0900, KAMEZAWA Hiroyuki wrote:
> On Mon, 26 Dec 2011 08:36:52 +0200
> "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
>
> > On Mon, Dec 26, 2011 at 03:25:31PM +0900, KAMEZAWA Hiroyuki wrote:
> > > On Sat, 24 Dec 2011 05:00:14 +0200
> > > "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
> > >
> > > > From: "Kirill A. Shutemov" <kirill@shutemov.name>
> > > >
> > > > mm/memcontrol.c: In function ‘memcg_check_events’:
> > > > mm/memcontrol.c:784:22: warning: unused variable ‘do_numainfo’ [-Wunused-variable]
> > > >
> > > > Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
> > >
> > > Hmm ? Doesn't this fix cause a new Warning ?
> > >
> > > mm/memcontrol.c: In function ?memcg_check_events?:
> > > mm/memcontrol.c:789: warning: ISO C90 forbids mixed declarations and code
> >
> > I don't see how. The result code is:
> >
> > if (unlikely(mem_cgroup_event_ratelimit(memcg,
> > MEM_CGROUP_TARGET_THRESH))) {
> > bool do_softlimit;
> >
> > #if MAX_NUMNODES > 1
> > bool do_numainfo;
> > do_numainfo = mem_cgroup_event_ratelimit(memcg,
> > MEM_CGROUP_TARGET_NUMAINFO);
> > #endif
> > do_softlimit = mem_cgroup_event_ratelimit(memcg,
> > MEM_CGROUP_TARGET_SOFTLIMIT);
> > preempt_enable();
> >
> > mem_cgroup_threshold(memcg);
> >
>
> Ah. please see linux-next and rebase onto that.
The patchset is on top of next-20111222. Have I missed something?
>
> Thanks,
> -Kame
>
--
Kirill A. Shutemov
next prev parent reply other threads:[~2011-12-26 6:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-24 3:00 [PATCH 1/6] memcg: fix unused variable warning Kirill A. Shutemov
2011-12-24 3:00 ` [PATCH 2/6] memcg: mark more functions/variables as static Kirill A. Shutemov
2011-12-26 6:28 ` KAMEZAWA Hiroyuki
2011-12-27 14:05 ` Michal Hocko
2011-12-24 3:00 ` [PATCH 3/6] memcg: remove unused variable Kirill A. Shutemov
2011-12-26 6:29 ` KAMEZAWA Hiroyuki
2011-12-27 14:08 ` Michal Hocko
2011-12-24 3:00 ` [PATCH 4/6] memcg: mark stat field of mem_cgroup struct as __percpu Kirill A. Shutemov
2011-12-26 6:30 ` KAMEZAWA Hiroyuki
2011-12-27 14:11 ` Michal Hocko
2011-12-24 3:00 ` [PATCH 5/6] memcg: fix broken boolen expression Kirill A. Shutemov
2011-12-26 6:31 ` KAMEZAWA Hiroyuki
2011-12-26 6:57 ` Kirill A. Shutemov
2012-01-03 20:54 ` Greg KH
2011-12-27 14:17 ` Michal Hocko
2012-04-04 21:34 ` Andrew Morton
2012-04-05 10:17 ` Kirill A. Shutemov
2011-12-24 3:00 ` [PATCH 6/6] memcg: drop redundant brackets Kirill A. Shutemov
2011-12-26 6:40 ` KAMEZAWA Hiroyuki
2011-12-27 14:28 ` Michal Hocko
2011-12-26 6:25 ` [PATCH 1/6] memcg: fix unused variable warning KAMEZAWA Hiroyuki
2011-12-26 6:36 ` Kirill A. Shutemov
2011-12-26 6:42 ` KAMEZAWA Hiroyuki
2011-12-26 6:47 ` Kirill A. Shutemov [this message]
2011-12-26 6:50 ` KAMEZAWA Hiroyuki
2011-12-27 13:57 ` [PATCH] Makefiles: Disable unused-variable warning (was: Re: [PATCH 1/6] memcg: fix unused variable warning) Michal Hocko
2011-12-27 18:26 ` Kirill A. Shutemov
2011-12-29 10:42 ` Michal Hocko
2011-12-29 11:08 ` Kirill A. Shutemov
2011-12-29 11:16 ` Michal Hocko
2012-01-08 15:01 ` [PATCH] Makefiles: Disable unused-variable warning Michal Marek
2012-01-10 8:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111226064734.GA13355@shutemov.name \
--to=kirill@shutemov.name \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).