From: Michal Hocko <mhocko@suse.cz>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org,
containers@lists.linux-foundation.org,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Balbir Singh <bsingharora@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 2/6] memcg: mark more functions/variables as static
Date: Tue, 27 Dec 2011 15:05:15 +0100 [thread overview]
Message-ID: <20111227140515.GL5344@tiehlicka.suse.cz> (raw)
In-Reply-To: <1324695619-5537-2-git-send-email-kirill@shutemov.name>
On Sat 24-12-11 05:00:15, Kirill A. Shutemov wrote:
> From: "Kirill A. Shutemov" <kirill@shutemov.name>
>
> Based on sparse output.
>
> Signed-off-by: Kirill A. Shutemov <kirill@shutemov.name>
Looks good.
Acked-by: Michal Hocko <mhocko@suse.cz>
Thanks
> ---
> mm/memcontrol.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index a5e92bd..4bac3a2 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -59,7 +59,7 @@
>
> struct cgroup_subsys mem_cgroup_subsys __read_mostly;
> #define MEM_CGROUP_RECLAIM_RETRIES 5
> -struct mem_cgroup *root_mem_cgroup __read_mostly;
> +static struct mem_cgroup *root_mem_cgroup __read_mostly;
>
> #ifdef CONFIG_CGROUP_MEM_RES_CTLR_SWAP
> /* Turned on only when memory cgroup is enabled && really_do_swap_account = 1 */
> @@ -1573,7 +1573,7 @@ int mem_cgroup_select_victim_node(struct mem_cgroup *memcg)
> * unused nodes. But scan_nodes is lazily updated and may not cotain
> * enough new information. We need to do double check.
> */
> -bool mem_cgroup_reclaimable(struct mem_cgroup *memcg, bool noswap)
> +static bool mem_cgroup_reclaimable(struct mem_cgroup *memcg, bool noswap)
> {
> int nid;
>
> @@ -1608,7 +1608,7 @@ int mem_cgroup_select_victim_node(struct mem_cgroup *memcg)
> return 0;
> }
>
> -bool mem_cgroup_reclaimable(struct mem_cgroup *memcg, bool noswap)
> +static bool mem_cgroup_reclaimable(struct mem_cgroup *memcg, bool noswap)
> {
> return test_mem_cgroup_node_reclaimable(memcg, 0, noswap);
> }
> @@ -1782,7 +1782,7 @@ static void memcg_oom_recover(struct mem_cgroup *memcg)
> /*
> * try to call OOM killer. returns false if we should exit memory-reclaim loop.
> */
> -bool mem_cgroup_handle_oom(struct mem_cgroup *memcg, gfp_t mask)
> +static bool mem_cgroup_handle_oom(struct mem_cgroup *memcg, gfp_t mask)
> {
> struct oom_wait_info owait;
> bool locked, need_to_kill;
> @@ -3765,7 +3765,7 @@ try_to_free:
> goto move_account;
> }
>
> -int mem_cgroup_force_empty_write(struct cgroup *cont, unsigned int event)
> +static int mem_cgroup_force_empty_write(struct cgroup *cont, unsigned int event)
> {
> return mem_cgroup_force_empty(mem_cgroup_from_cont(cont), true);
> }
> @@ -4044,7 +4044,7 @@ struct mcs_total_stat {
> s64 stat[NR_MCS_STAT];
> };
>
> -struct {
> +static struct {
> char *local_name;
> char *total_name;
> } memcg_stat_strings[NR_MCS_STAT] = {
> --
> 1.7.7.3
>
--
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9
Czech Republic
next prev parent reply other threads:[~2011-12-27 14:05 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-24 3:00 [PATCH 1/6] memcg: fix unused variable warning Kirill A. Shutemov
2011-12-24 3:00 ` [PATCH 2/6] memcg: mark more functions/variables as static Kirill A. Shutemov
2011-12-26 6:28 ` KAMEZAWA Hiroyuki
2011-12-27 14:05 ` Michal Hocko [this message]
2011-12-24 3:00 ` [PATCH 3/6] memcg: remove unused variable Kirill A. Shutemov
2011-12-26 6:29 ` KAMEZAWA Hiroyuki
2011-12-27 14:08 ` Michal Hocko
2011-12-24 3:00 ` [PATCH 4/6] memcg: mark stat field of mem_cgroup struct as __percpu Kirill A. Shutemov
2011-12-26 6:30 ` KAMEZAWA Hiroyuki
2011-12-27 14:11 ` Michal Hocko
2011-12-24 3:00 ` [PATCH 5/6] memcg: fix broken boolen expression Kirill A. Shutemov
2011-12-26 6:31 ` KAMEZAWA Hiroyuki
2011-12-26 6:57 ` Kirill A. Shutemov
2012-01-03 20:54 ` Greg KH
2011-12-27 14:17 ` Michal Hocko
2012-04-04 21:34 ` Andrew Morton
2012-04-05 10:17 ` Kirill A. Shutemov
2011-12-24 3:00 ` [PATCH 6/6] memcg: drop redundant brackets Kirill A. Shutemov
2011-12-26 6:40 ` KAMEZAWA Hiroyuki
2011-12-27 14:28 ` Michal Hocko
2011-12-26 6:25 ` [PATCH 1/6] memcg: fix unused variable warning KAMEZAWA Hiroyuki
2011-12-26 6:36 ` Kirill A. Shutemov
2011-12-26 6:42 ` KAMEZAWA Hiroyuki
2011-12-26 6:47 ` Kirill A. Shutemov
2011-12-26 6:50 ` KAMEZAWA Hiroyuki
2011-12-27 13:57 ` [PATCH] Makefiles: Disable unused-variable warning (was: Re: [PATCH 1/6] memcg: fix unused variable warning) Michal Hocko
2011-12-27 18:26 ` Kirill A. Shutemov
2011-12-29 10:42 ` Michal Hocko
2011-12-29 11:08 ` Kirill A. Shutemov
2011-12-29 11:16 ` Michal Hocko
2012-01-08 15:01 ` [PATCH] Makefiles: Disable unused-variable warning Michal Marek
2012-01-10 8:52 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111227140515.GL5344@tiehlicka.suse.cz \
--to=mhocko@suse.cz \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).