linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bq20z75: fix devicetree match table
@ 2011-12-23  2:37 Olof Johansson
  2012-01-03 18:46 ` Rhyland Klein
  0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2011-12-23  2:37 UTC (permalink / raw)
  To: Anton Vorontsov; +Cc: Rhyland Klein, linux-kernel, Olof Johansson

It should be an of module table, not i2c.

Signed-off-by: Olof Johansson <olof@lixom.net>
---
 drivers/power/bq20z75.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/power/bq20z75.c b/drivers/power/bq20z75.c
index ce95ff7..3efca54 100644
--- a/drivers/power/bq20z75.c
+++ b/drivers/power/bq20z75.c
@@ -622,7 +622,7 @@ static const struct of_device_id bq20z75_dt_ids[] = {
 	{ .compatible = "ti,bq20z75" },
 	{ }
 };
-MODULE_DEVICE_TABLE(i2c, bq20z75_dt_ids);
+MODULE_DEVICE_TABLE(of, bq20z75_dt_ids);
 
 static struct bq20z75_platform_data *bq20z75_of_populate_pdata(
 		struct i2c_client *client)
-- 
1.7.8.GIT


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] bq20z75: fix devicetree match table
  2011-12-23  2:37 [PATCH] bq20z75: fix devicetree match table Olof Johansson
@ 2012-01-03 18:46 ` Rhyland Klein
  2012-01-06  1:47   ` Anton Vorontsov
  0 siblings, 1 reply; 3+ messages in thread
From: Rhyland Klein @ 2012-01-03 18:46 UTC (permalink / raw)
  To: Olof Johansson; +Cc: Anton Vorontsov, linux-kernel

On Thu, 2011-12-22 at 18:37 -0800, Olof Johansson wrote:
> It should be an of module table, not i2c.
> 
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>  drivers/power/bq20z75.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/power/bq20z75.c b/drivers/power/bq20z75.c
> index ce95ff7..3efca54 100644
> --- a/drivers/power/bq20z75.c
> +++ b/drivers/power/bq20z75.c
> @@ -622,7 +622,7 @@ static const struct of_device_id bq20z75_dt_ids[] = {
>  	{ .compatible = "ti,bq20z75" },
>  	{ }
>  };
> -MODULE_DEVICE_TABLE(i2c, bq20z75_dt_ids);
> +MODULE_DEVICE_TABLE(of, bq20z75_dt_ids);
>  
>  static struct bq20z75_platform_data *bq20z75_of_populate_pdata(
>  		struct i2c_client *client)

Acked-by: Rhyland Klein <rklein@nvidia.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] bq20z75: fix devicetree match table
  2012-01-03 18:46 ` Rhyland Klein
@ 2012-01-06  1:47   ` Anton Vorontsov
  0 siblings, 0 replies; 3+ messages in thread
From: Anton Vorontsov @ 2012-01-06  1:47 UTC (permalink / raw)
  To: Rhyland Klein; +Cc: Olof Johansson, linux-kernel

On Tue, Jan 03, 2012 at 10:46:46AM -0800, Rhyland Klein wrote:
> On Thu, 2011-12-22 at 18:37 -0800, Olof Johansson wrote:
> > It should be an of module table, not i2c.
> > 
> > Signed-off-by: Olof Johansson <olof@lixom.net>
> > ---
> >  drivers/power/bq20z75.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/power/bq20z75.c b/drivers/power/bq20z75.c
> > index ce95ff7..3efca54 100644
> > --- a/drivers/power/bq20z75.c
> > +++ b/drivers/power/bq20z75.c
> > @@ -622,7 +622,7 @@ static const struct of_device_id bq20z75_dt_ids[] = {
> >  	{ .compatible = "ti,bq20z75" },
> >  	{ }
> >  };
> > -MODULE_DEVICE_TABLE(i2c, bq20z75_dt_ids);
> > +MODULE_DEVICE_TABLE(of, bq20z75_dt_ids);
> >  
> >  static struct bq20z75_platform_data *bq20z75_of_populate_pdata(
> >  		struct i2c_client *client)
> 
> Acked-by: Rhyland Klein <rklein@nvidia.com>

Applied, thanks! (The driver is 'sbs-battery' nowadays. So I modified
the patch a little bit.)

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-06  1:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-23  2:37 [PATCH] bq20z75: fix devicetree match table Olof Johansson
2012-01-03 18:46 ` Rhyland Klein
2012-01-06  1:47   ` Anton Vorontsov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).