From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, robert.richter@amd.com
Subject: Re: [PATCH] perf: fix broken perf inject -b
Date: Fri, 13 Jan 2012 14:53:15 -0200 [thread overview]
Message-ID: <20120113165315.GA24387@infradead.org> (raw)
In-Reply-To: <20120113144731.GA5458@quad>
Em Fri, Jan 13, 2012 at 03:47:31PM +0100, Stephane Eranian escreveu:
>
> perf inject -b was broken. It would not inject any build_ids
> into the stream. Furthermore, it would strip samples from the
> stream.
Against which tree is this patch?
> The reason was a missing initialization of the event attribute
> structures. The perf_tool.tool.attr() callback was pointing to
> a simple repipe. But there was no initialization of internal data
> structures to keep track of events and event ids. That later caused
> event id lookups to fail, and samples would get dropped.
>
> The patch simply adds back the call to perf_event__process_attr()
> to initialize the evlist structure. Build_ids are again injected.
> The PID is also inject for PERF_RECORD_HEADER_BUILD_ID.
>
> Signed-off-by: Stephane Eranian <eranian@google.com>
> ---
>
> diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
> index 09c1061..f38f370 100644
> --- a/tools/perf/builtin-inject.c
> +++ b/tools/perf/builtin-inject.c
> @@ -60,6 +60,11 @@ static int perf_event__repipe_tracing_data_synth(union perf_event *event,
> static int perf_event__repipe_attr(union perf_event *event,
> struct perf_evlist **pevlist __used)
> {
> + int ret;
> + ret = perf_event__process_attr(event, pevlist);
> + if (ret)
> + return ret;
> +
> return perf_event__repipe_synth(NULL, event, NULL);
> }
>
> @@ -173,6 +178,7 @@ static int perf_event__inject_buildid(struct perf_tool *tool,
> event->header.type);
> goto repipe;
> }
> + machine->pid = event->ip.pid;
>
> thread__find_addr_map(thread, machine, cpumode, MAP__FUNCTION,
> event->ip.ip, &al);
next prev parent reply other threads:[~2012-01-13 16:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 14:47 [PATCH] perf: fix broken perf inject -b Stephane Eranian
2012-01-13 16:53 ` Arnaldo Carvalho de Melo [this message]
2012-01-13 16:54 ` Stephane Eranian
2012-01-16 18:53 ` Stephane Eranian
2012-01-30 19:00 ` Arnaldo Carvalho de Melo
2012-01-30 19:53 ` Stephane Eranian
2012-01-30 20:04 ` Arnaldo Carvalho de Melo
2012-01-30 20:09 ` Stephane Eranian
2012-01-30 20:36 ` Arnaldo Carvalho de Melo
2012-01-31 5:58 ` Yanmin Zhang
2012-02-02 11:22 ` Stephane Eranian
2012-02-03 3:30 ` Yanmin Zhang
2012-01-26 14:16 ` Stephane Eranian
2012-01-26 14:23 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120113165315.GA24387@infradead.org \
--to=acme@redhat.com \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).